Re: [Maria-developers] request for a feature -- LIMIT_ROWS_EXAMINED

2012-01-23 Thread MARK CALLAGHAN
Yes, I accept On Mon, Jan 23, 2012 at 4:12 AM, Timour Katchaounov wrote: > Mark, > > >> The semantics are good for us. The potential overhead from the >> implementation isn't a concern for our uses. What was the feedback >> from the MPAB code review? > > > I haven't submitted the code for review

Re: [Maria-developers] MDEV-30: "mtr extensions for storage engine testing" review

2012-01-23 Thread Sergei Golubchik
Hi, Kristian! On Jan 23, Kristian Nielsen wrote: > Hi Serg! > > As promised, I read through your MDEV-30, "mtr extensions for storage engine > testing". > > Generally I think it looks good and reasonable. Here are a few comments: > > - --record should have options so that it can generate .rdif

[Maria-developers] MDEV-30: "mtr extensions for storage engine testing" review

2012-01-23 Thread Kristian Nielsen
Hi Serg! As promised, I read through your MDEV-30, "mtr extensions for storage engine testing". Generally I think it looks good and reasonable. Here are a few comments: - --record should have options so that it can generate .rdiff or .COMBI.result. So one could say eg. ./mtr --record=rdiff