Re: [Maria-developers] Review of microsecond patch

2011-05-19 Thread Sergei Golubchik
Hi, Michael! On May 19, Michael Widenius wrote: > I don't remember any tests where you tested prepare stmt and > microseconds. Did you add such a test somewhere else? I've run everything with --ps-protocol > >> > -void Field_timestamp::set_time() > >> > +int Field_timestamp::set_time() > >> >

Re: [Maria-developers] [Commits] Rev 2992: Removed some alias warnings in lp:maria/5.3

2011-05-19 Thread Michael Widenius
Hi! > "Kristian" == Kristian Nielsen writes: >> === modified file 'sql/item_subselect.cc' >> --- a/sql/item_subselect.cc 2011-05-16 12:07:04 + >> +++ b/sql/item_subselect.cc 2011-05-17 21:47:56 + >> @@ -3563,7 +3562,15 @@ subselect_single_select_engine::change_r >> } >> else >>

Re: [Maria-developers] Review of microsecond patch

2011-05-19 Thread Michael Widenius
Hi! > "Sergei" == Sergei Golubchik writes: >> > === modified file 'mysql-test/r/date_formats.result' >> > --- mysql-test/r/date_formats.result 2010-11-12 10:12:15 + >> > +++ mysql-test/r/date_formats.result 2011-03-08 18:41:58 + >> > @@ -196,16 +196,16 @@ date format

Re: [Maria-developers] [Commits] Rev 2994: Original idea from Zardosht Kasheff to add HA_CLUSTERED_INDEX in lp:maria/5.3

2011-05-19 Thread Sergei Golubchik
Hi, Michael! On May 19, Michael Widenius wrote: > > >> +++ b/sql/sql_select.cc2011-05-18 16:26:30 + > >> @@ -16525,9 +16527,9 @@ test_if_skip_sort_order(JOIN_TAB *tab,OR > >> */ > >> DBUG_ASSERT (ref_key != (int) nr); > >> > >> -bool is_covering= table->covering_keys.is_set(nr) |

Re: [Maria-developers] mysql improvement idea - field type "file"

2011-05-19 Thread Peter Laursen
Actually I believe that could be implemented as a storage engine? The database would be the par of the file system that mysqld can access for both read and write. Each table in it would be a folder and every distinct value a file. A few additional syntactical constructs would be needed (but lots of

Re: [Maria-developers] [Commits] Rev 2994: Original idea from Zardosht Kasheff to add HA_CLUSTERED_INDEX in lp:maria/5.3

2011-05-19 Thread Michael Widenius
Hi! > "Sergei" == Sergei Golubchik writes: >> + Data is clustered on this key. This means that when you read the key >> + you also get the row data in the same block. Sergei> perhaps, better to say that "you get the row data without an extra seek Sergei> (or even without an extra disk

Re: [Maria-developers] feedback on proposed fix to MySQL bug 57430

2011-05-19 Thread Jocelyn Fournier
Hi, Will this fix also solve the bug http://bugs.mysql.com/bug.php?id=36817 (and reopened in maria as https://bugs.launchpad.net/maria/+bug/639949 ) ? Thanks and regards, Jocelyn Fournier Le 19/05/2011 16:46, Michael Widenius a écrit : Hi! "Zardosht" == Zardosht Kasheff writes: Zardo

[Maria-developers] mysql improvement idea - field type "file"

2011-05-19 Thread Tõnu Samuel
( 1. Sent this mail few days ago to Monty but no answer yet. I know, he is busy man. 2. I use name "MySQL" because this is real name for me. Oracle still sucks:P ) Hi! We all have seen cases where people try to use SQL for something what does not fit there. Reason is simple - file system itse

Re: [Maria-developers] feedback on proposed fix to MySQL bug 57430

2011-05-19 Thread Michael Widenius
Hi! > "Zardosht" == Zardosht Kasheff writes: Zardosht> The issue that I see with this proposal is that if quick_records is Zardosht> much much greater than best_records, then we may not want to set Zardosht> best_key to nr even though this nr is a covering index. Agree, but this is what is

Re: [Maria-developers] feedback on proposed fix to MySQL bug 57430

2011-05-19 Thread Zardosht Kasheff
The issue that I see with this proposal is that if quick_records is much much greater than best_records, then we may not want to set best_key to nr even though this nr is a covering index. On Thu, May 19, 2011 at 6:04 AM, Michael Widenius wrote: > > Hi! > >> "Zardosht" == Zardosht Kasheff wr

Re: [Maria-developers] Review of microsecond patch

2011-05-19 Thread Sergei Golubchik
Hi, Michael! On Apr 05, Michael Widenius wrote: > Here is finally a review of the microsecond patch. Thanks! > > === modified file 'client/mysqltest.cc' > > --- client/mysqltest.cc 2010-11-22 09:21:10 + > > +++ client/mysqltest.cc 2011-02-23 17:26:02 + > > @@ -7342,7 +7342,8 @@ i

Re: [Maria-developers] [Commits] Rev 2994: Original idea from Zardosht Kasheff to add HA_CLUSTERED_INDEX in lp:maria/5.3

2011-05-19 Thread Sergei Golubchik
Hi, Michael! On May 18, Michael Widenius wrote: > === modified file 'sql/handler.h' > --- a/sql/handler.h 2011-05-16 11:05:45 + > +++ b/sql/handler.h 2011-05-18 16:26:30 + > @@ -161,8 +161,11 @@ > */ > #define HA_KEY_SCAN_NOT_ROR 128 > #define HA_DO_INDEX_COND_PUSHDOWN 256 /*

Re: [Maria-developers] proposed patches for MWL#113: many clustered keys (not only primary)

2011-05-19 Thread Michael Widenius
Hi! > "Zardosht" == Zardosht Kasheff writes: Zardosht> Hello Monty, Zardosht> Thank you for your feedback on the four diffs and for approving them. Zardosht> This makes getting TokuDB to work with MariaDB much simpler. Zardosht> I could not tell from the original email, but is the change S

Re: [Maria-developers] feedback on proposed fix to MySQL bug 57430

2011-05-19 Thread Michael Widenius
Hi! > "Zardosht" == Zardosht Kasheff writes: Zardosht> Hello all, Zardosht> Continuing with patch contributions (as encouraged at the storage Zardosht> engine summit last Friday), here is a very simple patch we have to fix Zardosht> MySQL bug 57430 (http://bugs.mysql.com/bug.php?id=57430).