Re: [Maria-developers] Summary of the storage engine API changes for group commit

2011-04-06 Thread MARK CALLAGHAN
OK, that is what I wanted to know. On Wed, Apr 6, 2011 at 6:16 AM, Kristian Nielsen wrote: > MARK CALLAGHAN writes: > >> Is commit_ordered called before or after the transaction's XID event >> has been written to the binlog? >> after it has been forced (fsync) to the binlog? > > It is called

Re: [Maria-developers] Summary of the storage engine API changes for group commit

2011-04-06 Thread Kristian Nielsen
MARK CALLAGHAN writes: > Is commit_ordered called before or after the transaction's XID event > has been written to the binlog? > after it has been forced (fsync) to the binlog? It is called just after XID event has been written (and fsync()ed in case of sync_binlog=1) to binlog. - Kristia

Re: [Maria-developers] Summary of the storage engine API changes for group commit

2011-04-06 Thread MARK CALLAGHAN
Is commit_ordered called before or after the transaction's XID event has been written to the binlog? after it has been forced (fsync) to the binlog? On Wed, Apr 6, 2011 at 12:16 AM, Kristian Nielsen wrote: > Hi Serg, > > As promised, here is a summary of the changes to the storage engine API

Re: [Maria-developers] Default parameter settings / Windows MSI installer

2011-04-06 Thread Vladislav Vaintroub
> -Original Message- > From: Philip Stoev [mailto:pst...@askmonty.org] > Sent: Mittwoch, 6. April 2011 13:10 > To: Vladislav Vaintroub > Cc: maria-developers@lists.launchpad.net; Kazuhisa Ichikawa; Peter Laursen; > Arjen Lentz; haidong...@gmail.com > Subject: Re: Default parameter setting

Re: [Maria-developers] Default parameter settings / Windows MSI installer

2011-04-06 Thread Philip Stoev
I think we need to avoid a situation where there is yet another set of mariadb defaults located in yet another place (in this case, I assume in the WiX XML description file). Previously, we already had a situation with the old MySQL windows config wizard where an option would be deprecated and

Re: [Maria-developers] Summary of the storage engine API changes for group commit

2011-04-06 Thread Sergei Golubchik
Hi, Kristian! On Apr 06, Kristian Nielsen wrote: > > As promised, here is a summary of the changes to the storage engine > API that I made as part of group commit. > > Two new handlerton methods are added: > > void (*prepare_ordered)(handlerton *hton, THD *thd, bool all); > void (*commi

Re: [Maria-developers] dist-hook in top-level Makefile.am

2011-04-06 Thread Vladislav Vaintroub
> -Original Message- > From: Kristian Nielsen [mailto:kniel...@knielsen-hq.org] > Sent: Mittwoch, 6. April 2011 10:43 > To: Vladislav Vaintroub > Cc: maria-developers@lists.launchpad.net > Subject: Re: dist-hook in top-level Makefile.am Hi Kristian. > You need to be careful when you rem

Re: [Maria-developers] dist-hook in top-level Makefile.am

2011-04-06 Thread Kristian Nielsen
"Vladislav Vaintroub" writes: > Kristian, now that Windows builds in 5.2+ are self-sufficient and can > produce different packages from bzr, do you see any reason to keep this hook > in the top-level Makefile.am? > > If not, I can remove, or you can remove it if you prefer. Will make our > source

[Maria-developers] Summary of the storage engine API changes for group commit

2011-04-06 Thread Kristian Nielsen
Hi Serg, As promised, here is a summary of the changes to the storage engine API that I made as part of group commit. Two new handlerton methods are added: void (*prepare_ordered)(handlerton *hton, THD *thd, bool all); void (*commit_ordered)(handlerton *hton, THD *thd, bool all); commit