Re: [Maria-developers] [Commits] Rev 2827: Ported the fix for bug #57024 (a performance issue for outer joins). in file:///home/igor/maria/maria-5.3-mwl128-bug57024/

2010-10-06 Thread Timour Katchaounov
Igor, Why not take the opportunity to change the format of all comments to Doxygen format. It doesn't make sense to have two formats for comments, and I've seen you adding new comments in new code in Doxygen format. Timour On 10/06/10 14:08, Sergey Petrunya wrote: Hello Igor, Please find some

Re: [Maria-developers] Transactional INFORMATION_SCHEMA / status variables?

2010-10-06 Thread Sergei Golubchik
Hi, Kristian! On Oct 06, Kristian Nielsen wrote: > > Would it make sense to have transactional behaviour for status > variables, and/or information_schema tables? Or does this break the > code and/or user expectations too much? > > The motivation is to follow up on MWL#116, group commit, which >

Re: [Maria-developers] DS-MRR improvements patch r3 ready for review

2010-10-06 Thread Sergey Petrunya
On Mon, Oct 04, 2010 at 10:54:37AM +0400, Sergey Petrunya wrote: > Hello Igor, > > Please find attached the combined patch that addresses all of the review > feedback provided so far. > > The tree is in launchpad and buildbot also: > https://code.launchpad.net/~maria-captains/maria/5.3-dsmrr-cpk

Re: [Maria-developers] [Commits] Rev 2827: Ported the fix for bug #57024 (a performance issue for outer joins). in file:///home/igor/maria/maria-5.3-mwl128-bug57024/

2010-10-06 Thread Sergey Petrunya
Hello Igor, Please find some minor comments below. Ok to push after they are addressed. On Wed, Oct 06, 2010 at 05:14:08AM -0700, Igor Babaev wrote: > At file:///home/igor/maria/maria-5.3-mwl128-bug57024/ > > > revno: 2827 > revision-

Re: [Maria-developers] I am more than happy to test aria with largedatabases

2010-10-06 Thread Philip Stoev
Mark, Thank you very much for your offer. I think it would be very beneficial for us if we can somehow take advantage of your dataset (CentOS should be just fine). Aria does not yet support Merge tables, however can you give more information about the underlying tables and the overall databa

[Maria-developers] Transactional INFORMATION_SCHEMA / status variables?

2010-10-06 Thread Kristian Nielsen
Would it make sense to have transactional behaviour for status variables, and/or information_schema tables? Or does this break the code and/or user expectations too much? The motivation is to follow up on MWL#116, group commit, which introduces consistent commit order between storage engines and b

Re: [Maria-developers] Implementing new "group commit" API in PBXT?

2010-10-06 Thread Paul McCullagh
On Oct 5, 2010, at 3:10 PM, Kristian Nielsen wrote: Paul McCullagh writes: The easiest way to do this would be to add a parameter to xn_end_xact() that indicates that the log should not be written or flushed. Ok, I gave it a shot, but I had some problems due to not knowing the PBXT code