Re: [Maria-developers] Handling size_t -> int conversions

2010-08-18 Thread Stewart Smith
On Wed, 18 Aug 2010 15:25:22 +0200, Bo Thorsen wrote: > How do you guys prefer to see patches on this - one big patch, or > several smaller patches? >From our experience doing this in Drizzle, smaller patches are better. You will, inevitably, screw up somewhere. It's just the way things go. Be

Re: [Maria-developers] Handling size_t -> int conversions

2010-08-18 Thread Sergei Golubchik
Hi, Bo! On Aug 18, Bo Thorsen wrote: > > I'm working on getting rid of the compiler warnings on 64 bit Windows. > > There are literally thousands of places, where we store a size_t in an int, > and the compiler warns about possible loss of data. > > I'm trying to figure out how to handle this in

[Maria-developers] Handling size_t -> int conversions

2010-08-18 Thread Bo Thorsen
I'm working on getting rid of the compiler warnings on 64 bit Windows. There are literally thousands of places, where we store a size_t in an int, and the compiler warns about possible loss of data. I'm trying to figure out how to handle this in the best way, and I need a bit of advice on how

[Maria-developers] Get rid of all 32 bit Visual Studio compiler warnings

2010-08-18 Thread Bo Thorsen
Hi all, I'm sending this patch again, since I didn't get any responses to the last two mails. The patch is almost identical to the last version except that I have removed some parts of it - those warnings were fixed by someone else after I sent the last version of the patch. Here is the pa

[Maria-developers] Patch: Separate builddir from src dir with cmake

2010-08-18 Thread Bo Thorsen
Hi everyone, I have updated the attached patch to apply to the 5.1 tree. Please see the comments in my original mail below. Any objections to apply this patch? Original Meddelelse Subject: Separate builddir from src dir with cmake Date: Mon, 12 Jul 2010 14:01:23 +0200 From: