On Wed, Apr 8, 2009 at 9:13 AM, Michael Widenius wrote:
>
> Hi!
>
>> "MARK" == MARK CALLAGHAN writes:
>
> MARK> On Wed, Mar 18, 2009 at 7:23 AM, Michael Widenius
> wrote:
>>>
>>> Hi!
>>>
"Vadim" == Vadim Tkachenko writes:
>>>
> Vadim> Michael,
> Vadim> Thread-pool should be used v
#At lp:maria based on revid:sa...@askmonty.org-20090403132308-1rukse34u7ipth73
2691 Michael Widenius 2009-04-08
Fixed wrong test for extra_ip_sock that caused mysqld to die on Mac if
--extra-port was used
modified:
sql/mysqld.cc
sql/sql_string.cc
sql/strfunc.
Hi!
> "Patrick" == Patrick Crews writes:
Patrick> Hi there,
Patrick> I've been playing around with the pool_of_threads addition and here is
some
Patrick> of what I've found:
Patrick> All of this was on Mac OSX 10.5
Patrick> 1) Biggie here: Running the server with the --extra-port=
#At lp:maria
2694 kniel...@knielsen-hq.org 2009-04-08 [merge]
Merge mariadb-5.1
modified:
storage/maria/ma_blockrec.c
=== modified file 'storage/maria/ma_blockrec.c'
--- a/storage/maria/ma_blockrec.c 2009-02-19 09:01:25 +
+++ b/storage/maria/ma_blockrec.c 200
Hi!
> "MARK" == MARK CALLAGHAN writes:
MARK> On Wed, Mar 18, 2009 at 7:23 AM, Michael Widenius
wrote:
>>
>> Hi!
>>
>>> "Vadim" == Vadim Tkachenko writes:
>>
Vadim> Michael,
Vadim> Thread-pool should be used very carefully.
>>
Vadim> We tested it and InnoDB hangs in sysbench bench
Hi!
> "Jeremiah" == Jeremiah Gowdy writes:
Vadim> Michael,
Vadim> Thread-pool should be used very carefully.
>>
Vadim> We tested it and InnoDB hangs in sysbench benchmarks when count of
Vadim> client connection > size of thread-pool.
>>
>> Yes, this a problem when you have more locks than
Hi!
> "knielsen" == knielsen writes:
knielsen> In set_var.cc, several methods construct a String object passing too
knielsen> large lenght for given buffer. The String class assumes 1 more byte is
knielsen> available after the given length for zero termination in
knielsen> String::c_ptr().
Hi!
> "knielsen" == knielsen writes:
knielsen> The sql_string.h String class has some strange code to null-terminate
knielsen> the string for String::c_ptr().
knielsen> It checks if the string is already null-terminated, and only writes
knielsen> the '\0' at the end if it is not already t
hi!
> "knielsen" == knielsen writes:
knielsen> If DbugParse() is called multiple times, the stack->keywords for the
knielsen> top stack frame could be overwritten without being freed, causing a
knielsen> memory leak reported by Valgrind.
knielsen> === modified file 'dbug/dbug.c'
knielsen>
Hi!
> "knielsen" == knielsen writes:
knielsen> After implementing pool_of_threads, the thd->connect_utime and
thd-> start_utime are not always correctly initialized (depending on
knielsen> which thread model is used).
knielsen> === modified file 'sql/mysqld.cc'
knielsen> ---
knielsen> sq
Hi!
> "knielsen" == knielsen writes:
knielsen> The zlib code does operations on uninitialised parts of internal
knielsen> memory, but subsequently does bounds checks and ignores the results of
knielsen> any such undefined operations. This causes Valgrind to give false
knielsen> alarms.
Hi!
> "knielsen" == knielsen writes:
knielsen> === modified file 'mysql-test/valgrind.supp'
knielsen> ---
knielsen> mysql-test/valgrind.supp | 16
knielsen> 1 file changed, 16 insertions(+)
knielsen> Index: mysql-test/valgrind.supp
knielsen> ===
Hi!
> "knielsen" == knielsen writes:
knielsen> (different system library versions generate slightly different stack
knielsen> traces to be suppressed).
knielsen> === modified file 'mysql-test/valgrind.supp'
knielsen> ---
knielsen> mysql-test/valgrind.supp | 15 ++-
knielsen>
Hi!
> "knielsen" == knielsen writes:
knielsen> (Some versions of GCC implement struct_var = struct_var using
knielsen> memcpy(), which violates specs for memcpy() (not allowed for
knielsen> overlapping source and destination).
knielsen> GCC bug 19410: http://gcc.gnu.org/bugzilla/show_bug.
Hi!
> "knielsen" == knielsen writes:
knielsen> === modified file 'sql/mysqld.cc'
knielsen> ---
knielsen> sql/mysqld.cc |4 ++--
knielsen> 1 file changed, 2 insertions(+), 2 deletions(-)
knielsen> Index: sql/mysqld.cc
knielsen> =
Hi!
> "knielsen" == knielsen writes:
knielsen> The globally writable lock file for the mysql-test-run.pl port
knielsen> allocation was not always made globally writable, causing failures for
knielsen> subsequent runs by other users on the same machine.
knielsen> === modified file 'mysql-t
#At lp:maria
2693 kniel...@knielsen-hq.org 2009-04-08
Fix test suite following merge of PBXT
The PBXT engine causes an extra table to appear in the
INFORMATION_SCHEMA. This causes different output for a few test cases.
Fix test suite to avoid any errors from
Michael Widenius writes:
> What I *would* like to change ASAP is that the test file and result
> file is in the same directory so that in 'bzr gcommit' and in 'emacs
> directory' the test and result files comes directly after eachother!
> This has been on the mysqltest TODO for a long time but fo
Michael Widenius writes:
> Looked through the patch, and found only one possible thing to comment
> about:
>
> It lookes liked this case is handled, but from the patch/current code
> it was not trivial to be sure.
>
> - We run some tests, one test fails.
> - Test suite fails totally (for example
Hi!
> "knielsen" == knielsen writes:
knielsen> My previous fix for not ignoring warnings during server shutdown would
knielsen> terminate the test suite completely in case of extra warnings,
knielsen> omitting the error summary at the end.
knielsen> This patch provides a much nicer summar
Hi!
> "Patrick" == Patrick Crews writes:
>> This does not really have to mean using separate files. I have in mind
>> something like a Perl-based suite where I could do:
>>
>> query <> SELECT a, b
>> FROM t1 JOIN t2 ON (a = b)
>> ORDER BY a, b;
>> SQL
>> RECORDME
>> RESULT
>>
>> and `my
21 matches
Mail list logo
