arojas created this revision.
arojas added a reviewer: Marble.
Herald added projects: Marble, KDE Edu.
Herald added subscribers: kde-edu, marble-devel.
arojas requested review of this revision.
REVISION SUMMARY
gps_data_t.fix.time is a struct timespec in gpsd>=3.20
TEST PLAN
Builds with gpsd
cfeck added inline comments.
INLINE COMMENTS
> GpsdPositionProviderPlugin.cpp:117
> +#if defined( GPSD_API_MAJOR_VERSION ) && ( GPSD_API_MAJOR_VERSION >= 9 )
> +if ( !std::isnan( data.fix.time.tv_sec ) && !std::isnan(
> data.fix.time.tv_nsec ) )
> +#else
tv_nsec is a `long`, so it is ne
arojas marked an inline comment as done.
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D26486
To: arojas, #marble
Cc: cfeck, rikmills, marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez,
mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol,
nienhu
arojas updated this revision to Diff 73012.
arojas added a comment.
Remove unnecessary check
REPOSITORY
R34 Marble
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26486?vs=72951&id=73012
REVISION DETAIL
https://phabricator.kde.org/D26486
AFFECTED FILES
src/plugins/positionpro
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Sounds reasonable
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D26486
To: arojas, #marble, aacid
Cc: aacid, cfeck, rikmills, marble-devel, kde-edu, fbampaloukas, tor
This revision was automatically updated to reflect the committed changes.
Closed by commit R34:51e0d9122cf2: Fix build with gpsd 3.20 (authored by
arojas).
REPOSITORY
R34 Marble
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26486?vs=73012&id=73016
REVISION DETAIL
https://phabrica
