D23673: Allow for using Marble with QML Items in external QML files

rahn created this revision. rahn added reviewers: Marble, nienhueser, shentey, sanjibanb. Herald added projects: Marble, KDE Edu. Herald added subscribers: kde-edu, marble-devel. rahn requested review of this revision. REVISION SUMMARY - Exporting the MarbleDeclarativePlugin. - Adding QML GeoI

D23524: Add the Marble writing example in GeoJSON format

rahn accepted this revision. rahn added a comment. This revision is now accepted and ready to land. Looks good REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D23524 To: zaitseff, rahn Cc: marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, shentey, chaz

D23525: Add valid GeoJSON examples from RFC7946

rahn accepted this revision. rahn added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D23525 To: zaitseff, rahn Cc: marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, shentey, cha

D23524: Add the Marble writing example in GeoJSON format

This revision was automatically updated to reflect the committed changes. Closed by commit R34:f4c223bc682a: - Adding GeoJSON Marble writing example - Add valid GeoJSON examples from… (authored by rahn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23524?vs=64817&id=65242#toc REPOSITOR

D23527: Completely rewrite the GeoJSON runner plugin for RFC7946 compliance

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R34:d08729a77e55: Completely rewrite the GeoJSON runner plugin for RFC7946 compliance. (authored by zaitseff, committed by r

D23528: Implement most of the GeoJSON Simplestyle specification

rahn added a comment. Neato. :-) There is by the way "mDebug". But I'm not sure whether we use it consistently. REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D23528 To: zaitseff, rahn Cc: marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, shentey, ch

D23528: Implement most of the GeoJSON Simplestyle specification

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R34:5cb91148bce7: Implement most of the GeoJSON Simplestyle specification. (authored by zaitseff, committed by rahn). REPOS

D23529: Update the MIME type for GeoJSON files to be RFC7946-compliant

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R34:058ea2c44452: Update the MIME type for GeoJSON files to be RFC7946-compliant. (authored by zaitseff, committed by rahn).

D23530: Minor code cleanup of GeoJSON plugin, adding the new author and date

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R34:49e35634cee0: Minor code cleanup of GeoJSON plugin, adding the new author and date (authored by zaitseff, committed by r

D23532: Add the svgs/solid/dot-circle.svg icon from FontAwesome

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R34:efe8875e111a: Add the svgs/solid/dot-circle.svg icon from FontAwesome (authored by zaitseff, committed by rahn). REPOSI

D23533: Initialise default styles just once; display an icon for points

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R34:1eae0a397a3c: Initialise default styles just once; display an icon for points. Previously… (authored by zaitseff, commit

D23531: Add a test for the GeoJSON file parser

rahn accepted this revision. This revision is now accepted and ready to land. REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D23531 To: zaitseff, rahn Cc: marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache,

D23531: Add a test for the GeoJSON file parser

rahn added a comment. Submitted with 6b8cc37af9a567c1f8c87a2e0f00fc17981b3f2c . Thanks a lot! REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D23531 To: zaitseff, rahn Cc: marble-devel, kde-edu

D23531: Add a test for the GeoJSON file parser

rahn closed this revision. REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D23531 To: zaitseff, rahn Cc: marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

AW: Rewritten parser for GeoJSON files to handle styling

Hi John, thanks a lot for your hard work on this really nice piece of code. The coding style and the patchset in general looks excellent. I've just submitted it to Marble master. Please verify that everything is submitted as it should be :-) Any plans for the next patchset? ;-) Best Wishes T

Re: Rewritten parser for GeoJSON files to handle styling

Hi, Torsten, > thanks a lot for your hard work on this really nice piece of code. > The coding style and the patchset in general looks excellent. Thanks! I did try to follow the Marble/KDE/Qt style guide... :-) > I've just submitted it to Marble master. Please verify that > everything is submi