D18124: Implement touch input handling in MarbleWidgetInputHandler

2019-02-26 Thread Martin Koller
mkoller added a comment. ping REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D18124 To: mkoller, #marble, rahn Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D19329: allow GeoDataCoordinates::toString() to create an ISO 6709 conforming string

2019-02-26 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: Marble: General, rahn, nienhueser. Herald added projects: Marble, KDE Edu. Herald added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY ISO 6709 "Standard representation of geographic point lo

D19330: fix failing DMS-String parsing on windows

2019-02-26 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: Marble: General, rahn, nienhueser, kossebau. Herald added projects: Marble, KDE Edu. Herald added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY This patch marks unicode strings so that the c

D19329: allow GeoDataCoordinates::toString() to create an ISO 6709 conforming string

2019-02-26 Thread Torsten Rahn
rahn added a comment. apart from the Boolean issue this looks good to me and can be submitted. INLINE COMMENTS > GeoDataCoordinates.h:392 > */ > -QString toString( GeoDataCoordinates::Notation notation, int precision = > -1 ) const; > +QString toString( GeoDataCoordinates::Notat

D18124: Implement touch input handling in MarbleWidgetInputHandler

2019-02-26 Thread Torsten Rahn
rahn added a comment. nice patch! So which applications did you use for testing? :-) Did this cause any regressions when using it in 1. Marble (Virtual Globe) 2. Marble Maps REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D18124 To: mkoller, #marble, ra

D15879: Eliminate Qt message "QFileSystemEngine::fillMetaData: Empty filename passed to function"

2019-02-26 Thread Torsten Rahn
rahn accepted this revision. This revision is now accepted and ready to land. REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D15879 To: marten, #marble, rahn Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, a

D18143: Try to fix build with MARBLE_NO_WEBKITWIDGETS

2019-02-26 Thread Torsten Rahn
rahn accepted this revision. This revision is now accepted and ready to land. REPOSITORY R34 Marble BRANCH MARBLE_NO_WEBKITWIDGETS REVISION DETAIL https://phabricator.kde.org/D18143 To: asturmlechner, #marble, rahn Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6,

D18141: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled

2019-02-26 Thread Torsten Rahn
rahn accepted this revision. rahn added a comment. This revision is now accepted and ready to land. looks good REPOSITORY R34 Marble BRANCH Applications/18.12 REVISION DETAIL https://phabricator.kde.org/D18141 To: asturmlechner, #marble, rahn Cc: rahn, marble-devel, kde-edu, torhamzed

D11853: Fix Bug 371010: Position Marker is gone/invisible

2019-02-26 Thread Torsten Rahn
rahn accepted this revision. rahn added a comment. This revision is now accepted and ready to land. Herald edited subscribers, added: kde-edu, marble-devel; removed: KDE Edu. sorry for noticing this late REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D11853 To: cstagne

D11969: [WIP] Earth Globe Plasma wallpaper plugin

2019-02-26 Thread Torsten Rahn
rahn added a comment. Looks nice to me. REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D11969 To: kossebau Cc: rahn, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, nienhueser

D19329: allow GeoDataCoordinates::toString() to create an ISO 6709 conforming string

2019-02-26 Thread Martin Koller
mkoller updated this revision to Diff 52603. mkoller added a comment. Changed bool to enum REPOSITORY R34 Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19329?vs=52590&id=52603 REVISION DETAIL https://phabricator.kde.org/D19329 AFFECTED FILES lib/marble/geodata/data/G

D18124: Implement touch input handling in MarbleWidgetInputHandler

2019-02-26 Thread Martin Koller
mkoller added a comment. > So which applications did you use for testing? :-) Our WinCC_OA User Interface: https://www.winccoa.com/ On Android you could install it from google play store, however the version including the marble widget is not released yet (and you would also need our

D19341: avoid lots of "Unknown feature GeoDataRelationType" warnings when loading an OSM file

2019-02-26 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: rahn, Marble: General, nienhueser. Herald added projects: Marble, KDE Edu. Herald added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY Loading an osm file containing "relation" tags leads to

D11969: [WIP] Earth Globe Plasma wallpaper plugin

2019-02-26 Thread Friedrich W. H. Kossebau
kossebau added a comment. Happy to have someone else take over :) No time reserved for Marble in the foreseeable future currently myself. :( Some maybe interesting general context for Marble-based wallpapers for Plasma 5 can be found here: https://frinring.wordpress.com/2016/08/04/wip