schwarzer closed this revision.
schwarzer added a comment.
Thanks for checking. Closing it here.
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D29880
To: jhasse, rahn
Cc: jjazeix, schwarzer, rahn, marble-devel, kde-edu, fbampaloukas, torhamzed,
jalvarez, mnafees, she
jjazeix added a comment.
this is already on gitlab:
https://invent.kde.org/education/marble/-/merge_requests/48/diffs
As it was accepted here, I'm accepting it on gitlab too
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D29880
To: jhasse, rahn
Cc: jjazeix, schwa
schwarzer added a comment.
Unfortunately this did not land.
Could someone please put this on Gitlab for another review and then close it
here?
Thanks.
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D29880
To: jhasse, rahn
Cc: schwarzer, rahn, marble-devel, kde-
rahn accepted this revision.
rahn added a comment.
This revision is now accepted and ready to land.
Looks great!
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D29880
To: jhasse, rahn
Cc: rahn, marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees,
shentey
jhasse created this revision.
Herald added projects: Marble, KDE Edu.
Herald added subscribers: kde-edu, marble-devel.
jhasse requested review of this revision.
REVISION SUMMARY
I've noticed that when using MarbleWidget in my app, closing the top level
widget will no longer quit the QApplicatio
