This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R34:d0c59d84a433: ensure "make install" on windows
also installs development header files (authored by mkoller).
CHANGED PR
On Freitag, 31. August 2018 13:05:45 CEST Torsten Rahn wrote:
> rahn added a comment.
>
>
> Have you tested creating a new deployable Windows package?
no
> Or did you just test whether compilation on the platform works? :-)
We are using Marble in our product, and therefore we just package
mkoller added a comment.
> Have you tested creating a new deployable Windows package?
no
> Or did you just test whether compilation on the platform works? :-)
We are using Marble in our product, and therefore we just package what was
installed into a tar file,
which will then
rahn added a comment.
Have you tested creating a new deployable Windows package? Or did you just
test whether compilation on the platform works? :-)
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D15182
To: mkoller, #marble
Cc: rahn, marble-devel, kde-edu, torhamzed,
rahn added a comment.
Looks good to me!
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D15182
To: mkoller, #marble
Cc: rahn, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6,
dkolozsvari, narvaez, cmihalache, apol, nienhueser
mkoller created this revision.
mkoller added a reviewer: Marble.
Herald added projects: Marble, KDE Edu.
Herald added subscribers: kde-edu, marble-devel.
mkoller requested review of this revision.
REVISION SUMMARY
The attached change ensures we also get the header files installed.
At least thi
