Re: Merging pull requests before 72 hours

2018-10-15 Thread Chris Jones
Hi, On 15/10/18 06:41, Joshua Root wrote: I agree with the points in Mojca's first message in the thread. On 2018-10-15 09:20 , Mojca Miklavec wrote: On Mon, 15 Oct 2018 at 00:10, Blair Zajac wrote: We could add a rule that should help a bit that openmaintainer only lets people do minor ver

Re: Merging pull requests before 72 hours

2018-10-15 Thread Zero King
On Mon, Oct 15, 2018 at 09:58:59AM +0100, Chris Jones wrote: Hi, On 15/10/18 06:41, Joshua Root wrote: I agree with the points in Mojca's first message in the thread. On 2018-10-15 09:20 , Mojca Miklavec wrote: On Mon, 15 Oct 2018 at 00:10, Blair Zajac wrote: We could add a rule that should

Re: Merging pull requests before 72 hours

2018-10-15 Thread Chris Jones
and so on... Do we have a guide for something like this written done anywhere ? "7.4.1. Non-Maintainer Port Updates" in our guide. https://guide.macports.org/#project.update-policies.nonmaintainer That is not what I am asking for. Specifically it does not give any guidance on exactly what

Re: Merging pull requests before 72 hours

2018-10-15 Thread Perry E. Metzger
On Mon, 15 Oct 2018 00:20:53 +0200 Mojca Miklavec wrote: > On Mon, 15 Oct 2018 at 00:10, Blair Zajac wrote: > > > > We could add a rule that should help a bit that openmaintainer > > only lets people do minor version bumps, e.g. X.Y to X.(Y+1) and > > X.Y.Z to X.Y.(Z+1). This doesn’t solve the Lua

Re: Merging pull requests before 72 hours

2018-10-15 Thread Chris Jones
Hi, 1. if the person doing the update is skilled (and at this point I generally know the difference), 2. if they indicate that they've tested the result, 3. if it seems based on history that the listed maintainer is unlikely to comment then or ever (and I usually guess right), 4. and that if wha

Re: Merging pull requests before 72 hours

2018-10-15 Thread Michael Dickens
I'll second Chris' note of thanks for MP folks keeping the PR queue short. Since MP folks (especially Perry) have started stepping up to this task, I too have been trying harder to do my part. Now my US$0.02 worth and all IMHO about PR commit timeouts & why. - MLD -Any- non-urgent fix should go

Re: Merging pull requests before 72 hours

2018-10-15 Thread Leonardo Brondani Schenkel
My two cents: I'm a committer, and if I'm doing a trivial bump of an openmaintainer port I'll push it directly. If I'm opening a GitHub PR for an openmaintainer port this means that for some reason I want the maintainer's opinion/review before it gets merged. As a maintainer, I would be anno

Re: Merging pull requests before 72 hours

2018-10-15 Thread Chris Jones
Hi, > On 15 Oct 2018, at 10:34 pm, Leonardo Brondani Schenkel > wrote: > > My two cents: > > I'm a committer, and if I'm doing a trivial bump of an openmaintainer port > I'll push it directly. Depends entirely on what you consider trivial. If you consider a version update a trivial bump the

Re: Merging pull requests before 72 hours

2018-10-15 Thread Chris Jones
> On 15 Oct 2018, at 11:18 pm, Chris Jones wrote: > > Hi, > >> On 15 Oct 2018, at 10:34 pm, Leonardo Brondani Schenkel >> wrote: >> >> My two cents: >> >> I'm a committer, and if I'm doing a trivial bump of an openmaintainer port >> I'll push it directly. > > Depends entirely on what yo

Re: Merging pull requests before 72 hours

2018-10-15 Thread Zero King
On Mon, Oct 15, 2018 at 02:16:48PM +0100, Chris Jones wrote: Hi, [...] If these sorts of things aren't okay to merge pretty quickly, then why do we have an openmaintainer designation at all? I mean, if there's really no distinction in how you treat an openmaintainer and a non-openmaintainer po

Re: Merging pull requests before 72 hours

2018-10-15 Thread Leonardo Brondani Schenkel
On 15 Oct 2018, at 11:18 pm, Chris Jones wrote: On 15 Oct 2018, at 10:34 pm, Leonardo Brondani Schenkel wrote: I'm a committer, and if I'm doing a trivial bump of an openmaintainer port I'll push it directly. Depends entirely on what you consider trivial. If you consider a version update a