Re: Instructions for creating patches (Re: trac rrdtool)

2018-05-03 Thread Zero King
On Thu, May 03, 2018 at 08:51:49AM +0200, Mojca Miklavec wrote: On 1 May 2018 at 16:11, Rainer Müller wrote: The guide uses "Portfile-rrdtool.diff" as an example filename [1]. Some users seem to take that literally and submit patches with that name. [1] https://guide.macports.org/#development.

Help with Pull Request

2018-05-03 Thread Marcus Calhoun-Lopez
Recently, I opened a pull request (https://github.com/macports/macports-ports/pull/1714/). It originally had three changes: https://github.com/macports/macports-ports/pull/1714/commits/59ff57cc3a8dacfb96f46fc3e902f2bfeae9ce02 https://github.com/macports/macports-ports/pull/1714/c

Re: Help with Pull Request

2018-05-03 Thread Rainer Müller
On 2018-05-03 12:14, Marcus Calhoun-Lopez wrote: > The only git commands I have been running (not in this order) are > git pull --rebase upstream master > git pull --rebase origin cargo-pg > git pull --rebase origin master > git push origin cargo-pg > where > cargo-pg is the nam

Re: Help with Pull Request

2018-05-03 Thread Marcus Calhoun-Lopez
This seems to have fixed both problems. Thank you very much, Marcus > On May 3, 2018, at 4:17 AM, Rainer Müller wrote: > > On 2018-05-03 12:14, Marcus Calhoun-Lopez wrote: >> The only git commands I have been running (not in this order) are >>git pull --rebase upstream master >>git pull

Re: Binary packages not rebuilding against updated libraries

2018-05-03 Thread Artur Szostak
>>> Not quite. I'm noting that the package version isn't a reliable >>> indication of the ABI version, and neither (sadly, see the current >>> protobuf issues and the issues with LibreSSL) is the library dylib >>> name. Thus I'm proposing to have an internal ABI revision number that >>> we can use

Re: Binary packages not rebuilding against updated libraries

2018-05-03 Thread Perry E. Metzger
On Thu, 3 May 2018 11:54:23 + Artur Szostak wrote: > Now what would be a really powerful tool, would be something that > can check that the following mistake was made: the major number is > not changed correctly for shared libraries that are in fact not > compatible with each other. This is ex