Template for pull requests

2017-01-27 Thread Zero King
I wrote a template for PRs at https://github.com/macports/macports-ports/pull/187. Any advice or objection? -- Zero King

Re: Template for pull requests

2017-01-16 Thread Mojca Miklavec
On 15 January 2017 at 23:57, Ryan Schmidt wrote: >> On Jan 15, 2017, at 02:44, Mojca Miklavec wrote: >> >> What do others think of adding some templates to our repos? > > I often find them annoying in other projects because they ask the wrong > questions. Can we find the right questions to ask? *

Re: Template for pull requests

2017-01-15 Thread Ryan Schmidt
> On Jan 15, 2017, at 02:44, Mojca Miklavec wrote: > > Hi, > > I've recently seen some "templates" in our pull requests, for example on >https://github.com/macports/macports-ports/pull/158 > > Were those added manually? We don't have a PULL_REQUEST_TEMPLATE.md in our repo, so yes. > What

Re: Template for pull requests

2017-01-15 Thread Mojca Miklavec
Hi, I've recently seen some "templates" in our pull requests, for example on https://github.com/macports/macports-ports/pull/158 Were those added manually? What do others think of adding some templates to our repos? Mojca On 22 December 2016 at 20:56, Mojca Miklavec wrote: > Hi, > > I have

Template for pull requests

2016-12-22 Thread Mojca Miklavec
Hi, I have an impression that we are now getting pull requests from upstream developers (or some close-to-upstream users/developers) who never contributed to MacPorts earlier and sometimes don't even have MacPorts installed and never test the changes. Some of them submit both to MacPorts and HomeB