Re: Commits that implicitly close PRs do not remember doing so

2016-12-12 Thread Ryan Schmidt
On Dec 12, 2016, at 05:43, Mojca Miklavec wrote: > > This actually reminded me of another potential "problem". In the past > we always used the >(closes #1234567) > syntax which we changed during migration to GIT to absolute links. Do > we want to use absolute links for >Closes: https:

Re: Feature Request: Buildbot triggering dependent port rebuilds in a cascade

2016-12-12 Thread Ryan Schmidt
On Dec 12, 2016, at 23:02, Marko Käning wrote: > > Hi MacPorts core devs, > > I was wondering whether it is possible to configure the buildbots in such a > way > that they can observe if a just rebuilt port is a dependency of other ports > which > haven’t been built successfully yet. If such a

Feature Request: Buildbot triggering dependent port rebuilds in a cascade

2016-12-12 Thread Marko Käning
Hi MacPorts core devs, I was wondering whether it is possible to configure the buildbots in such a way that they can observe if a just rebuilt port is a dependency of other ports which haven’t been built successfully yet. If such a case is met it could trigger a rebuild-cascade which makes sure t

Re: [macports-ports] branch master updated: phonon-backend-gstreamer(-qt5): update to 4.9.0 and introduce new subport

2016-12-12 Thread Marko Käning
On 13 Dec 2016, at 05:48 , Lawrence Velázquez wrote: > Yeah, they'll linger until the PR branch is deleted and GitHub runs garbage > collection on the repository. Yes, I was fearing that well… That will be seen once I delete those PR branches in my repos. Unfortunately I can’t amend my last

Re: [macports-ports] branch master updated: phonon-backend-gstreamer(-qt5): update to 4.9.0 and introduce new subport

2016-12-12 Thread Lawrence Velázquez
> On Dec 12, 2016, at 11:46 PM, Marko Käning wrote: > > Yet, the git metadata is - also to my surprise - still valid, which can be > verified by clicking all the links on the commit’s page: > > > https://github.com/macports/macports-ports/commit/47c0c4f682b22803ae250258187544187d50f898

Re: [macports-ports] branch master updated: phonon-backend-gstreamer(-qt5): update to 4.9.0 and introduce new subport

2016-12-12 Thread Marko Käning
Hi Larry, On 13 Dec 2016, at 05:20 , Lawrence Velázquez wrote: > Please clean up the commit message when you perform squash merges. Most of > the text here is outdated Git metadata (old SHA-1 hashes, repeated author > name, irrelevant authorship dates). yes, you’re right, I should have stripp

Re: [macports-ports] branch master updated: phonon-backend-gstreamer(-qt5): update to 4.9.0 and introduce new subport

2016-12-12 Thread Lawrence Velázquez
Please clean up the commit message when you perform squash merges. Most of the text here is outdated Git metadata (old SHA-1 hashes, repeated author name, irrelevant authorship dates). vq > On Dec 12, 2016, at 10:54 PM, Marko Käning wrote: > > Marko Käning (mkae) pushed a commit to branch mas

Re: Build Failure: (from, 10.6, OS, This, X, builds, configure.compiler=macports-gcc-4.7, newer, on, only, and 6 more

2016-12-12 Thread Marko Käning
Dear René, On 12 Dec 2016, at 01:04 , René J.V. Bertin wrote: > On Monday December 12 2016 00:39:37 Marko Käning wrote: > >> So, now only 10.6-10.8 fail completely (which had to be expected, I am >> afraid) > > Yes, for QtCurve-qt5 . > I keep forgetting that 10.8 also doesn't have libc++ stan

Re: Commits that implicitly close PRs do not remember doing so

2016-12-12 Thread Mojca Miklavec
On 12 December 2016 at 10:35, Joshua Root wrote: > On 2016-12-12 20:21 , Rainer Müller wrote: >> On 2016-12-12 02:29, Lawrence Velázquez wrote: On Dec 6, 2016, at 10:33 AM, Rainer Müller wrote: (e) add "Closes: #XYZ" to the commit message >>> >>> When commits close PRs implicitly (by

Re: Commits that implicitly close PRs do not remember doing so

2016-12-12 Thread Joshua Root
On 2016-12-12 20:21 , Rainer Müller wrote: On 2016-12-12 02:29, Lawrence Velázquez wrote: On Dec 6, 2016, at 10:33 AM, Rainer Müller wrote: (e) add "Closes: #XYZ" to the commit message When commits close PRs implicitly (by merging the PR branch) instead of explicitly (by using "closes #XYZ"

Re: Commits that implicitly close PRs do not remember doing so

2016-12-12 Thread Rainer Müller
On 2016-12-12 02:29, Lawrence Velázquez wrote: >> On Dec 6, 2016, at 10:33 AM, Rainer Müller wrote: >> >> (e) add "Closes: #XYZ" to the commit message > > When commits close PRs implicitly (by merging the PR branch) instead of > explicitly (by using "closes #XYZ" in the message), the PR is remem