Re: master compile errors gzlib?

2022-12-08 Thread Scott Kostyshak
On Mon, Dec 05, 2022 at 10:15:18PM +0100, Yu Jin wrote: > Am Mo., 5. Dez. 2022 um 10:39 Uhr schrieb Pavel Sanda : > > > > > Given that on major linux distributions will still link against qt5 > > I think stikcing for 2.4 with Qt 5 is just fine... > > > I think my curiosity helped here :) > > So

Re: master compile errors gzlib?

2022-12-08 Thread Kornel Benko
Am Thu, 8 Dec 2022 09:52:29 -0500 schrieb Scott Kostyshak : > On Mon, Dec 05, 2022 at 10:15:18PM +0100, Yu Jin wrote: > > Am Mo., 5. Dez. 2022 um 10:39 Uhr schrieb Pavel Sanda : > > > > > > > > Given that on major linux distributions will still link against qt5 > > > I think stikcing for 2.4 wi

Re: [LyX/master] Add conversion routine for format 612.

2022-12-08 Thread Richard Kimberly Heck
On 12/7/22 11:32, Jean-Marc Lasgouttes wrote: Le 07/12/2022 à 17:19, Richard Kimberly Heck a écrit : I see a lot of   lyx2lyx warning: noprefix "false" in the console when loading files. Is this a forgotten debug message ? I was assuming that should be there, but perhaps it's not a problem if

Re: [LyX/master] Simplify conversion routine, and remove warning

2022-12-08 Thread Scott Kostyshak
On Thu, Dec 08, 2022 at 04:14:00PM +0100, Richard Kimberly Heck wrote: > commit fa449e976906edb9510639f2ca7bf491a2e07b46 > Author: Richard Kimberly Heck > Date: Thu Dec 8 11:09:48 2022 -0500 > > Simplify conversion routine, and remove warning > --- > lib/lyx2lyx/lyx_2_4.py |7 ++- >

Re: [LyX/master] Add OS version info to About box.

2022-12-08 Thread Stephan Witt
Am 07.12.2022 um 14:36 schrieb Pavel Sanda : > > On Tue, Dec 06, 2022 at 11:12:37PM +0100, Stephan Witt wrote: >> commit a66ee4109ee84a4a501dbaa29580cdefe1aadd36 >> Author: Stephan Witt >> Date: Wed Dec 7 00:08:11 2022 +0100 >> >>Add OS version info to About box. >> --- >> src/frontends/qt

lyx2lyx: many unused variables (any bugs?)

2022-12-08 Thread Scott Kostyshak
pylint claims that our lyx_2_4.py has several unused variables. I'm not familiar with pylint so I don't know if it commonly gives false positives. Does anyone want to take a look to see if any of the unused variables suggest a bug? Perhaps it doesn't make sense to clean up lyx_2_4.py (except for

Re: lyx2lyx: many unused variables (any bugs?)

2022-12-08 Thread Richard Kimberly Heck
On 12/8/22 13:45, Scott Kostyshak wrote: pylint claims that our lyx_2_4.py has several unused variables. I'm not familiar with pylint so I don't know if it commonly gives false positives. Does anyone want to take a look to see if any of the unused variables suggest a bug? It so easy to do this

Re: lyx2lyx: many unused variables (any bugs?)

2022-12-08 Thread Thibaut Cuvelier
On Thu, 8 Dec 2022 at 21:19, Richard Kimberly Heck wrote: > On 12/8/22 13:45, Scott Kostyshak wrote: > > Perhaps it doesn't make sense to clean up lyx_2_4.py (except for looking > > for bugs), but what would you think about adding an agreed-upon set of > > pylint warnings to our test suite for ly

Re: lyx2lyx: many unused variables (any bugs?)

2022-12-08 Thread José Matos
On Thu, 2022-12-08 at 21:37 +0100, Thibaut Cuvelier wrote: > The Python standard for variables that are introduced just because > the syntax requires it (like iterating X times) is to name that > variable _ (or to prefix it with an underscore if there are more than > one). Yes, that would also be

Re: lyx2lyx: many unused variables (any bugs?)

2022-12-08 Thread Thibaut Cuvelier
On Thu, 8 Dec 2022 at 22:06, José Matos wrote: > On the same vein for 2.5 I intend to start, in an iterative process, to > add type hinting to our python code: http://mypy-lang.org/ > > One example: > > def fib(n): > if n==0 or n==1: > return 1 > else: > return fin(n-1)+fib(n-2) > > b

Re: lyx2lyx: many unused variables (any bugs?)

2022-12-08 Thread José Matos
On Thu, 2022-12-08 at 22:27 +0100, Thibaut Cuvelier wrote: > The only problem I see with type hints is that it restricts the > versions of Python that can run the code. I believe that anything > below 3.5 won't be able to even parse the Python code (which excludes > 2.7). I understood that Python 2

docbook ctest failing on master

2022-12-08 Thread Scott Kostyshak
The following ctest is failing for me after the recent commits: export/export/docbook/LilyPond_Book_docbook5 The first error in the output has to do with '&' apparently: Processing `./60/lily-95ee389a.ly' Parsing... ././60/lily-95ee389a.ly:7:12: error: undefined character or shorthand: &