[patch] Selection stats in statusbar

2022-07-12 Thread Pavel Sanda
Hi, I need to adhere precise word/character counts in sections of a document. For this I need to have instantaneous visual feedback of stats when selecting blocks of text. The attached patch does this. Is there some objection to push this into master? (If no objection raised I'll add string trans

Re: Remove duplicate history entries in command buffer

2022-07-12 Thread Pavel Sanda
On Mon, Jul 11, 2022 at 02:25:49PM +0200, Kornel Benko wrote: > Am Mon, 11 Jul 2022 13:37:31 +0200 > schrieb Pavel Sanda : > > > On Mon, Jul 11, 2022 at 10:53:23AM +0200, Kornel Benko wrote: > > > So the outcome may be a new preference? > > > > Please no. > > > > Pavel > > What is your prefer

Re: [patch] Selection stats in statusbar

2022-07-12 Thread Jean-Marc Lasgouttes
Le 12/07/2022 à 21:12, Pavel Sanda a écrit : Hi, I need to adhere precise word/character counts in sections of a document. For this I need to have instantaneous visual feedback of stats when selecting blocks of text. The attached patch does this. Is there some objection to push this into master

Re: Remove duplicate history entries in command buffer

2022-07-12 Thread Jean-Marc Lasgouttes
Le 12/07/2022 à 22:15, Pavel Sanda a écrit : On Mon, Jul 11, 2022 at 02:25:49PM +0200, Kornel Benko wrote: Am Mon, 11 Jul 2022 13:37:31 +0200 schrieb Pavel Sanda : On Mon, Jul 11, 2022 at 10:53:23AM +0200, Kornel Benko wrote: So the outcome may be a new preference? Please no. Pavel What

Re: [patch] Selection stats in statusbar

2022-07-12 Thread Scott Kostyshak
On Tue, Jul 12, 2022 at 09:12:56PM +0200, Pavel Sanda wrote: > Hi, > > I need to adhere precise word/character counts in sections of a document. > For this I need to have instantaneous visual feedback of stats when selecting > blocks of text. > > The attached patch does this. Is there some object

Re: [patch] Selection stats in statusbar

2022-07-12 Thread Jean-Marc Lasgouttes
Le 12/07/2022 à 22:31, Scott Kostyshak a écrit : Part of it is that I just like to bother JMarc, I am glad to humor you. As for how to solve the performance issue, is there any smart caching that can be done? The first thing to do would be to scrap the current method and create a new ver

Re: Remove duplicate history entries in command buffer

2022-07-12 Thread Jean-Marc Lasgouttes
Le 12/07/2022 à 22:19, Jean-Marc Lasgouttes a écrit : I won't complain more about removing from the whole history, but the original patch will need to be updated. I suspect that the two command lists should be unified. I just discovered that the sexy and fast way of removing a string from a v

Re: [patch] Selection stats in statusbar

2022-07-12 Thread Pavel Sanda
On Tue, Jul 12, 2022 at 04:31:20PM -0400, Scott Kostyshak wrote: > However, it seems to have a pretty big hit on performance. The way I > checked was starting with select-all on a document, and then doing shift > + up and seeing how long it took to get to the top. It took 16 seconds > without the p

Re: [LyX/master] Check for icon aliases

2022-07-12 Thread Pavel Sanda
On Tue, Jul 12, 2022 at 10:52:18PM +0200, Jean-Marc Lasgouttes wrote: > +QString getAlias(QString name) { Could we get the comment in the code, what is this function supposed to do? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [patch] Selection stats in statusbar

2022-07-12 Thread Daniel
On 2022-07-13 00:50, Pavel Sanda wrote: On Tue, Jul 12, 2022 at 04:31:20PM -0400, Scott Kostyshak wrote: However, it seems to have a pretty big hit on performance. The way I checked was starting with select-all on a document, and then doing shift + up and seeing how long it took to get to the to