InsetParams refactoring

I'm trying to refactor implementation of Inset[...]Params (InsetBoxParams, InsetPhantomParams etc). The steps are: 1. Unify Inset[...]Params interfaces and extract InsetParams superclass. 2. Move `params2string` and `string2params` static methods of Insets to methods of Inset[...]Params. 3. Ma

Re: Patches to review

I see they are in now, but I have a proposal (of style). I code like below, - for (; qq != end; ++qq) { - docstring const style = from_ascii(qq->first); - bool langdef = (style[0] == langqs); - bool globaldef = (style[0] == globalqsc); + map st

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools #2069

https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/2069/-- Started by an SCM change Building remotely on lyx-linux1 (linux) in workspace [WS-CLEANU

[PATCH] Implement proper Dialog factory instead of implicit link-time dependencies

Please review this patch. The change is pretty straightforward. And according to the comment "// will be replaced by a proper factory..." that appeared in 2007 (169d3fa39e) it should be done long ago :) Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinf

Re: Counter feature: should counter name be the LaTeX name?

On 12/4/20 4:14 PM, Scott Kostyshak wrote: > See the attached .lyx file. It gives an error, whose cause is easily seen > from the LaTeX: > > \begin{thm} > Hello > \end{thm} > abc > > \setcounter{theorem}{0} > \begin{thm} > Again > \end{thm} > > LatexName of the style Theorem is

Re: InsetParams refactoring

On 12/5/20 11:23 AM, Yuriy Skalko wrote: > I'm trying to refactor implementation of Inset[...]Params > (InsetBoxParams, InsetPhantomParams etc). The steps are: > > 1. Unify Inset[...]Params interfaces and extract InsetParams >  superclass. > 2. Move `params2string` and `string2params` static method

Re: Patches to review

On 12/5/20 11:31 AM, Yuriy Skalko wrote: >> I see they are in now, but I have a proposal (of style). I code like >> below, >> -   for (; qq != end; ++qq) { >> -   docstring const style = from_ascii(qq->first); >> -   bool langdef = (style[0] == langqs); >> - 

Re: [PATCH] Implement proper Dialog factory instead of implicit link-time dependencies

On 12/5/20 11:52 AM, Yuriy Skalko wrote: > Please review this patch. The change is pretty straightforward. And > according to the comment "// will be replaced by a proper factory..." > that appeared in 2007 (169d3fa39e) it should be done long ago :) I'll also have a look at this one later today.

Build failed in Jenkins: Build branch "master" » ubuntu-latest-qt5-cmake #2364

https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-latest-qt5-cmake/2364/-- Started by an SCM change Building remotely on lyx-linux1 (linux) in workspace [WS-CLEANUP] Delet

Re: Patches to review

Le 05/12/2020 à 18:05, Richard Kimberly Heck a écrit : I just wanted to leave types of the pair as visible. Probably this is not really important and the code should be shortened to your variant. I tend to agree with Yuriy here. The code is a bit longer, but you do get an explicit indication of

Re: Counter feature: should counter name be the LaTeX name?

Le 05/12/2020 à 18:02, Richard Kimberly Heck a écrit : On 12/4/20 4:14 PM, Scott Kostyshak wrote: LatexName of the style Theorem is set to "thm". Is that what should be used as the counter name? Do we currently use the layout name? We use the counter name, which in LyX is "theorem". Believe i

Re: Counter feature: should counter name be the LaTeX name?

On Sat, Dec 05, 2020 at 12:02:30PM -0500, Richard Kimberly Heck wrote: > On 12/4/20 4:14 PM, Scott Kostyshak wrote: > > See the attached .lyx file. It gives an error, whose cause is easily seen > > from the LaTeX: > > > > \begin{thm} > > Hello > > \end{thm} > > abc > > > > \setcounter

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #2269

https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/2269/-- Started by an SCM change Building remotely on lyx-linux1 (linux) in workspace

An official GitHub mirror for LyX?

Dear list, I often find myself wandering through the source code of LyX. I can do that with my IDE, but it often breaks my flow of thoughts (e.g., I'm just checking how one specific component works, while I'm already working on a few files that use that module). That's why I usually try to use eit

Re: An official GitHub mirror for LyX?

On 12/5/20 1:48 PM, Thibaut Cuvelier wrote: > Dear list, > > I often find myself wandering through the source code of LyX. I can do > that with my IDE, but it often breaks my flow of thoughts (e.g., I'm > just checking how one specific component works, while I'm already > working on a few files tha

Re: An official GitHub mirror for LyX?

On Sat, Dec 05, 2020 at 07:48:23PM +0100, Thibaut Cuvelier wrote: > What do you think of it? I already made a quick search in the mailing list, > but I did not the topic being discussed. Looks fine to me as well, though if you don't have strong preference, gitlab might be ideologically better opti

Re: An official GitHub mirror for LyX?

On Sat, Dec 05, 2020 at 08:43:03PM +0100, Pavel Sanda wrote: > On Sat, Dec 05, 2020 at 07:48:23PM +0100, Thibaut Cuvelier wrote: > > What do you think of it? I already made a quick search in the mailing list, > > but I did not the topic being discussed. > > Looks fine to me as well, though if you

An official GitHub mirror for LyX?

This is significantly better than browsing code on GitHub directly: https://sourcegraph.com/github.com/cburschka/lyx Also here is fast site with Doxygen documentation (only for stable branch): https://fossies.org/dox/lyx-2.3.6/ Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://list

Re: An official GitHub mirror for LyX?

On 12/5/20 3:11 PM, Yuriy Skalko wrote: > This is significantly better than browsing code on GitHub directly: > https://sourcegraph.com/github.com/cburschka/lyx Who runs that site? Does it only do this for github or other sites, too? Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http:

Re: An official GitHub mirror for LyX?

On 12/5/20 2:43 PM, Pavel Sanda wrote: > On Sat, Dec 05, 2020 at 07:48:23PM +0100, Thibaut Cuvelier wrote: >> What do you think of it? I already made a quick search in the mailing list, >> but I did not the topic being discussed. > Looks fine to me as well, though if you don't have strong preferenc

Changes and Pasting

Found while editing Customization.lyx: If I paste some material from a section of a document that is not marked as changed, it is pasted as unchanged, as well. Presumably, it should be marked as changed? Is this part of the whole puzzling mess about what to do with pasted material? Riki -- lyx-

Re: An official GitHub mirror for LyX?

Who runs that site? Does it only do this for github or other sites, too? Riki Some Silicon Valley startup :) Gitlab is supported too, so it will be usable for the forthcoming official mirror there. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/

Re: An official GitHub mirror for LyX?

On Sat, 5 Dec 2020 at 20:43, Pavel Sanda wrote: > On Sat, Dec 05, 2020 at 07:48:23PM +0100, Thibaut Cuvelier wrote: > > What do you think of it? I already made a quick search in the mailing > list, > > but I did not the topic being discussed. > > Looks fine to me as well, though if you don't have

Re: [LyX/master] This should fix a few type-conversion warnings.

Am Sat, 5 Dec 2020 22:22:34 +0100 (CET) schrieb Thibaut Cuvelier : > commit 0c5e10f36b0b42eefa41806cac12790a2b49c043 > Author: Thibaut Cuvelier > Date: Sat Dec 5 22:51:56 2020 +0100 > > This should fix a few type-conversion warnings. > --- > src/output_docbook.cpp |5 +++-- > 1 files

Re: An official GitHub mirror for LyX?

On Sat, Dec 05, 2020 at 10:41:26PM +0100, Thibaut Cuvelier wrote: > To have a larger user base and better performance, GitHub is the better > option (more tools work out-of-the-box with it). GitLab has a clunkier > interface, in my opinion, but possibly more features than GitHub. Both are > good ch

Re: InsetParams refactoring

On 12/5/20 11:23 AM, Yuriy Skalko wrote: > I'm trying to refactor implementation of Inset[...]Params > (InsetBoxParams, InsetPhantomParams etc). The steps are: > > 1. Unify Inset[...]Params interfaces and extract InsetParams >  superclass. > 2. Move `params2string` and `string2params` static method

Re: Counter feature: should counter name be the LaTeX name?

On 12/5/20 1:22 PM, Jean-Marc Lasgouttes wrote: > Le 05/12/2020 à 18:02, Richard Kimberly Heck a écrit : >> On 12/4/20 4:14 PM, Scott Kostyshak wrote: >>> LatexName of the style Theorem is set to "thm". Is that what should >>> be used as the counter name? Do we currently use the layout name? >> >>

Re: Counter feature: should counter name be the LaTeX name?

On 12/5/20 1:25 PM, Scott Kostyshak wrote: > On Sat, Dec 05, 2020 at 12:02:30PM -0500, Richard Kimberly Heck wrote: >> On 12/4/20 4:14 PM, Scott Kostyshak wrote: >>> See the attached .lyx file. It gives an error, whose cause is easily seen >>> from the LaTeX: >>> >>> \begin{thm} >>> Hello >>>

Re: An official GitHub mirror for LyX?

On Sat, Dec 5, 2020 at 12:51 PM Scott Kostyshak wrote: > On Sat, Dec 05, 2020 at 08:43:03PM +0100, Pavel Sanda wrote: > > On Sat, Dec 05, 2020 at 07:48:23PM +0100, Thibaut Cuvelier wrote: > > > What do you think of it? I already made a quick search in the mailing > list, > > > but I did not the t

Re: [LyX/master] This should fix a few type-conversion warnings.

On Sat, Dec 05, 2020 at 11:08:38PM +0100, Kornel Benko wrote: > Am Sat, 5 Dec 2020 22:22:34 +0100 (CET) > schrieb Thibaut Cuvelier : > > > commit 0c5e10f36b0b42eefa41806cac12790a2b49c043 > > Author: Thibaut Cuvelier > > Date: Sat Dec 5 22:51:56 2020 +0100 > > > > This should fix a few typ

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools #2070

https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/2070/-- Started by an SCM change Building remotely on lyx-linux1 (linux) in workspace [WS-CLEANU

Re: Counter feature: should counter name be the LaTeX name?

On Sat, Dec 05, 2020 at 06:31:48PM -0500, Richard Kimberly Heck wrote: > On 12/5/20 1:25 PM, Scott Kostyshak wrote: > > On Sat, Dec 05, 2020 at 12:02:30PM -0500, Richard Kimberly Heck wrote: > >> On 12/4/20 4:14 PM, Scott Kostyshak wrote: > >>> See the attached .lyx file. It gives an error, whose c

Re: [LyX/master] This should fix a few type-conversion warnings.

Nice to read! I didn't expect the auto keyword to create this kind of problem... On Sun, 6 Dec 2020, 01:44 Scott Kostyshak, wrote: > On Sat, Dec 05, 2020 at 11:08:38PM +0100, Kornel Benko wrote: > > Am Sat, 5 Dec 2020 22:22:34 +0100 (CET) > > schrieb Thibaut Cuvelier : > > > > > commit 0c5e10f3

Mac Binary with Qt 5.12.9

Hi, all, Due to bug #12042 (https://www.lyx.org/trac/ticket/12042), Stephan Witt has produced an OSX package built with Qt 5.12.9. This is a more up-to-date version of Qt than we've been using. If the package works well, then we'll replace the binary for 2.3.6 with it. But first, we need to make s

Build failed in Jenkins: Build branch "master" » ubuntu-latest-qt5-cmake #2365

https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-latest-qt5-cmake/2365/-- Started by an SCM change Building remotely on lyx-linux1 (linux) in workspace [WS-CLEANUP] Delet

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #2270

https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/2270/-- Started by an SCM change Building remotely on lyx-linux1 (linux) in workspace

Re: Comments on "Edit externally" feature

On 12/2/20 12:11 PM, Scott Kostyshak wrote: > On Wed, Dec 02, 2020 at 11:56:26AM -0500, Richard Kimberly Heck wrote: >> On 12/2/20 11:13 AM, Scott Kostyshak wrote: >>> On Wed, Dec 02, 2020 at 10:56:16AM -0500, Richard Kimberly Heck wrote: On 12/2/20 10:46 AM, Scott Kostyshak wrote: > I jus

Re: Comments on "Edit externally" feature

On Sat, Dec 05, 2020 at 09:32:46PM -0500, Richard Kimberly Heck wrote: > On 12/2/20 12:11 PM, Scott Kostyshak wrote: > > On Wed, Dec 02, 2020 at 11:56:26AM -0500, Richard Kimberly Heck wrote: > >> On 12/2/20 11:13 AM, Scott Kostyshak wrote: > >>> On Wed, Dec 02, 2020 at 10:56:16AM -0500, Richard Ki

Reproducible Assertion in Master

Open a new file and attempt to activate a module with missing requires. I get an assertion in GuiIdListModel, due to our attempting to set an invalid role. I can try to bisect tomorrow. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Comments on "Edit externally" feature

On 12/5/20 11:27 PM, Scott Kostyshak wrote: > On Sat, Dec 05, 2020 at 09:32:46PM -0500, Richard Kimberly Heck wrote: >> On 12/2/20 12:11 PM, Scott Kostyshak wrote: >>> On Wed, Dec 02, 2020 at 11:56:26AM -0500, Richard Kimberly Heck wrote: On 12/2/20 11:13 AM, Scott Kostyshak wrote: > On We