Should I commit my recent patches into this branch?
Sure.
What is the way LyX project uses for updating feature branches:
rebasing on master, merging master or cherry-picking needed commits?
When it comes time to commit, I think people usually just rebase on
master, then merge. But we have
Isn't there a way with a xxx_cast too ? (maybe reinterpret_cast<> ?)
JMarc
Yes, here is another one with casting:
bool operator==(ParConstIterator const & iter1, ParConstIterator const &
iter2)
{
return static_cast(iter1) ==
static_cast(iter2);
}
Yuriy
--
lyx-devel mailing list
lyx-devel
Am Sun, 08 Nov 2020 17:14:42 +1300
schrieb "Sam Crawley" :
...
> diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> index 2d93d27c59..32ef0f974a 100644
> --- a/lib/scripts/lyx_batch.pl.in
> +++ b/lib/scripts/lyx_batch.pl.in
> @@ -8,11 +8,6 @@ use warnings;
> use File::Copy;
>
On Sun, Nov 08, 2020 at 05:14:42PM +1300, Sam Crawley wrote:
> Hi all,
Hi Sam,
welcome and thanks for working on this. Couple small things:
- Please send in a separate email to our list the following GPL statement:
I hereby grant permission to license my contributions to LyX under the GNU
Gener
Am Sun, 8 Nov 2020 10:28:51 +0100
schrieb Kornel Benko :
> Am Sun, 08 Nov 2020 17:14:42 +1300
> schrieb "Sam Crawley" :
> ...
> > diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> > index 2d93d27c59..32ef0f974a 100644
> > --- a/lib/scripts/lyx_batch.pl.in
> > +++ b/lib/scrip
Am Sun, 8 Nov 2020 13:01:14 +0100
schrieb Kornel Benko :
> Am Sun, 8 Nov 2020 10:28:51 +0100
> schrieb Kornel Benko :
>
> > Am Sun, 08 Nov 2020 17:14:42 +1300
> > schrieb "Sam Crawley" :
> > ...
> > > diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> > > index 2d93d27c59.
On Sun, Nov 08, 2020 at 11:32:59AM +0100, Pavel Sanda wrote:
>
> Scott/Kornel will presumably review/check the testing part.
I don't have much time to review or help, although I would be happy to take a
look in the future (possibly not for a while though). Thanks to Pavel and
Kornel for giving
On 11/8/20 12:12 PM, Scott Kostyshak wrote:
> On Sun, Nov 08, 2020 at 11:32:59AM +0100, Pavel Sanda wrote:
>> Scott/Kornel will presumably review/check the testing part.
> I don't have much time to review or help, although I would be happy to take a
> look in the future (possibly not for a while t
On 11/8/20 3:57 AM, Yuriy Skalko wrote:
>> Isn't there a way with a xxx_cast too ? (maybe reinterpret_cast<> ?)
>>
>> JMarc
>
> Yes, here is another one with casting:
>
> bool operator==(ParConstIterator const & iter1, ParConstIterator const
> & iter2)
> {
> return static_cast(iter1) ==
> stati
On Sun, Nov 08, 2020 at 12:48:11PM -0500, Richard Kimberly Heck wrote:
> On 11/8/20 12:12 PM, Scott Kostyshak wrote:
> > On Sun, Nov 08, 2020 at 11:32:59AM +0100, Pavel Sanda wrote:
> >> Scott/Kornel will presumably review/check the testing part.
> > I don't have much time to review or help, althou
On Mon, 9 Nov 2020, at 01:01, Kornel Benko wrote:
> Needed new perl module (Slurp.pm), got from package 'libfile-slurp-perl'.
I think this use to be in Perl core, but it's now been taken out. I can easily
rewrite if the dependency is a problem.--
lyx-devel mailing list
lyx-devel@lists.lyx.org
ht
On Sun, 8 Nov 2020, at 22:28, Kornel Benko wrote:
> Am Sun, 08 Nov 2020 17:14:42 +1300
> schrieb "Sam Crawley" :
> ...
> > diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> > index 2d93d27c59..32ef0f974a 100644
> > --- a/lib/scripts/lyx_batch.pl.in
> > +++ b/lib/scripts/lyx_b
On Sun, 8 Nov 2020, at 23:32, Pavel Sanda wrote:
> Git commit messages tend to have the following structure: first summary line,
> empty line and then the details. This helps with log summaries.
That is the format I used, unless I'm missing something. The 'subject' line in
a git patch file is th
Am Mon, 09 Nov 2020 09:00:48 +1300
schrieb "Sam Crawley" :
> On Sun, 8 Nov 2020, at 22:28, Kornel Benko wrote:
> > Am Sun, 08 Nov 2020 17:14:42 +1300
> > schrieb "Sam Crawley" :
> > ...
> > > diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> > > index 2d93d27c59..32ef0f974a
Am Mon, 09 Nov 2020 09:07:35 +1300
schrieb "Sam Crawley" :
> On Mon, 9 Nov 2020, at 01:01, Kornel Benko wrote:
> > Needed new perl module (Slurp.pm), got from package 'libfile-slurp-perl'.
>
> I think this use to be in Perl core, but it's now been taken out. I can
> easily rewrite
> if the depen
I'm happy to have someone commit a new version. Mostly, I was just
surprised by the comment. It seemed like there must be some way to
compare these as DocIterators without doing a copy. So it turns out
there are many!
Riki
I've committed it. Also commented out it, as was suggested by Jean-Marc.
On Mon, Nov 09, 2020 at 09:19:42AM +1300, Sam Crawley wrote:
> On Sun, 8 Nov 2020, at 23:32, Pavel Sanda wrote:
>
> > Git commit messages tend to have the following structure: first summary
> > line,
> > empty line and then the details. This helps with log summaries.
>
> That is the format I use
17 matches
Mail list logo