[Patch] Re: [Patch] Re: nested updates

2005-05-10 Thread Martin Vermeer
On Tue, 2005-05-10 at 09:43, Asger Ottar Alstrup wrote: > > This would mean having our own event queue on top of Qt's... And I > > thought toolkits were made to relieve developers from re-inventing the > > wheel all the time. This somehow doesn't feel Right. > > Martin already implemented it. It

Re: [Patch] Re: [Patch] Re: nested updates

2005-05-10 Thread Martin Vermeer
On Tue, 2005-05-10 at 10:03, Martin Vermeer wrote: > On Tue, 2005-05-10 at 09:43, Asger Ottar Alstrup wrote: > > > > This would mean having our own event queue on top of Qt's... And I > > > thought toolkits were made to relieve developers from re-inventing the > > > wheel all the time. This someh

Re: Fix invalid access in insetcommandparams.C

2005-05-10 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, May 09, 2005 at 10:58:51AM +0200, Lars Gullik Bjønnes wrote: >> John Levon <[EMAIL PROTECTED]> writes: >> >> | On Thu, May 05, 2005 at 05:23:56PM +0100, Angus Leeming wrote: >> > >> >> Urs. Doesn't cmd[-1] mean cmd[cmd.length()-2]. Some nast

Re: Fix invalid access in insetcommandparams.C

2005-05-10 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, May 09, 2005 at 10:57:10AM +0200, Lars Gullik Bjønnes wrote: >> Subscript is really unsigned so -1 -> 0x and we get a crash. > | Mind your manners. There is no requirement for -1 == 0x in | The Holy Standard. And I was wrong as w

Re: [Patch] Re: [Patch] Re: nested updates

2005-05-10 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: I think this looks good, if you can get somebody else to test it to verify your claims :-) then it should be committed. But please just get rid of the commented "processEvente"s. -- Lgb

Re: nested updates

2005-05-10 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: > >> same. So far I only heard 'removing processEvents() call removes the >> crash' but no ill side effects. If there are indeed none, the solution >> seems obvious. > | At least the call of processEvents in QMathDialog.C on line 56 is

Re: [Patch] Re: [Patch] Re: nested updates

2005-05-10 Thread Asger Alstrup
Great! I was frankly a bit surprised that Qt would fire events without any reason. Good to learn that it doesn't. FYI, the native Windows API does not do this either, except if you try to use multimedia. When you start a movieclip, windows will process messages. Urgh! When you go look in the do

Re: nested updates

2005-05-10 Thread Martin Vermeer
On Mon, 2005-05-09 at 22:17, Georg Baum wrote: > Andre Poenitz wrote: > > > same. So far I only heard 'removing processEvents() call removes the > > crash' but no ill side effects. If there are indeed none, the solution > > seems obvious. > > At least the call of processEvents in QMathDialog.C on

Re: nested updates

2005-05-10 Thread Georg Baum
Martin Vermeer wrote: > On Mon, 2005-05-09 at 22:17, Georg Baum wrote: >> At least the call of processEvents in QMathDialog.C on line 56 is >> necessary. Otherwise the scrollbars are completeley useless (always 100% >> height). Don't ask me why that is the case and if it can be handled >> differen

Re: nested updates

2005-05-10 Thread Martin Vermeer
On Tue, 2005-05-10 at 11:10, Georg Baum wrote: > Martin Vermeer wrote: > > > On Mon, 2005-05-09 at 22:17, Georg Baum wrote: > >> At least the call of processEvents in QMathDialog.C on line 56 is > >> necessary. Otherwise the scrollbars are completeley useless (always 100% > >> height). Don't ask m

Re: [Patch] Re: [Patch] Re: nested updates

2005-05-10 Thread Martin Vermeer
On Tue, 2005-05-10 at 10:57, Asger Alstrup wrote: > Great! I was frankly a bit surprised that Qt would fire events without any > reason. Good to learn that it doesn't. > > FYI, the native Windows API does not do this either, except if you try to > use multimedia. When you start a movieclip, wind

Re: nested updates

2005-05-10 Thread Georg Baum
Martin Vermeer wrote: >> > But in my patch, showCursor calls processEvents every 0.4 sec. >> >> I'll try that. It does not work :-( I have Alfredos new scrollbar patch applied. Maybe that is the reason? I'll try without it, but not today anymore. Georg

Re: unneeded update() calls

2005-05-10 Thread Georg Baum
Andre Poenitz wrote: >> And why is this information not in cursor.h? > > Is this a trick question? Yes. Take it as a gentle complaint that the code is not documented enough (see for example the iterator classes). I always try to add documentation when I got some informartion from the list, but i

Re: nested updates

2005-05-10 Thread Martin Vermeer
On Tue, 2005-05-10 at 11:55, Georg Baum wrote: > Martin Vermeer wrote: > > >> > But in my patch, showCursor calls processEvents every 0.4 sec. > >> > >> I'll try that. > > It does not work :-( Could I again have a _precise_ description of what you see? I may have misunderstood. > I have Alfred

Re: [Patch] Re: [Patch] Re: nested updates

2005-05-10 Thread John Levon
On Tue, May 10, 2005 at 10:03:30AM +0300, Martin Vermeer wrote: > I tested the situations where the processEvents() call had been added, > to see if the reasons for doing so were still valid: I found none. The > symbol panel scrollbar in the math dialog; at least the tabular dialog > refresh; and

[PATCH] various TOC-related fixes

2005-05-10 Thread Jean-Marc Lasgouttes
This patch includes several fixes: - the numbering pane in Qt document settings is not hardcoded anymore (and the code is simpler). It is also disabled when there is no toc structure. - fix a crash when showing TOC - remove some Counter_xxx from layout files (there is one remaining in man

Re: [PATCH 13x] porting the spell stuff, etc.

2005-05-10 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> JMarc, the attached patch ports the changes I made last week to Angus> LyX 1.4.x to the 1.3.x tree. It means that LyX 1.3.x will now Angus> compile out of the box on Windows using mingw/msys. I think it looks very good. I'd say you

Re: nested updates

2005-05-10 Thread Martin Vermeer
On Tue, 2005-05-10 at 14:25, Martin Vermeer wrote: > On Tue, 2005-05-10 at 11:55, Georg Baum wrote: > > Martin Vermeer wrote: > > > > >> > But in my patch, showCursor calls processEvents every 0.4 sec. > > >> > > >> I'll try that. > > > > It does not work :-( > > Could I again have a _precise_

Re: [PATCH] various TOC-related fixes

2005-05-10 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > The is still a problem that I am not sure how to solve: when I set the > min/max value of the depthSL slider, the value of the slider will be > changed if it is outside of the new range. This in turn will invoke > updateNumbering through the valueChanged signal, and th

Re: [PATCH 13x] porting the spell stuff, etc.

2005-05-10 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> JMarc, the attached patch ports the changes I made last week to > Angus> LyX 1.4.x to the 1.3.x tree. It means that LyX 1.3.x will now > Angus> compile out of the box on Windows using mingw/msys. > > I think it looks very good. I'd say you should commit it and

Re: [PATCH] various TOC-related fixes

2005-05-10 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Is this what you're looking for? Angus> http://doc.trolltech.com/3.3/qobject.html#blockSignals Angus> void QObject::blockSignals ( bool block ); Blocks signals if Angus> block is TRUE, or unblocks signals if block is FALSE. I am

Re: [PATCH 1.3] Postscript Interpreter: gswin32

2005-05-10 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes: Michael> Jean-Marc Lasgouttes wrote: >> I propose to keep the useless option (so that some people do not >> get an error), but remove the test in lib/configure. OK? >> >> Michael> If it doesn't break the system: Fine! I did that. J

Re: [PATCH] shortcut

2005-05-10 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes: Michael> Hi Jean-Marc, >> What are the other patches you have in hand? I lost the count. Michael> there is one patch missing for 1.3 (see attachment). I am not sure I want to do text change (especially in menus) in 1.3 now. Is it rea

Re: [PATCH] various TOC-related fixes

2005-05-10 Thread John Levon
On Tue, May 10, 2005 at 05:05:39PM +0200, Jean-Marc Lasgouttes wrote: > I am not sure whether I want to block _all_ signals. I am not even > sure of what signals are fired, actually. I guess I'll stick to a bool > guard. Just setUpdatesEnabled(false) ? john

Re: [PATCH] various TOC-related fixes

2005-05-10 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: >> "Angus" == Angus Leeming <[EMAIL PROTECTED]> >> writes: > > Angus> Is this what you're looking for? > > Angus> http://doc.trolltech.com/3.3/qobject.html#blockSignals > > Angus> void QObject::blockSignals ( bool block ); Blocks signals if > Angus> block is

Re: nested updates

2005-05-10 Thread Georg Baum
Martin Vermeer wrote: > What I see is, that immediately after opening, the scrollbar is almost > 100% (well,95%) and nonfunctional. Only if the panel is bigger than its It is 100% with the default size of the panel for me. > viewport. Then, when you resize the whole math panel, the scrollbar > s

[patch] fix bug 1879

2005-05-10 Thread Georg Baum
We still have some crashes related to open dialogs, see http://bugzilla.lyx.org/show_bug.cgi?id=1879. The attached patch should fix them. I am now pretty sure that I understand LFUN_INSET_MODIFY: The arguments are the new inset parameters. For many insets the first parameter is thee inset name, but

Re: [PATCH 13x] porting the spell stuff, etc.

2005-05-10 Thread Michael Schmitt
Angus Leeming wrote: Jean-Marc Lasgouttes wrote: Angus> JMarc, the attached patch ports the changes I made last week to Angus> LyX 1.4.x to the 1.3.x tree. It means that LyX 1.3.x will now Angus> compile out of the box on Windows using mingw/msys. I think it looks very good. I'd say you should c

Re: [PATCH] shortcut

2005-05-10 Thread Michael Schmitt
Jean-Marc Lasgouttes wrote: I am not sure I want to do text change (especially in menus) in 1.3 now. Is it really necessary? Well, the question is whether "Refs" makes any sense to the user. What would you expect "Refs" to do? Probably not to jump to the associated label (note: label, not labe

Re: nested updates

2005-05-10 Thread Martin Vermeer
On Tue, May 10, 2005 at 06:16:17PM +0200, Georg Baum wrote: > Martin Vermeer wrote: > > > What I see is, that immediately after opening, the scrollbar is almost > > 100% (well,95%) and nonfunctional. Only if the panel is bigger than its > > It is 100% with the default size of the panel for me. >

2 questions regarding qt2 frontend

2005-05-10 Thread Hammer Armin
Hi, I've seen in the Whishlist the usage of QSession mentionend. It would be nice to store and retrieve the window size and position. Is someone working on this? I'm a bit out of practise using C++ but a could help. The other question concerns the menuitems. In my build of LyX 1.4.0cvs - on Mac

Re: [Patch] Re: nested updates

2005-05-10 Thread Juergen Spitzmueller
Martin Vermeer wrote: >> As you have seen by now, Martin demonstrated that this will not work. > > Actually no, that claim is too strong. But Alfredo found that this would > work, but I don't know how thoroughly he tested. It was me, but I must confess that my testing could have been more intens

Re: LyX meeting in Paris. When?

2005-05-10 Thread Lars Gullik Bjønnes
Asger Ottar Alstrup <[EMAIL PROTECTED]> writes: | Jean-Marc Lasgouttes wrote: >> Jul 16Jul 23Jul 30 Aug 06 >> JMarc 5 5 5 5 >> Jose' 5 5 0 0 >> Lars 4 4 5 5 >> Michael5 0 0

[bug 1873] Patch for testing

2005-05-10 Thread Lars Gullik Bjønnes
http://bugzilla.lyx.org/show_bug.cgi?id=1873 I think this is enough, to make this work. Please test. Index: src/buffer.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/buffer.C,v retrieving revision 1.616 diff -u -p -r1.616 buf

LyX 1.3 & MinGW on Win XP

2005-05-10 Thread Michael Schmitt
Hello everybody, LyX 1.3.6cvs with latest patches built successfully on Win XP using MinGW and a static Qt3/Win Free library! For those who want to build their own Windows binary, I have attached the revised compile instructions. Good night, Michael 1 MinGW & MSYS 1.1 Download the following pa

[PATCH] In-place editing of macro arguments

2005-05-10 Thread Sebastian Reichelt
Hello! Right now, navigating macros with arguments is quite unintuitive, especially since they change their size on the screen when you enter and leave them. (Actually, I mean macro calls, not macro definitions.) So I've developed a small patch for Lyx (version 1.3.4 from Debian) that makes mat

Re: [PATCH] shortcut

2005-05-10 Thread John Levon
On Tue, May 10, 2005 at 08:05:39PM +0200, Michael Schmitt wrote: > Well, the question is whether "Refs" makes any sense to the user. What > would you expect "Refs" to do? Probably not to jump to the associated > label (note: label, not labels). > > Anyway, I let you take the final decision...