Re: vcs load problem

Am 05.11.2010 um 22:30 schrieb Vincent van Ravesteijn: >>>>> first step to cure the VCS load problem >>>> > > Is it now completely fixed after r36145 ? 99,9% yes... :-) I have to start over with a new document to verify it. Though I'm nearly sure it work

Re: vcs load problem

>>>> first step to cure the VCS load problem >>> Is it now completely fixed after r36145 ? Vincent

Re: vcs load problem

Am 02.11.2010 um 13:06 schrieb Vincent van Ravesteijn: > >>>> The VCS load problem is (was) twofold: 1. the parser of the document needs >>>> the VCS state so this state (checked by file_found_hook) had to be done >>>> earlier. >>>>

Re: vcs load problem

Vincent van Ravesteijn wrote: > If we have a file, we insert an InsetInfo about vcs, then we add the file > to a vcs, will the InsetInfo be updated ? Apparently not, apparently the > file is updated not until we parse the file again. it will be updated, when you add file to vcs, its reloaded. p

Re: vcs load problem

Stephan Witt wrote: > > The attached patch works. i'm happy the other occurences disappeared... pavel

Re: vcs load problem

Vincent van Ravesteijn wrote: > Why does the parser need to know the state ? If the state changes, do we > then reparse the file too ? I think this stumbles on a other design > problem. > > If we have a file, we insert an InsetInfo about vcs, then we add the file > to a vcs, will the InsetInfo b

Re: vcs load problem

Am 02.11.2010 um 12:51 schrieb Stephan Witt: > Am 02.11.2010 um 12:34 schrieb Vincent van Ravesteijn: > >> >>>>> first step to cure the VCS load problem >>>> Can I please remind you and ask you to write meaningful commit-logs. Logs >>>> e

Re: vcs load problem

The VCS load problem is (was) twofold: 1. the parser of the document needs the VCS state so this state (checked by file_found_hook) had to be done earlier. => first step, move it some lines up, above the readDocument() call. Why does the parser need to know the state ? If the state chan

Re: vcs load problem

Am 02.11.2010 um 12:34 schrieb Vincent van Ravesteijn: > >>>> first step to cure the VCS load problem >>> Can I please remind you and ask you to write meaningful commit-logs. Logs >>> explaining why the change has been made, why the new design or solution or &

vcs load problem

first step to cure the VCS load problem Can I please remind you and ask you to write meaningful commit-logs. Logs explaining why the change has been made, why the new design or solution or implementation is better, what problem it fixed, why other solutions might be wrong although it may