Re: trunk: Assert when copying table

2009-07-14 Thread Jean-Marc Lasgouttes
Le 15 juil. 09 à 00:28, Vincent van Ravesteijn a écrit : copySelectionHelper calls: acceptChanges(copy_pars, buf.params()); This means that the paragraphs are already copied into the ParagraphList and they don't have a buffer anymore. Yes, this is why my changeset that removed plenty of expl

Re: trunk: Assert when copying table

2009-07-14 Thread Vincent van Ravesteijn
Jean-Marc Lasgouttes schreef: Le 15 juil. 09 à 00:11, Vincent van Ravesteijn a écrit : Changes are accepted in the selection, which need bufferparams(). Yes, this is what I saw. So it is my fault after all :) I guess the problem is r30531, which should probably be reverted (I do not have time

Re: trunk: Assert when copying table

2009-07-14 Thread Jean-Marc Lasgouttes
Le 15 juil. 09 à 00:22, Jean-Marc Lasgouttes a écrit : Finally, moveItem needs this information only to be able to call getFontSettings. I doubt that this operation really requires the bufferparam... All this boils down to the fact that we may need the document language. This really does not

Re: trunk: Assert when copying table

2009-07-14 Thread Jean-Marc Lasgouttes
Le 15 juil. 09 à 00:11, Vincent van Ravesteijn a écrit : Changes are accepted in the selection, which need bufferparams(). Yes, this is what I saw. So it is my fault after all :) I guess the problem is r30531, which should probably be reverted (I do not have time to do it cleanly, but it almos

Re: trunk: Assert when copying table

2009-07-14 Thread Vincent van Ravesteijn
Jean-Marc Lasgouttes schreef: Le 15 juil. 09 à 00:00, Vincent van Ravesteijn a écrit : Select a table, try to copy. Assert! It is worse than that: select any inset, copy or deselect it -> crash What happens is that the copy of the inset that is done has a buffer pointer =0, and this asserts

Re: trunk: Assert when copying table

2009-07-14 Thread Jean-Marc Lasgouttes
Le 15 juil. 09 à 00:00, Vincent van Ravesteijn a écrit : Select a table, try to copy. Assert! It is worse than that: select any inset, copy or deselect it -> crash What happens is that the copy of the inset that is done has a buffer pointer =0, and this asserts. I do not know though why thi

trunk: Assert when copying table

2009-07-14 Thread Vincent van Ravesteijn
Select a table, try to copy. Assert! Vincent