Re: tiny undo patch

2001-12-14 Thread Juergen Vigna
On 14-Dec-2001 Lars Gullik Bjønnes wrote: >| Well thanks for commiting this and nowing that I did big changes in >| that file > > Why every would be changes be needed in that file? It is a container, > no policy should be in it. Well I didn't touch undostack only undo_funcs.C and the big chang

Re: tiny undo patch

2001-12-14 Thread Andre Poenitz
On Fri, Dec 14, 2001 at 11:18:54AM +0100, Juergen Vigna wrote: > - Undo * undo = bv->buffer()->undostack.pop(); > + Undo * undo = bv->buffer()->undostack.top(); > + bv->buffer()->undostack.pop(); > > Why is this better? This is better because it makes the interface of the UndoS

RE: tiny undo patch

2001-12-14 Thread Juergen Vigna
On 13-Dec-2001 Andre Poenitz wrote: > It serves only as a measure to remove distraction ("Gosh... why two spaces > here") when reading undostack.C... Well thanks for commiting this and nowing that I did big changes in that file so that I loose more time resolving conflicts the fixing bugs! Some

Re: tiny undo patch

2001-12-13 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Thu, Dec 13, 2001 at 06:20:02PM +0100, Jean-Marc Lasgouttes Andre> wrote: >> Juergen, can I apply this? You say your are looking at undo. Andre> Too late ;-) I saw that :) JMarc

Re: tiny undo patch

2001-12-13 Thread Andre Poenitz
On Thu, Dec 13, 2001 at 06:20:02PM +0100, Jean-Marc Lasgouttes wrote: > Juergen, can I apply this? You say your are looking at undo. Too late ;-) Andre' -- André Pönitz .. [EMAIL PROTECTED]

Re: tiny undo patch

2001-12-13 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> This is (more or less) part of the somewhat larger undo patch I Andre> send some time ago. Andre> It's not only whitespace stuff, making 'pop' more STL like, and Andre> removal of some spurious 'using lyx::pos_type' Andre> It ser

tiny undo patch

2001-12-13 Thread Andre Poenitz
This is (more or less) part of the somewhat larger undo patch I send some time ago. It's not only whitespace stuff, making 'pop' more STL like, and removal of some spurious 'using lyx::pos_type' It serves only as a measure to remove distraction ("Gosh... why two spaces here") when reading undos