Re: support/lstrings.C subst() stuck in a loop

2005-09-07 Thread Eric Wilhelm
# from Jean-Marc Lasgouttes # on Wednesday 07 September 2005 04:47: >So the following patches are OK? > >Lars> guess so > >I applied them. Thanks to everybody who followed-up on this. I wasn't sure if I was making any sense working without a $HOME -- otherwise I would have filed a bug report.

Re: support/lstrings.C subst() stuck in a loop

2005-09-07 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | So the following patches are OK? Lars> guess so I applied them. JMarc

Re: support/lstrings.C subst() stuck in a loop

2005-09-06 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Georg Baum <[EMAIL PROTECTED]> writes: | | I'd prefer 2/, since it does not make sense to subtitute an empty part of a | | string with something else. > | Lars> agree > | So

Re: support/lstrings.C subst() stuck in a loop

2005-09-06 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Georg Baum <[EMAIL PROTECTED]> writes: | I'd prefer 2/, since it does not make sense to subtitute an empty part of a | string with something else. Lars> agree So the following patches are OK? JMarc Index: src/support/Change

Re: support/lstrings.C subst() stuck in a loop

2005-08-31 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Jean-Marc Lasgouttes wrote: > >> 1/ make subst(str, from, to) directly return when from is empty. This >> seems to be very reasonable semantics. >> >> 2/ make subst assert on this case (since the code does not work in >> this case) and fix MakeDisplayPath.

Re: support/lstrings.C subst() stuck in a loop

2005-08-30 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > 1/ make subst(str, from, to) directly return when from is empty. This > seems to be very reasonable semantics. > > 2/ make subst assert on this case (since the code does not work in > this case) and fix MakeDisplayPath. > > What would you prefer? I'd prefer 2/, sin

Re: support/lstrings.C subst() stuck in a loop

2005-08-30 Thread Jean-Marc Lasgouttes
> "Eric" == Eric Wilhelm <[EMAIL PROTECTED]> writes: Eric> Hi again. I've traced this cgi export bug into filetools.C Eric> (MakeDisplayPath) and from there to lstrings.C and it is stuck Eric> in this loop. Eric> while ((i = lstr.find(oldstr, i)) != string::npos) { lyxerr << Eric> "while su

Re: support/lstrings.C subst() stuck in a loop

2005-08-13 Thread Eric Wilhelm
Hi again. I've traced this cgi export bug into filetools.C (MakeDisplayPath) and from there to lstrings.C and it is stuck in this loop. while ((i = lstr.find(oldstr, i)) != string::npos) { lyxerr << "while subst " << i << endl; lstr.replace(i, olen, newstr