(Is this fixed in 1.6.9?) Extreme speed difference. Re: std::distance and RandomAccessList

2011-02-08 Thread Michael Joyner
Is this fixed in 1.6.9? On Sat, Dec 18, 2010 at 11:37 AM, Jean-Marc Lasgouttes wrote: > Le 18 déc. 2010 à 09:22, Abdelrazak Younes a écrit : > > OK, I just committed a fix then. Please try it. > > On a release build on trunk, for exporting to pdflatex format I get > > before: 220 seconds > after:

Re: (Is this fixed in 1.6.9?) Extreme speed difference. Re: std::distance and RandomAccessList

2011-02-08 Thread Jean-Marc Lasgouttes
Le 08/02/2011 04:34, Michael Joyner a écrit : Is this fixed in 1.6.9? Unfortunately not. The patch in 2.0 was quite large, although Abdel hinted that a shorter one could do for 1.6.x. JMarc

Re: std::distance and RandomAccessList

2010-12-19 Thread Abdelrazak Younes
On 18/12/2010 22:03, Bernhard Roider wrote: 2010/12/18 Abdelrazak Younes mailto:you...@lyx.org>> On 18/12/2010 19:33, Jean-Marc Lasgouttes wrote: Le 18 déc. 2010 à 19:08, Abdelrazak Younes a écrit : On 18/12/2010 18:57, Jean-Marc Lasgouttes wrote: Le

Re: std::distance and RandomAccessList

2010-12-18 Thread Bernhard Roider
2010/12/18 Abdelrazak Younes > On 18/12/2010 19:33, Jean-Marc Lasgouttes wrote: > >> Le 18 déc. 2010 à 19:08, Abdelrazak Younes a écrit : >> >> On 18/12/2010 18:57, Jean-Marc Lasgouttes wrote: >>> Le 18 déc. 2010 à 17:41, Abdelrazak Younes a écrit : > What part of that could possib

Re: std::distance and RandomAccessList

2010-12-18 Thread Abdelrazak Younes
On 18/12/2010 19:33, Jean-Marc Lasgouttes wrote: Le 18 déc. 2010 à 19:08, Abdelrazak Younes a écrit : On 18/12/2010 18:57, Jean-Marc Lasgouttes wrote: Le 18 déc. 2010 à 17:41, Abdelrazak Younes a écrit : What part of that could possibly go to branch? I guess introducing RandomListAccess::pos

Re: std::distance and RandomAccessList

2010-12-18 Thread Jean-Marc Lasgouttes
Le 18 déc. 2010 à 19:08, Abdelrazak Younes a écrit : > On 18/12/2010 18:57, Jean-Marc Lasgouttes wrote: >> Le 18 déc. 2010 à 17:41, Abdelrazak Younes a écrit : What part of that could possibly go to branch? >>> I guess introducing RandomListAccess::position() and using it will be >>> enough.

Re: std::distance and RandomAccessList

2010-12-18 Thread Abdelrazak Younes
On 18/12/2010 18:57, Jean-Marc Lasgouttes wrote: Le 18 déc. 2010 à 17:41, Abdelrazak Younes a écrit : What part of that could possibly go to branch? I guess introducing RandomListAccess::position() and using it will be enough. Why does this remove the quadratic behaviour? distance(it1, it2)

Re: std::distance and RandomAccessList

2010-12-18 Thread Jean-Marc Lasgouttes
Le 18 déc. 2010 à 17:41, Abdelrazak Younes a écrit : >> What part of that could possibly go to branch? > > I guess introducing RandomListAccess::position() and using it will be enough. Why does this remove the quadratic behaviour? JMarc

Re: std::distance and RandomAccessList

2010-12-18 Thread Abdelrazak Younes
On 18/12/2010 17:37, Jean-Marc Lasgouttes wrote: Le 18 déc. 2010 à 09:22, Abdelrazak Younes a écrit : OK, I just committed a fix then. Please try it. On a release build on trunk, for exporting to pdflatex format I get before: 220 seconds after: 21 seconds No diff between the two files. Loo

Re: std::distance and RandomAccessList

2010-12-18 Thread Jean-Marc Lasgouttes
Le 18 déc. 2010 à 09:22, Abdelrazak Younes a écrit : > OK, I just committed a fix then. Please try it. On a release build on trunk, for exporting to pdflatex format I get before: 220 seconds after: 21 seconds No diff between the two files. Looks like you fixed the problem :) What part of tha

Re: std::distance and RandomAccessList

2010-12-17 Thread Abdelrazak Younes
On 12/17/2010 05:41 PM, Jean-Marc Lasgouttes wrote: Le 17/12/2010 17:17, Abdelrazak Younes a écrit : Anyway, I tested this change and the UserGuide exports correctly (and identically of course). But the bad news is that it make no difference in speed. So my conclusion is that the speed issue has

Re: std::distance and RandomAccessList

2010-12-17 Thread Jean-Marc Lasgouttes
Le 17/12/2010 17:17, Abdelrazak Younes a écrit : Anyway, I tested this change and the UserGuide exports correctly (and identically of course). But the bad news is that it make no difference in speed. So my conclusion is that the speed issue has nothing to do with RandomAccessList, it is much more

Re: std::distance and RandomAccessList

2010-12-17 Thread Abdelrazak Younes
On 12/17/2010 04:50 PM, Jean-Marc Lasgouttes wrote: Le 16/12/2010 21:46, Abdelrazak Younes a écrit : On 15/12/2010 18:17, Jean-Marc Lasgouttes wrote: Le 15/12/2010 17:54, Michael Joyner a écrit : One of our initial goals was to try and maintain an easy to edit file format should the internal c

Re: std::distance and RandomAccessList

2010-12-17 Thread Jean-Marc Lasgouttes
Le 16/12/2010 21:46, Abdelrazak Younes a écrit : On 15/12/2010 18:17, Jean-Marc Lasgouttes wrote: Le 15/12/2010 17:54, Michael Joyner a écrit : One of our initial goals was to try and maintain an easy to edit file format should the internal customers need to "tweak" any of the outputs. The one

Re: std::distance and RandomAccessList

2010-12-16 Thread Abdelrazak Younes
On 15/12/2010 18:17, Jean-Marc Lasgouttes wrote: Le 15/12/2010 17:54, Michael Joyner a écrit : One of our initial goals was to try and maintain an easy to edit file format should the internal customers need to "tweak" any of the outputs. The ones who would be doing the editing are less than tec

Re: std::distance and RandomAccessList

2010-12-15 Thread Abdelrazak Younes
On 15/12/2010 23:12, Jean-Marc Lasgouttes wrote: Le 15/12/2010 18:51, Abdelrazak Younes a écrit : It seems correct. At the time I remember saying to myself that using std::distance was not optimal and that we should use some new fast method in RandomAccessList but I did not bother because it was

Re: std::distance and RandomAccessList

2010-12-15 Thread Jean-Marc Lasgouttes
Le 15/12/2010 18:59, Abdelrazak Younes a écrit : Actually, there is a very simple and effective improvement that I am going to put in trunk: TeXOnePar() always return the next pit! There is absolutely no need to recompute the distance each time. This is a remnant of the past I guess. You mean

Re: std::distance and RandomAccessList

2010-12-15 Thread Jean-Marc Lasgouttes
Le 15/12/2010 18:51, Abdelrazak Younes a écrit : It seems correct. At the time I remember saying to myself that using std::distance was not optimal and that we should use some new fast method in RandomAccessList but I did not bother because it was fast enough. So it is not fast enough for this us

Re: std::distance and RandomAccessList

2010-12-15 Thread Abdelrazak Younes
On 15/12/2010 18:17, Jean-Marc Lasgouttes wrote: Le 15/12/2010 17:54, Michael Joyner a écrit : One of our initial goals was to try and maintain an easy to edit file format should the internal customers need to "tweak" any of the outputs. The ones who would be doing the editing are less than tec

Re: std::distance and RandomAccessList

2010-12-15 Thread Abdelrazak Younes
On 15/12/2010 18:51, Abdelrazak Younes wrote: On 15/12/2010 18:17, Jean-Marc Lasgouttes wrote: Le 15/12/2010 17:54, Michael Joyner a écrit : One of our initial goals was to try and maintain an easy to edit file format should the internal customers need to "tweak" any of the outputs. The ones

Re: std::distance and RandomAccessList (was: Re: Extreme speed difference between 1.4.5.1 and 1.6.8)

2010-12-15 Thread Liviu Andronic
On Wed, Dec 15, 2010 at 6:17 PM, Jean-Marc Lasgouttes wrote: > Duplicating the problem should be as simple as creating a 1800 pages > document IMO. I think at some time there was a document anonymizer for lyx > files (replacing all text by xxx xxx). Does this thing exist? It would be a > nice way

std::distance and RandomAccessList (was: Re: Extreme speed difference between 1.4.5.1 and 1.6.8)

2010-12-15 Thread Jean-Marc Lasgouttes
Le 15/12/2010 17:54, Michael Joyner a écrit : One of our initial goals was to try and maintain an easy to edit file format should the internal customers need to "tweak" any of the outputs. The ones who would be doing the editing are less than technically inclined. Michael kindly sent to me an