Re: rowpainter.C: unused var

2006-10-23 Thread Asger Ottar Alstrup
Jean-Marc Lasgouttes wrote: "Andre" == Andre Pönitz <[EMAIL PROTECTED]> writes: I guess this is not something I can consider for 1.4. Andre> If we don't get mispositioning/coordcache crashes in 1.4, then Andre> not. I do have crashes with pageup in 1.4. Then the nullpainter fix is your me

Re: rowpainter.C: unused var

2006-10-23 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Pönitz <[EMAIL PROTECTED]> writes: >> I guess this is not something I can consider for 1.4. Andre> If we don't get mispositioning/coordcache crashes in 1.4, then Andre> not. I do have crashes with pageup in 1.4. JMarc

Re: rowpainter.C: unused var

2006-10-23 Thread Andre Pönitz
Quoting Abdelrazak Younes <[EMAIL PROTECTED]>: This was exactly what I was investigation some months ago. But then why not going to QPicture directly? This will need some changes to the core but I really think that's the way to go. I would be very surprised if recording the painter operations

Re: rowpainter.C: unused var

2006-10-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Asger Ottar Alstrup wrote: | > Jean-Marc Lasgouttes wrote: | >> I see. Isn't there some performance price? | > Yes, but it is not noticeable in our testing. After all, we only | > paint two extra paragraphs. | > | >> I gu

Re: rowpainter.C: unused var

2006-10-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Asger Ottar Alstrup wrote: | > Jean-Marc Lasgouttes wrote: | >> I see. Isn't there some performance price? | > Yes, but it is not noticeable in our testing. After all, we only | > paint two extra paragraphs. | > | >> I guess this is not something I c

Re: rowpainter.C: unused var

2006-10-23 Thread Andre Pönitz
Quoting Jean-Marc Lasgouttes <[EMAIL PROTECTED]>: "Andre" == Andre Pönitz <[EMAIL PROTECTED]> writes: Andre> With the real one. Could you point me to one or two commits that implement this? 15455 maybe. Andre> The problem was that the nullpainter did not compute positions Andre> correctly

Re: rowpainter.C: unused var

2006-10-23 Thread Abdelrazak Younes
Asger Ottar Alstrup wrote: Jean-Marc Lasgouttes wrote: I see. Isn't there some performance price? Yes, but it is not noticeable in our testing. After all, we only paint two extra paragraphs. I guess this is not something I can consider for 1.4. Sure it is. Without, the coord cache is ful

Re: rowpainter.C: unused var

2006-10-23 Thread Asger Ottar Alstrup
Jean-Marc Lasgouttes wrote: I see. Isn't there some performance price? Yes, but it is not noticeable in our testing. After all, we only paint two extra paragraphs. I guess this is not something I can consider for 1.4. Sure it is. Without, the coord cache is full of crap, and that causes

Re: rowpainter.C: unused var

2006-10-23 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Pönitz <[EMAIL PROTECTED]> writes: Andre> With the real one. Could you point me to one or two commits that implement this? Andre> The problem was that the nullpainter did not compute positions Andre> correctly. If it did so, it would need to use almost the same Andre> log

Re: rowpainter.C: unused var

2006-10-23 Thread Andre Pönitz
Quoting Jean-Marc Lasgouttes <[EMAIL PROTECTED]>: "Asger" == Asger Ottar Alstrup <[EMAIL PROTECTED]> writes: Asger> Michael Gerz wrote: /home/software/lyx-trunk/src/rowpainter.C:865: warning: unused variable `const bool inside' Asger, is it safe to remove the variable? Asger> Yes, and you

Re: rowpainter.C: unused var

2006-10-23 Thread Asger Ottar Alstrup
Jean-Marc Lasgouttes wrote: Asger> The nullpainter is no good, because it can not calculate the Asger> metrics of text, so it's basically useless. It was the cause of Asger> wrong metrics in the coordcache, which caused all sorts of Asger> problems. what did you replace it with? We use the rea

Re: rowpainter.C: unused var

2006-10-23 Thread Jean-Marc Lasgouttes
> "Asger" == Asger Ottar Alstrup <[EMAIL PROTECTED]> writes: Asger> Michael Gerz wrote: /home/software/lyx-trunk/src/rowpainter.C:865: warning: unused variable `const bool inside' >> Asger, is it safe to remove the variable? Asger> Yes, and you can nuke the nullpainter as well whil

Re: rowpainter.C: unused var

2006-10-22 Thread Asger Ottar Alstrup
Michael Gerz wrote: /home/software/lyx-trunk/src/rowpainter.C:865: warning: unused variable `const bool inside' > Asger, is it safe to remove the variable? Yes, and you can nuke the nullpainter as well while you are at it. The nullpainter is no good, because it can not calculate the metric

Re: rowpainter.C: unused var

2006-10-22 Thread Michael Gerz
Asger Ottar Alstrup wrote: Yes, and you can nuke the nullpainter as well while you are at it. The nullpainter is no good, because it can not calculate the metrics of text, so it's basically useless. It was the cause of wrong metrics in the coordcache, which caused all sorts of problems. Ple

Re: rowpainter.C: unused var

2006-10-22 Thread Michael Gerz
Martin Vermeer wrote: On Sun, Oct 22, 2006 at 04:40:13PM +0200, Michael Gerz wrote: This one look suspicious: /home/software/lyx-trunk/src/rowpainter.C:865: warning: unused variable `const bool inside' Michael Yes, Asger threw the nullpainter out (r15455). (Probably left behind

Re: rowpainter.C: unused var

2006-10-22 Thread Martin Vermeer
On Sun, Oct 22, 2006 at 04:40:13PM +0200, Michael Gerz wrote: > This one look suspicious: > > /home/software/lyx-trunk/src/rowpainter.C:865: warning: unused variable > `const > bool inside' > > Michael Yes, Asger threw the nullpainter out (r15455). (Probably left behind when working on the p

rowpainter.C: unused var

2006-10-22 Thread Michael Gerz
This one look suspicious: /home/software/lyx-trunk/src/rowpainter.C:865: warning: unused variable `const bool inside' Michael