Re: resizing xform dialogs patch

2000-10-23 Thread Allan Rae
On Mon, 23 Oct 2000, Angus Leeming wrote: > On Mon, 23 Oct 2000, Jean-Marc Lasgouttes wrote: > > Does it mean I should refrain from applying the patch? All in all, I > > think this should wait after 1.1.6, unless bugs are fixed in the > > process. > > No bugs are fixed (and none are introduced,

Re: resizing xform dialogs patch

2000-10-23 Thread Angus Leeming
On Mon, 23 Oct 2000, Jean-Marc Lasgouttes wrote: > Does it mean I should refrain from applying the patch? All in all, I > think this should wait after 1.1.6, unless bugs are fixed in the > process. No bugs are fixed (and none are introduced, Lars!). The patch does nothing but make the code clean

Re: resizing xform dialogs patch

2000-10-23 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Ok, where is the comment the describes _why_ this is safe. And Lars> it is only safe _becuase_ there are other code that makes it so. Lars> In itself it is unsafe. Does it mean I should refrain from applying the patch? All in

Re: resizing xform dialogs patch

2000-10-23 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Sun, 22 Oct 2000, Lars Gullik Bjønnes wrote: | > Angus Leeming <[EMAIL PROTECTED]> writes: | > | > void FormCommand::showInset( InsetCommand & inset ) | > | > { | > | > inset_ = &inset; | > | > ... | > | > } | > | > This is not safe,

Re: resizing xform dialogs patch

2000-10-23 Thread Angus Leeming
On Sun, 22 Oct 2000, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > | > void FormCommand::showInset( InsetCommand & inset ) > | > { > | > inset_ = &inset; > | > ... > | > } > > This is not safe, ... just imagine what will happen if the > InsetCommand goes out of scope

Re: resizing xform dialogs patch

2000-10-22 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | > void FormCommand::showInset( InsetCommand & inset ) | > { | > inset_ = &inset; | > ... | > } | > This is not safe, ... just imagine what will happen if the InsetCommand goes out of scope or is deleted. Lgb

Re: resizing xform dialogs patch

2000-10-20 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Anyway, find attached a patch that fixes possible crashes when Angus> resizing xforms dialogs. I applied it. JMarc

Re: resizing xform dialogs patch

2000-10-20 Thread Angus Leeming
Morning, Allan. Or good evening if you're around now. > > NOTE to anyone writing xforms dialogs: > > > > Reading the xforms documentation, I discovered that the correct place to > > call fl_set_form_minsize()/maxsize() is BEFORE a call to fl_show_form(). > > Moreover,

Re: resizing xform dialogs patch

2000-10-20 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> is 1.1.5 using the xforms scrollbar? os the lyx hacked one? It uses the xforms scrollbar: fantomas: grep fl_add_scrollbar *.C WorkArea.C: scrollbar = obj = fl_add_scrollbar(FL_VERT_SCROLLBAR, JMarc

Re: resizing xform dialogs patch

2000-10-20 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Granted. When did your line first appear? In my case, using the Angus> scroll bar did not result in crashes until today (so maybe it Angus> appeared only in the last day or so). It's the sort of thing Angus> you notice pretty quick

Re: resizing xform dialogs patch

2000-10-20 Thread Juergen Vigna
On 19-Oct-2000 Jean-Marc Lasgouttes wrote: > > Load Customization, move the scrollbar up and down, notice a small > line on the menu bar, hide the window to force a redraw. I get this too (not over the whole screen only on the upper part (not text area). If I hide the window (iconize) and then

Re: resizing xform dialogs patch

2000-10-19 Thread Allan Rae
On Thu, 19 Oct 2000, Angus Leeming wrote: [...] > Anyway, find attached a patch that fixes possible crashes when resizing > xforms dialogs. [...] > I decided that the cleanest thing to do was to set the minsize of ALL dialogs > by doing it in FormBase::connect(). See attachment. good. > NOTE

Re: resizing xform dialogs patch

2000-10-19 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Thu, 19 Oct 2000, Lars Gullik Bjønnes wrote: | > Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | > | | > | Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | | > | Lars> >

Re: resizing xform dialogs patch

2000-10-19 Thread Angus Leeming
On Thu, 19 Oct 2000, Lars Gullik Bjønnes wrote: > Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | > | Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > | Lars> > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]>

Re: resizing xform dialogs patch

2000-10-19 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | | Lars> > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | | Lars> Lars> I donot see that line here...

Re: resizing xform dialogs patch

2000-10-19 Thread Angus Leeming
On Thu, 19 Oct 2000, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> A! And I get these crashes with > > Angus> #define FL_VERSION 0 #define FL_REVISION 89 #define FL_FIXLEVEL > Angus> 0 > > Angus> The problems with closed source code and a l

Re: resizing xform dialogs patch

2000-10-19 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> A! And I get these crashes with Angus> #define FL_VERSION 0 #define FL_REVISION 89 #define FL_FIXLEVEL Angus> 0 Angus> The problems with closed source code and a less common machine, Angus> I guess :-( A Anyway, since I have

Re: resizing xform dialogs patch

2000-10-19 Thread Angus Leeming
On Thu, 19 Oct 2000, Lars Gullik Bjønnes wrote: > Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > | > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > | > | Angus> I take it that no-one else is suffering from crashes using the > | Angus> main window's scroll bar? (See earlier mail.) I

Re: resizing xform dialogs patch

2000-10-19 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Lars> > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> Lars> I donot see that line here... what do you do to get it? | Lars> | Load Customization, move

Re: resizing xform dialogs patch

2000-10-19 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> I donot see that line here... what do you do to get it? | | Load Customization, move the scrollbar up and down, notice a small | line on the menu bar, hide the window to

Re: resizing xform dialogs patch

2000-10-19 Thread Angus Leeming
On Thu, 19 Oct 2000, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> I take it that no-one else is suffering from crashes using the > Angus> main window's scroll bar? (See earlier mail.) Is this something > Angus> to do with xforms-0.89 I wonder?

Re: resizing xform dialogs patch

2000-10-19 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I donot see that line here... what do you do to get it? Load Customization, move the scrollbar up and down, notice a small line on the menu bar, hide the window to force a redraw. xforms: Lars> #define FL_VERSION 0 #define F

Re: resizing xform dialogs patch

2000-10-19 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: | | Angus> I take it that no-one else is suffering from crashes using the | Angus> main window's scroll bar? (See earlier mail.) Is this something | Angus> to do with xforms-0.89 I wonde

Re: resizing xform dialogs patch

2000-10-19 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> I take it that no-one else is suffering from crashes using the Angus> main window's scroll bar? (See earlier mail.) Is this something Angus> to do with xforms-0.89 I wonder? Why has the problem surfaced Angus> now and not before?

resizing xform dialogs patch

2000-10-19 Thread Angus Leeming
I take it that no-one else is suffering from crashes using the main window's scroll bar? (See earlier mail.) Is this something to do with xforms-0.89 I wonder? Why has the problem surfaced now and not before? Anyway, find attached a patch that fixes possible crashes when resizing xforms dialog