Le 02/12/11 18:27, Richard Heck a écrit :
That's right. The problem is that the code assumes hidden buffers can
never be dirty. See e.g. GuiView::closeBufferAll(). So I guess the thing
to do is solve this to the extent we can and put a FIXME about why we
can't solve the other case yet.
Yes.
JM
On 12/02/2011 10:15 AM, Jean-Marc Lasgouttes wrote:
> Le 12/02/11 00:28, Richard Heck a écrit :
>> Sorry, what I meant was: LFUN_BRANCH_ACTIVATE is handled in InsetBranch,
>> as well as in Buffer (in the current code). We get there when it's
>> called from the context menu. (You can (de)activate a
Le 12/02/11 00:28, Richard Heck a écrit :
Sorry, what I meant was: LFUN_BRANCH_ACTIVATE is handled in InsetBranch,
as well as in Buffer (in the current code). We get there when it's
called from the context menu. (You can (de)activate a branch by
right-clicking on the inset and choosing a menu ite
On 12/01/2011 06:08 PM, Jean-Marc Lasgouttes wrote:
> Le 29/11/2011 21:40, Richard Heck a écrit :
>> So I investigated this a bit. There really isn't any way to do what
>> JMarc suggested in InsetBranch. The branch itself may (and usually will)
>> be held in the master, and that may not even be ope
Le 29/11/2011 21:40, Richard Heck a écrit :
So I investigated this a bit. There really isn't any way to do what
JMarc suggested in InsetBranch. The branch itself may (and usually will)
be held in the master, and that may not even be open in a view, so there
is no hope of getting a cursor so we ca
On 11/21/2011 04:47 AM, Jean-Marc Lasgouttes wrote:
> Le 21/11/2011 03:20, Richard Heck a écrit :
>>> You have to call recordUndoFullDocument (should be
>>> recordUndoBufferParams, but alas this does not exist) on the master
>>> buffer, then. But I do not see where is the magic code that gives the
On 11/21/2011 04:47 AM, Jean-Marc Lasgouttes wrote:
> Le 21/11/2011 03:20, Richard Heck a écrit :
>>> You have to call recordUndoFullDocument (should be
>>> recordUndoBufferParams, but alas this does not exist) on the master
>>> buffer, then. But I do not see where is the magic code that gives the
Le 21/11/2011 03:20, Richard Heck a écrit :
You have to call recordUndoFullDocument (should be
recordUndoBufferParams, but alas this does not exist) on the master
buffer, then. But I do not see where is the magic code that gives the
master buffer.
I'll have a look at this. Before I do, is there
On 11/20/2011 05:31 PM, Jean-Marc Lasgouttes wrote:
> Le Sat Nov 19 17:15:23 2011, Richard Heck a écrit :
>> Where is this supposed to happen automatically? I see that markDirty()
>> is called from recordUndo(), but that gets called from tons of places.
>
> Oops, my former comment was based on outd
Le Sat Nov 19 17:15:23 2011, Richard Heck a écrit :
Where is this supposed to happen automatically? I see that markDirty()
is called from recordUndo(), but that gets called from tons of places.
Oops, my former comment was based on outdated view of the code.
Nowadays, recordUndo does the trick.
On 11/18/2011 06:05 PM, Jean-Marc Lasgouttes wrote:
> Le Fri Nov 18 21:48:55 2011, rgh...@lyx.org a écrit :
>> Author: rgheck
>> Date: Fri Nov 18 21:48:54 2011
>> New Revision: 40211
>> URL: http://www.lyx.org/trac/changeset/40211
>>
>> Log:
>> Fix bug #7872: Mark Buffer dirty after changing branch
Le Fri Nov 18 21:48:55 2011, rgh...@lyx.org a écrit :
Author: rgheck
Date: Fri Nov 18 21:48:54 2011
New Revision: 40211
URL: http://www.lyx.org/trac/changeset/40211
Log:
Fix bug #7872: Mark Buffer dirty after changing branch activation.
Why can't we just add the right flag to LFUN_BRANCH_ACTIV
12 matches
Mail list logo
