Re: r39533 - lyx-devel/trunk/lib

2011-08-29 Thread Enrico Forestieri
On Mon, Aug 29, 2011 at 01:28:47PM +0200, Julien Rioux wrote: > Thanks for the explanation and the fix. The update to README would > be something like this. OK? That's fine, but, please, also update INSTALL and INSTALL.scons as Python 2.3 is also mentioned there. -- Enrico

Re: r39533 - lyx-devel/trunk/lib

2011-08-29 Thread Pavel Sanda
Julien Rioux wrote: > On 28/08/2011 9:02 PM, Enrico Forestieri wrote: >> Using shell=False on windows allows to explicitly invoke as >> "cmd /d /c", thus solving #7718. This is not necessary on the >> other platforms and should even be avoided in order to not occur in the >> same QTBUG-19885, whic

Re: r39533 - lyx-devel/trunk/lib

2011-08-29 Thread Julien Rioux
On 28/08/2011 9:02 PM, Enrico Forestieri wrote: Using shell=False on windows allows to explicitly invoke as "cmd /d /c", thus solving #7718. This is not necessary on the other platforms and should even be avoided in order to not occur in the same QTBUG-19885, which affects texlive commands. Th

Re: r39533 - lyx-devel/trunk/lib

2011-08-28 Thread Enrico Forestieri
On Sun, Aug 28, 2011 at 07:46:46PM +0200, Julien Rioux wrote: > On 27/08/2011 9:15 PM, Enrico Forestieri wrote: > >I am surprised by the number of ways the design of Windows can be flawed. > > > >I don't think that ditching the shell is the way to go. Anyway, you > >should use shell=False only on

Re: r39533 - lyx-devel/trunk/lib

2011-08-28 Thread Julien Rioux
On 27/08/2011 9:15 PM, Enrico Forestieri wrote: I am surprised by the number of ways the design of Windows can be flawed. I don't think that ditching the shell is the way to go. Anyway, you should use shell=False only on Windows and maybe trying to run the command via "cmd /d /c". In this way, a

Re: r39533 - lyx-devel/trunk/lib

2011-08-28 Thread Enrico Forestieri
On Sat, Aug 27, 2011 at 09:15:22PM +0200, Enrico Forestieri wrote: > On Sat, Aug 27, 2011 at 07:42:06PM +0200, Julien Rioux wrote: > > > One issue is that os.popen relies on the shell to launch external > > scripts, with for example issue #7718 as consequence. I think a > > patch using subprocess

Re: r39533 - lyx-devel/trunk/lib

2011-08-27 Thread Enrico Forestieri
On Sat, Aug 27, 2011 at 07:42:06PM +0200, Julien Rioux wrote: > One issue is that os.popen relies on the shell to launch external > scripts, with for example issue #7718 as consequence. I think a > patch using subprocess could fix this outstanding issue. The commit > r39526 was only a first step,

Re: r39533 - lyx-devel/trunk/lib

2011-08-27 Thread Julien Rioux
On 27/08/2011 10:38 AM, Enrico Forestieri wrote: On Sat, Aug 27, 2011 at 02:07:02AM +0200, Julien Rioux wrote: Due to my playing with git, the commits r39525 and 39526 happened simultaneously, while I only meant to commit the first. My question is: What problem is addressing r39526? subproc

Re: r39533 - lyx-devel/trunk/lib

2011-08-27 Thread Enrico Forestieri
On Sat, Aug 27, 2011 at 02:07:02AM +0200, Julien Rioux wrote: > > Due to my playing with git, the commits r39525 and 39526 happened > simultaneously, while I only meant to commit the first. My question is: What problem is addressing r39526? > subprocess.Popen itself requires 2.4, only the window

Re: r39533 - lyx-devel/trunk/lib

2011-08-27 Thread Pavel Sanda
Richard Heck wrote: > > subprocess.Popen itself requires 2.4, only the windows script already > > requires this python version. Is it time to bump the requirement for > > everyone? > > > I would think 2.4 was a pretty reasonable minimum, though I guess we > should check what Python is available for

Re: r39533 - lyx-devel/trunk/lib

2011-08-26 Thread Richard Heck
On 08/26/2011 08:07 PM, Julien Rioux wrote: > On 27/08/2011 1:46 AM, Enrico Forestieri wrote: >> On Sat, Aug 27, 2011 at 01:29:37AM +0200, jri...@lyx.org wrote: >> >>> Author: jrioux >>> Date: Sat Aug 27 01:29:37 2011 >>> New Revision: 39533 >>> URL: http://www.lyx.org/trac/changeset/39533 >>> >>>

Re: r39533 - lyx-devel/trunk/lib

2011-08-26 Thread Julien Rioux
On 27/08/2011 1:46 AM, Enrico Forestieri wrote: On Sat, Aug 27, 2011 at 01:29:37AM +0200, jri...@lyx.org wrote: Author: jrioux Date: Sat Aug 27 01:29:37 2011 New Revision: 39533 URL: http://www.lyx.org/trac/changeset/39533 Log: configure.py : subprocess, second try (check_output requires pytho

Re: r39533 - lyx-devel/trunk/lib

2011-08-26 Thread Enrico Forestieri
On Sat, Aug 27, 2011 at 01:29:37AM +0200, jri...@lyx.org wrote: > Author: jrioux > Date: Sat Aug 27 01:29:37 2011 > New Revision: 39533 > URL: http://www.lyx.org/trac/changeset/39533 > > Log: > configure.py : subprocess, second try (check_output requires > python 2.7 and throws unwanted exception