Re: r38251 - lyx-devel/trunk/src/frontends/qt4

2011-04-05 Thread Enrico Forestieri
On Tue, Apr 05, 2011 at 05:06:44PM +0200, Enrico Forestieri wrote: > On Tue, Apr 05, 2011 at 09:45:27AM +0200, Vincent van Ravesteijn wrote: > > > > >Modified: lyx-devel/trunk/src/frontends/qt4/GuiErrorList.cpp > > >== > >

Re: r38251 - lyx-devel/trunk/src/frontends/qt4

2011-04-05 Thread Enrico Forestieri
On Tue, Apr 05, 2011 at 10:38:01AM +0200, Jean-Marc Lasgouttes wrote: > Le 05/04/11 09:45, Vincent van Ravesteijn a écrit : > >It feels wrong that GuiErrorList has to know about specific insets and > >that it leads to a crash otherwise. > > > >Shouldn't this be part of the DocIterator/Cursor class

Re: r38251 - lyx-devel/trunk/src/frontends/qt4

2011-04-05 Thread Enrico Forestieri
On Tue, Apr 05, 2011 at 09:45:27AM +0200, Vincent van Ravesteijn wrote: > > >Modified: lyx-devel/trunk/src/frontends/qt4/GuiErrorList.cpp > >== > >+// Don't try to highlight the content of info insets > >+while (di

Re: r38251 - lyx-devel/trunk/src/frontends/qt4

2011-04-05 Thread Jean-Marc Lasgouttes
Le 05/04/11 09:45, Vincent van Ravesteijn a écrit : It feels wrong that GuiErrorList has to know about specific insets and that it leads to a crash otherwise. Shouldn't this be part of the DocIterator/Cursor class instead ? Still, it would probably need to ask Inset for some property rather than

Re: r38251 - lyx-devel/trunk/src/frontends/qt4

2011-04-05 Thread Vincent van Ravesteijn
Modified: lyx-devel/trunk/src/frontends/qt4/GuiErrorList.cpp == + // Don't try to highlight the content of info insets + while (dit.inset().lyxCode() == INFO_CODE) + dit.backwardPos(); + It fe