Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-03-02 Thread Richard Heck
On 03/01/2011 06:36 PM, Pavel Sanda wrote: Jean-Marc Lasgouttes wrote: Le 11/02/2011 00:10, Richard Heck a écrit : This gets called at the end of InsetText::read(), and because we are PassThru, all the params get reset to their defaults. Hence, no centering. I had a fix for that (easy enough)

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-03-01 Thread Richard Heck
On 03/01/2011 06:36 PM, Pavel Sanda wrote: Jean-Marc Lasgouttes wrote: Le 11/02/2011 00:10, Richard Heck a écrit : This gets called at the end of InsetText::read(), and because we are PassThru, all the params get reset to their defaults. Hence, no centering. I had a fix for that (easy enough)

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-03-01 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Le 11/02/2011 00:10, Richard Heck a écrit : >> This gets called at the end of InsetText::read(), and because we are >> PassThru, all the params get reset to their defaults. Hence, no centering. > > I had a fix for that (easy enough) and when I tried it... my file did n

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-02-18 Thread Jean-Marc Lasgouttes
Le 11/02/2011 00:10, Richard Heck a écrit : This gets called at the end of InsetText::read(), and because we are PassThru, all the params get reset to their defaults. Hence, no centering. I had a fix for that (easy enough) and when I tried it... my file did not compile. Naively, I though that

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-02-12 Thread Jean-Marc Lasgouttes
Le vendredi 11 février 2011, Richard Heck a écrit : > I would have taken a shot, but I'm not sure what we want to do. In > particular: Should PassThru layouts allow paragraph customization at all? It > seems kind of contrary to what they are. This would not prevent you from > centering stuff. P

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-02-11 Thread Richard Heck
On 02/11/2011 04:46 AM, Jean-Marc Lasgouttes wrote: Le 11/02/2011 00:10, Richard Heck a écrit : This gets called at the end of InsetText::read(), and because we are PassThru, all the params get reset to their defaults. Hence, no centering. So it is my fault :) Good catch. Now I have to unders

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-02-11 Thread Jean-Marc Lasgouttes
Le 11/02/2011 00:10, Richard Heck a écrit : This gets called at the end of InsetText::read(), and because we are PassThru, all the params get reset to their defaults. Hence, no centering. So it is my fault :) Good catch. Now I have to understand how we want to fix it. JMarc

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-02-10 Thread Richard Heck
On 02/10/2011 05:32 PM, Richard Heck wrote: On 02/10/2011 06:03 AM, Jean-Marc Lasgouttes wrote: Le 28/01/11 20:48, rgh...@lyx.org a écrit : Author: rgheck Date: Fri Jan 28 20:48:03 2011 New Revision: 37353 URL: http://www.lyx.org/trac/changeset/37353 Log: Fix lyx2lyx problem with sweave files

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-02-10 Thread Richard Heck
On 02/10/2011 06:03 AM, Jean-Marc Lasgouttes wrote: Le 28/01/11 20:48, rgh...@lyx.org a écrit : Author: rgheck Date: Fri Jan 28 20:48:03 2011 New Revision: 37353 URL: http://www.lyx.org/trac/changeset/37353 Log: Fix lyx2lyx problem with sweave files and ParBreakIsNewline. Richard, I was abou

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

2011-02-10 Thread Jean-Marc Lasgouttes
Le 28/01/11 20:48, rgh...@lyx.org a écrit : Author: rgheck Date: Fri Jan 28 20:48:03 2011 New Revision: 37353 URL: http://www.lyx.org/trac/changeset/37353 Log: Fix lyx2lyx problem with sweave files and ParBreakIsNewline. Richard, I was about to revert the workaround in sweave.lyx example file