Re: r35760 - lyx-devel/trunk/src/frontends/qt4

2010-10-21 Thread Vincent van Ravesteijn
Yes. Because paramstodialog made the status change to valid and enabled the restore button even when the user didn't change anything yet. Or we add the same "if" before bc.restore, or change buttoncontroller to offer the possibility to change some fields without changing its status. Op 21 okt 201

Re: r35760 - lyx-devel/trunk/src/frontends/qt4

2010-10-21 Thread RGH
On 10/21/2010 05:03 PM, Vincent van Ravesteijn wrote: On Thu, Oct 21, 2010 at 9:34 PM, Richard Heck wrote: On 10/21/2010 02:29 PM, Vincent van Ravesteijn wrote: This does not look ok. If the dialog is on the initial state, the restore button should not be enabled at all. I think the

Re: r35760 - lyx-devel/trunk/src/frontends/qt4

2010-10-21 Thread Vincent van Ravesteijn
On Thu, Oct 21, 2010 at 9:34 PM, Richard Heck wrote: > On 10/21/2010 02:29 PM, Vincent van Ravesteijn wrote: >> >> This does not look ok. If the dialog is on the initial state, the restore >> button should not be enabled at all. >> >> I think the dialog is erroneously is the initial state. >> > Pe

Re: r35760 - lyx-devel/trunk/src/frontends/qt4

2010-10-21 Thread Richard Heck
On 10/21/2010 02:29 PM, Vincent van Ravesteijn wrote: This does not look ok. If the dialog is on the initial state, the restore button should not be enabled at all. I think the dialog is erroneously is the initial state. Perhaps. It looks like restore() is being called twice. Once at the ver

Re: r35760 - lyx-devel/trunk/src/frontends/qt4

2010-10-21 Thread Vincent van Ravesteijn
This does not look ok. If the dialog is on the initial state, the restore button should not be enabled at all. I think the dialog is erroneously is the initial state. Op 21 okt 2010 20:25 schreef : Author: rgheck Date: Thu Oct 21 20:25:15 2010 New Revision: 35760 URL: http://www.lyx.org/trac/cha