Re: r34216 - lyx-devel/trunk/src/insets

2010-04-20 Thread Abdelrazak Younes
On 04/20/2010 11:12 AM, Vincent van Ravesteijn - TNW wrote: The problem was that I never expected that InsetInfo is a child class of InsetCollapsable. This feels wrong. We need something between InsetText and InsetCollapsable or we migrate the inset decoration to InsetText. Then

RE: r34216 - lyx-devel/trunk/src/insets

2010-04-20 Thread Vincent van Ravesteijn - TNW
>> The problem was that I never expected that InsetInfo >> is a child class of InsetCollapsable. This feels wrong. > > We need something between InsetText and InsetCollapsable > or we migrate the inset decoration to InsetText. Then > InsetCollapsable would just add tha abil

Re: r34216 - lyx-devel/trunk/src/insets

2010-04-20 Thread Abdelrazak Younes
On 04/20/2010 10:45 AM, Vincent van Ravesteijn - TNW wrote: The problem was that I never expected that InsetInfo is a child class of InsetCollapsable. This feels wrong. We need something between InsetText and InsetCollapsable or we migrate the inset decoration

RE: r34216 - lyx-devel/trunk/src/insets

2010-04-20 Thread Vincent van Ravesteijn - TNW
>>> The problem was that I never expected that InsetInfo is a child >>> class >>> > >>> of InsetCollapsable. This feels wrong. >>> >> We need something between InsetText and InsetCollapsable or we >> migrate the inset decoration to InsetText. Then InsetCollapsable >> would j

Re: r34216 - lyx-devel/trunk/src/insets

2010-04-20 Thread Abdelrazak Younes
On 04/20/2010 10:33 AM, Vincent van Ravesteijn - TNW wrote: The problem was that I never expected that InsetInfo is a child class of InsetCollapsable. This feels wrong. We need something between InsetText and InsetCollapsable or we migrate the inset decoration to InsetTe

RE: r34216 - lyx-devel/trunk/src/insets

2010-04-20 Thread Vincent van Ravesteijn - TNW
>> The problem was that I never expected that InsetInfo is a child class >> of InsetCollapsable. This feels wrong. > >We need something between InsetText and InsetCollapsable >or we migrate the inset decoration to InsetText. Then >InsetCollapsable would just add tha ability to collapse. > >Note

Re: r34216 - lyx-devel/trunk/src/insets

2010-04-20 Thread Abdelrazak Younes
On 04/19/2010 06:10 PM, Vincent van Ravesteijn wrote: Better(?) fix for bug #6659: InsetInfo context menu disabled unless cursor immediately in front. Much better indeed. Year, I was about to complain ;-) The problem was that I never expected that InsetInfo is a child class of InsetColla

Re: r34216 - lyx-devel/trunk/src/insets

2010-04-19 Thread Jean-Marc Lasgouttes
Le 19 avr. 10 à 21:39, rgheck a écrit : In a way, yes. But it's not clear what else it should be. Not InsetCommand, I wouldn't have thought. So it'd have to be a direct subclass of Inset, and I think Bo just wanted to reuse the drawing routines, etc, from InsetCollapsable. It could be a In

Re: r34216 - lyx-devel/trunk/src/insets

2010-04-19 Thread rgheck
On 04/19/2010 12:10 PM, Vincent van Ravesteijn wrote: Better(?) fix for bug #6659: InsetInfo context menu disabled unless cursor immediately in front. Much better indeed. Year, I was about to complain ;-) The problem was that I never expected that InsetInfo is a child class of InsetColla

Re: r34216 - lyx-devel/trunk/src/insets

2010-04-19 Thread Vincent van Ravesteijn
Better(?) fix for bug #6659: InsetInfo context menu disabled unless cursor immediately in front. Much better indeed. Year, I was about to complain ;-) The problem was that I never expected that InsetInfo is a child class of InsetCollapsable. This feels wrong. Vincent

Re: r34216 - lyx-devel/trunk/src/insets

2010-04-19 Thread Abdelrazak Younes
On 04/19/2010 01:47 AM, v...@lyx.org wrote: Author: vfr Date: Mon Apr 19 01:47:11 2010 New Revision: 34216 URL: http://www.lyx.org/trac/changeset/34216 Log: Better(?) fix for bug #6659: InsetInfo context menu disabled unless cursor immediately in front. Much better indeed. (see r34215 for