Re: r31433 - lyx-devel/trunk/src

2009-10-05 Thread Pavel Sanda
Abdelrazak Younes wrote: > Are you sure this is still the case? The idea is that GuiView will always > use the document Buffer even when called from the search pane. Please > verify. aha! :) you are right. pavel

Re: r31433 - lyx-devel/trunk/src

2009-10-05 Thread Abdelrazak Younes
Pavel Sanda wrote: Abdelrazak Younes wrote: if i do eg vc-update i will close and open the buffer again, so the old buffer/view is no more existing. In this case we close the buffer so that should stay in GuiView. We indeed need to do apply this LFUN to the document buffer only. B

Re: r31433 - lyx-devel/trunk/src

2009-10-04 Thread Pavel Sanda
Abdelrazak Younes wrote: >> if i do eg vc-update i will close and open the buffer again, so the old >> buffer/view is no more existing. >> > > In this case we close the buffer so that should stay in GuiView. We indeed > need to do apply this LFUN to the document buffer only. But GuiView knows

Re: r31433 - lyx-devel/trunk/src

2009-10-04 Thread Abdelrazak Younes
On 04/10/2009 23:44, Pavel Sanda wrote: Abdelrazak Younes wrote: LyXAction::NoInternal)) + return false; + switch (cmd.action) { Abdel, why is this not done also in guiview? Because all Buffer related LFUNs should either be in Buffer or in BufferVi

Re: r31433 - lyx-devel/trunk/src

2009-10-04 Thread Pavel Sanda
Abdelrazak Younes wrote: >>> LyXAction::NoInternal)) >>> + return false; >>> + >>> switch (cmd.action) { >>> >> >> Abdel, why is this not done also in guiview? >> > > Because all Buffer related LFUNs should either be in Buffer or in > BufferView... But maybe there are still

Re: r31433 - lyx-devel/trunk/src

2009-10-04 Thread Abdelrazak Younes
On 04/10/2009 13:15, Pavel Sanda wrote: you...@lyx.org wrote: Author: younes Date: Mon Sep 21 14:36:22 2009 New Revision: 31433 URL: http://www.lyx.org/trac/changeset/31433 Log: Introduce a new LyXAction property 'NoInternal' to take care of LFUNs that should not be applied to internal Buf

Re: r31433 - lyx-devel/trunk/src

2009-10-04 Thread Pavel Sanda
you...@lyx.org wrote: > Author: younes > Date: Mon Sep 21 14:36:22 2009 > New Revision: 31433 > URL: http://www.lyx.org/trac/changeset/31433 > > Log: > Introduce a new LyXAction property 'NoInternal' to take care of LFUNs that > should not be applied to internal Buffers and use that in BufferView