Jean-Marc Lasgouttes wrote:
Having looked at how these are used, of course you could change the
signature of either, but they are used to do very different things,
and they really make most sense as they are. I think. Changing the
former would just force the odocstringstream::str() call to the
Having looked at how these are used, of course you could change the
signature of either, but they are used to do very different things,
and they really make most sense as they are. I think. Changing the
former would just force the odocstringstream::str() call to the
client; changing the lat
rgheck wrote:
Jean-Marc Lasgouttes wrote:
rgheck writes:
So we have two different Inset*::getCaptionText methods with different
signatures? This looks ugly, I'd rather standardize on one.
I've changed the name to "getCaptionAsPlaintext()", which is what it
does.
And is it warranted to have
Jean-Marc Lasgouttes wrote:
rgheck writes:
So we have two different Inset*::getCaptionText methods with different
signatures? This looks ugly, I'd rather standardize on one.
I've changed the name to "getCaptionAsPlaintext()", which is what it does.
And is it warranted to ha
rgheck writes:
>> So we have two different Inset*::getCaptionText methods with different
>> signatures? This looks ugly, I'd rather standardize on one.
>>
> I've changed the name to "getCaptionAsPlaintext()", which is what it does.
And is it warranted to have one with strings and one with stre
Jean-Marc Lasgouttes wrote:
rgh...@lyx.org writes:
+docstring InsetCollapsable::getCaptionText(OutputParams const & runparams)
const
Is there a reason why this is in InsetCollapsable and not InsetText? It
would be a good thing to lean up in InsetCollapsable all the stuff that
is not
rgh...@lyx.org writes:
> +docstring InsetCollapsable::getCaptionText(OutputParams const & runparams)
> const
Is there a reason why this is in InsetCollapsable and not InsetText? It
would be a good thing to lean up in InsetCollapsable all the stuff that
is not related to collapsableness.
It (and
