Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-07 Thread Enrico Forestieri
On Tue, Apr 07, 2009 at 02:07:52AM +0200, Uwe Stöhr wrote: > Uwe Stöhr schrieb: > > >> You are doing it the wrong way, IMHO. You should introduce \cfracleft > >> and \cfracright in place of \cfracthree and give visual feedback for > >> the position of the numerator. > > > > I think that your s

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-07 Thread Abdelrazak Younes
Uwe Stöhr wrote: Abdelrazak Younes schrieb: I don't understand, what do you propose? This... not tested nor compiled... I understand now. But I think its a matter of taste. Well, it's matter of good taste ;-) Good taste in programming is something that you develop continuously, not somet

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
Abdelrazak Younes schrieb: I don't understand, what do you propose? This... not tested nor compiled... I understand now. But I think its a matter of taste. Having a void for every inset kind is doubling code but might lead to a better overview. I now cleaned up the code a bit and think it i

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
Uwe Stöhr schrieb: You are doing it the wrong way, IMHO. You should introduce \cfracleft and \cfracright in place of \cfracthree and give visual feedback for >> the position of the numerator. I think that your solution is more intuitive and I'll implement this instead the next days. I've n

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Abdelrazak Younes
Uwe Stöhr wrote: Abdelrazak Younes schrieb: As I said, I am not discussing the merging. I would just prefer many small methods instead of a big fat one. I don't understand, what do you propose? This... not tested nor compiled... Abdel. Index: insets/InsetBranch.cpp ===

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
Abdelrazak Younes schrieb: As I said, I am not discussing the merging. I would just prefer many small methods instead of a big fat one. I don't understand, what do you propose? regards Uwe

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Uwe Stöhr
> You are doing it the wrong way, IMHO. You should introduce \cfracleft and > \cfracright in place of \cfracthree and give visual feedback for the position > of the numerator. I agree with you but this would be a change in our philosophy of handling optional arguments. We for example already tre

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Enrico Forestieri
On Sun, Apr 05, 2009 at 09:52:54PM +0200, uwesto...@lyx.org wrote: > - support for the optional argument of \cfrac (cursor position still > needs to be fixed, see post in mailing list) You are doing it the wrong way, IMHO. You should introduce \cfracleft and \cfracright in place of \cfracthr

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-06 Thread Abdelrazak Younes
Uwe Stöhr wrote: > I am not criticizing the merge, perhaps this is needed and better but in effect you are replacing > many small functions by a single big fat one (metrics method I guess)... which is not so pretty. We already had the different fraction typed as kind of the InsetMathFraction

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-05 Thread Uwe Stöhr
> I am not criticizing the merge, perhaps this is needed and better but in effect you are replacing > many small functions by a single big fat one (metrics method I guess)... which is not so pretty. We already had the different fraction typed as kind of the InsetMathFraction inset, only the type

Re: r29114 - in lyx-devel/trunk: lib/ui src/mathed

2009-04-05 Thread Abdelrazak Younes
On 05/04/2009 21:52, uwesto...@lyx.org wrote: Author: uwestoehr Date: Sun Apr 5 21:52:53 2009 New Revision: 29114 URL: http://www.lyx.org/trac/changeset/29114 Log: major code cleanup for fractions: - InsetMathFrac.cpp/h: - InsetCFrac, InsetDFrac, and InsetTFrac are now included as kind of