Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > because i'm moron and write left instead of right. > try once again with the right mouse button. of course I did that, and I cannot reproduce the problems there either. Only the context menu opens, as expected. Jürgen

Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Pavel Sanda
> > also there is chaos on left button actions: > > e.g.: > > ert + left click collapses and open menu simultaneously. > > > > note + left click open both context menu and dialog. > > cannot reproduce. > Left click should not open the context menu whatsoever. because i'm moron and write left ins

Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > here cursor is not moved inside (tried with ert and note). right. Also not in 1.5. I stand corrected. > also there is chaos on left button actions: > e.g.: > ert + left click collapses and open menu simultaneously. > > note + left click open both context menu and dialog. can

Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Pavel Sanda
> Bo Peng wrote: > > Thank you for explaining this. I still do not know 'exactly' what > > LFUN_NEXT_INSET_TOGGLE is. If INSET_SETTINGS can do most of its work, > > maybe they should be merged. > > It toggles a collapsable at cursor position. If you are in front of a > collapsed index inset, for

Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Jürgen Spitzmüller
Bo Peng wrote: > It does work for InsetLabel and InsetRef, right? yes, amonst others. Jürgen

Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Bo Peng
> Now some people requested that this also works for non-collapsables such as > labels. They expect that if you press C-i in front of these, that they can > edit the contents as well (i.e. that the label dialog pops up). It does work for InsetLabel and InsetRef, right? Bo

Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Jürgen Spitzmüller
Bo Peng wrote: > Thank you for explaining this. I still do not know 'exactly' what > LFUN_NEXT_INSET_TOGGLE is. If INSET_SETTINGS can do most of its work, > maybe they should be merged. It toggles a collapsable at cursor position. If you are in front of a collapsed index inset, for instance, it w

Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Bo Peng
> Bo Peng wrote: > > Do we really need this > > Yes. Try to open the Listings (or any other collapsable) dialog via context > menu by pressing on the button: it is disabled (without my change). It is > only enabled if you pressed _inside_ the collapsable. > > > > since we can use LFUN_NEXT_INS

Re: [Cvslog] r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > because there's no more ERT dialog? > > yes, the doxy is wrong. anyway it doesn't work for note either. The documentation was wrong. BTW the ERT dialog is also superseded by the context menu. Jürgen

Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Jürgen Spitzmüller
Bo Peng wrote: > Do we really need this Yes. Try to open the Listings (or any other collapsable) dialog via context menu by pressing on the button: it is disabled (without my change). It is only enabled if you pressed _inside_ the collapsable. > since we can use LFUN_NEXT_INSET_TOGGLE for the

Re: [Cvslog] r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Pavel Sanda
> Pavel Sanda wrote: > > e.g inset-settings inside ert does nothing for me. > > because there's no more ERT dialog? yes, the doxy is wrong. anyway it doesn't work for note either. > > > also i would ask if this lfun shouldn't be used for uncollapsable insets? > > it will make much more sense th

Re: r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Bo Peng
On Mon, Mar 24, 2008 at 9:12 AM, <[EMAIL PROTECTED]> wrote: > Author: spitz > Date: Mon Mar 24 15:12:19 2008 > New Revision: 23923 > > URL: http://www.lyx.org/trac/changeset/23923 > Log: > * src/BufferView.cpp: > * src/Text3.cpp: > - fix LFUN_INSET_SETTINGS so that it also works at c

Re: [Cvslog] r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > e.g inset-settings inside ert does nothing for me. because there's no more ERT dialog? > also i would ask if this lfun shouldn't be used for uncollapsable insets? > it will make much more sense than next-inset-toggle. I would rather let inset-settings call next-inset-toggle,

Re: [Cvslog] r23923 - in /lyx-devel/trunk/src: BufferView.cpp LyXActio...

2008-03-24 Thread Pavel Sanda
> Author: spitz > Date: Mon Mar 24 15:12:19 2008 > New Revision: 23923 > > URL: http://www.lyx.org/trac/changeset/23923 > Log: > * src/BufferView.cpp: > * src/Text3.cpp: > - fix LFUN_INSET_SETTINGS so that it also works at cursor position. > > * LyXAction.cpp: > - doxy. > > /*! > *