Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Richard Heck
Andre Poenitz wrote: On Thu, Oct 25, 2007 at 04:47:17PM -0400, Richard Heck wrote: vitual CommandInfo const * findInfo(std::string const & cmdName) = 0; I didn't do that because it needs, at least in the base classes, to be static, and I wanted to indicate here that it needed to

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Andre Poenitz
On Thu, Oct 25, 2007 at 04:47:17PM -0400, Richard Heck wrote: > vitual CommandInfo const * findInfo(std::string const & cmdName) = 0; > >>>I didn't do that because it needs, at least in the base classes, to > >>>be static, and I wanted to indicate here that it needed to be > >>>implemented as

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Richard Heck
Richard Heck wrote: Andre Poenitz wrote: On Thu, Oct 25, 2007 at 09:26:31AM -0400, Richard Heck wrote: Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: + /// Return parameter information for command cmdName. + /// Not implemented here. Must be implemented in derived class. + static CommandIn

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Richard Heck
Andre Poenitz wrote: On Thu, Oct 25, 2007 at 09:26:31AM -0400, Richard Heck wrote: Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: +/// Return parameter information for command cmdName. +/// Not implemented here. Must be implemented in derived class. +static Comman

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Andre Poenitz
On Thu, Oct 25, 2007 at 09:26:31AM -0400, Richard Heck wrote: > Abdelrazak Younes wrote: > >[EMAIL PROTECTED] wrote: > >>+/// Return parameter information for command cmdName. > >>+/// Not implemented here. Must be implemented in derived class. > >>+static CommandInfo const * findInfo(s

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Richard Heck
Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: URL: http://www.lyx.org/trac/changeset/21194 +CommandInfo const * InsetBibitem::findInfo(std::string const & /* cmdName */) +{ +static const char * const paramnames[] = {"label", "key", ""}; +static const bool isoptional[] = {true, fals

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Richard Heck
Abdelrazak Younes wrote: Something like the attached, unfinished, patch Thanks for these ideas. They'll be useful. rh -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ =

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Richard Heck
Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: +/// Return parameter information for command cmdName. +/// Not implemented here. Must be implemented in derived class. +static CommandInfo const * findInfo(std::string const & cmdName); So make it pure virtual: vitual CommandInfo

Re: [Cvslog] r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Richard Heck
Andre Poenitz wrote: On Thu, Oct 25, 2007 at 04:13:58AM -, [EMAIL PROTECTED] wrote: +ICPInfo::ICPInfo(std::string const & s, bool b) + : paramName(s), optional(b) +{} + + +void ICPList::addParam(std::string const & s, bool b) { + plist_.push_back(ICPInfo(s, b)); +} + + +bool I

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-25 Thread Abdelrazak Younes
Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: Author: rgheck Date: Thu Oct 25 06:13:56 2007 New Revision: 21194 URL: http://www.lyx.org/trac/changeset/21194 Log: Move the findInfo() and defaultCommand() routines out of InsetCommand and into its subclasses, so that the subclasses know what

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-24 Thread Abdelrazak Younes
[EMAIL PROTECTED] wrote: Author: rgheck Date: Thu Oct 25 06:13:56 2007 New Revision: 21194 URL: http://www.lyx.org/trac/changeset/21194 Log: Move the findInfo() and defaultCommand() routines out of InsetCommand and into its subclasses, so that the subclasses know what parameters they want, etc.

Re: r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-24 Thread Abdelrazak Younes
[EMAIL PROTECTED] wrote: Author: rgheck Date: Thu Oct 25 06:13:56 2007 New Revision: 21194 URL: http://www.lyx.org/trac/changeset/21194 Log: Move the findInfo() and defaultCommand() routines out of InsetCommand and into its subclasses, so that the subclasses know what parameters they want, etc.

Re: [Cvslog] r21194 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2007-10-24 Thread Andre Poenitz
On Thu, Oct 25, 2007 at 04:13:58AM -, [EMAIL PROTECTED] wrote: > +ICPInfo::ICPInfo(std::string const & s, bool b) > + : paramName(s), optional(b) > +{} > + > + > +void ICPList::addParam(std::string const & s, bool b) { > + plist_.push_back(ICPInfo(s, b)); > +} > + > + > +bool ICPList::h