Re: r17276 - /lyx-devel/trunk/src/output_plaintext.C

2007-02-22 Thread Andre Poenitz
On Thu, Feb 22, 2007 at 02:36:45AM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Wed, Feb 21, 2007 at 10:19:57AM +0100, Lars Gullik Bjønnes wrote: > | > | if (runparams.linelen > 0 && > | > | currlinelen +

Re: r17276 - /lyx-devel/trunk/src/output_plaintext.C

2007-02-22 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | > But perhaps it should be possible to have this more complex than a | > simple comparison to ' '. | | In that case use a helper function. This might actually make sense in this | case, but your original comment loooked to me as if you would like an | is_s

Re: r17276 - /lyx-devel/trunk/src/output_plaintext.C

2007-02-22 Thread Georg Baum
Lars Gullik Bjønnes wrote: > Andre Poenitz > <[EMAIL PROTECTED]> > writes: > > | On Wed, Feb 21, 2007 at 10:19:57AM +0100, Lars Gullik Bjønnes wrote: > | > | if (runparams.linelen > 0 && > | > | currlinelen + word.length() > runparams.linelen) { > | > | os << '\n'; > | > > | > I wonder... it

Re: r17276 - /lyx-devel/trunk/src/output_plaintext.C

2007-02-21 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Feb 21, 2007 at 10:19:57AM +0100, Lars Gullik Bjønnes wrote: | > | if (runparams.linelen > 0 && | > | currlinelen + word.length() > runparams.linelen) { | > | os << '\n'; | > | >

Re: r17276 - /lyx-devel/trunk/src/output_plaintext.C

2007-02-21 Thread Andre Poenitz
On Wed, Feb 21, 2007 at 10:19:57AM +0100, Lars Gullik Bjønnes wrote: > | if (runparams.linelen > 0 && > | currlinelen + word.length() > runparams.linelen) { > | os << '\n'; > > I wonder... it is wise to compare ucs4 chars dire

Re: r17276 - /lyx-devel/trunk/src/output_plaintext.C

2007-02-21 Thread Georg Baum
Lars Gullik Bjønnes wrote: > I wonder... it is wise to compare ucs4 chars directly to chars? If the chars are in the ASCII range, then yes. This makes the code more readable, and at the very beginning of the unicode transition Andre complained that we could not use C strings for string comparison

Re: r17276 - /lyx-devel/trunk/src/output_plaintext.C

2007-02-21 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] writes: | Author: schmitt | Date: Tue Feb 20 18:56:55 2007 | New Revision: 17276 | | URL: http://www.lyx.org/trac/changeset/17276 | Log: | * src/output_plaintext.C: use InsetBase::PLAINTEXT_NEWLINE; refactor | some common code; remove obsolete comments | | Modified: