Re: qt4: floatplacement

2006-08-29 Thread Abdelrazak Younes
Andre Poenitz wrote: On Fri, Aug 25, 2006 at 02:37:58PM +0200, Abdelrazak Younes wrote: I don't know why there is this line in the UI file but I know for sure that Ui classes are _not_ QWidget; there are not even QObject. So this QWidget inheritance is the right thing to do: class FloatPl

Re: qt4: floatplacement

2006-08-29 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | I personally use the | | class FloatPlacement : public QWidget | { | private: | Ui::FloatPlacementUi * ui_; | } | | approach as this effectively pimpls away everything pulled in by the | ui_*.h files, but it requires an explict constructor. |

Re: qt4: floatplacement

2006-08-29 Thread Andre Poenitz
On Fri, Aug 25, 2006 at 02:37:58PM +0200, Abdelrazak Younes wrote: > I don't know why there is this line in the UI file but I know for sure > that Ui classes are _not_ QWidget; there are not even QObject. So this > QWidget inheritance is the right thing to do: > > class FloatPlacement : public

Re: qt4: floatplacement

2006-08-29 Thread Andre Poenitz
On Fri, Aug 25, 2006 at 01:23:16PM +0100, Angus Leeming wrote: > Edwin Leuven wrote: > >the attached patch fp.diff > > > >* implements the float widget as a .ui file > >* renames from floatplacement.[Ch] -> FloatPlacement.[Ch] > > > > > >compare.diff shows the differences between the two files > >

Re: qt4: floatplacement

2006-08-25 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Otherwise looks good except that you took the path of minimal effort ;-) No automatic slots, etc... added some autoslots, other suggestions? so many things to do, yet so little time No problem I was just teasing you. You got me used to redesign

Re: qt4: floatplacement

2006-08-25 Thread Edwin Leuven
Abdelrazak Younes wrote: Otherwise looks good except that you took the path of minimal effort ;-) No automatic slots, etc... added some autoslots, other suggestions? so many things to do, yet so little time will commit the attached... Index: src/frontends/qt4/QFloatDialog.C ==

Re: qt4: floatplacement

2006-08-25 Thread Abdelrazak Younes
Edwin Leuven wrote: Angus Leeming wrote: Given that FloatPlacementUi derives from QWidget: + FloatPlacementUi + I don't think FloatPlacement needs to derive directly from QWidget: -class FloatPlacement : public QWidget { +class FloatPlacement : public QWidget, public Ui::FloatPlacementUi {

Re: qt4: floatplacement

2006-08-25 Thread Abdelrazak Younes
Angus Leeming wrote: Edwin Leuven wrote: the attached patch fp.diff * implements the float widget as a .ui file * renames from floatplacement.[Ch] -> FloatPlacement.[Ch] compare.diff shows the differences between the two files If you'd used svn rename I think this diff would have come for f

Re: qt4: floatplacement

2006-08-25 Thread Edwin Leuven
Angus Leeming wrote: Given that FloatPlacementUi derives from QWidget: + FloatPlacementUi + I don't think FloatPlacement needs to derive directly from QWidget: -class FloatPlacement : public QWidget { +class FloatPlacement : public QWidget, public Ui::FloatPlacementUi { that's what i thought

Re: qt4: floatplacement

2006-08-25 Thread Angus Leeming
Edwin Leuven wrote: the attached patch fp.diff * implements the float widget as a .ui file * renames from floatplacement.[Ch] -> FloatPlacement.[Ch] compare.diff shows the differences between the two files comments welcome Given that FloatPlacementUi derives from QWidget: + FloatPlacementUi

qt4: floatplacement

2006-08-25 Thread Edwin Leuven
the attached patch fp.diff * implements the float widget as a .ui file * renames from floatplacement.[Ch] -> FloatPlacement.[Ch] compare.diff shows the differences between the two files comments welcome thanks, ed. Index: src/frontends/qt4/QFloatDialog.C =