Re: qt4: bullet support

2006-08-20 Thread Andre Poenitz
On Sun, Aug 13, 2006 at 04:08:43PM +0200, Edwin Leuven wrote: > well... > > 1. widget() returns a qwidget and i need qlistwidget > 2. http://doc.trolltech.com/4.1/qobject.html#qobject_cast > > wrt 2. i never know which cast to use, so guidance is appreciated > (probably should do some reading...

Re: qt4: bullet support

2006-08-20 Thread Andre Poenitz
On Sun, Aug 13, 2006 at 04:57:51PM +0200, Abdelrazak Younes wrote: > Angus Leeming wrote: > >Abdelrazak Younes <[EMAIL PROTECTED]> writes: > You might want to change "const XXX" into "XXX const" is you don't > want Lars to shout at you... > > > >>>i think i did that once with a slot in ord

Re: qt4: bullet support

2006-08-13 Thread Edwin Leuven
Abdelrazak Younes wrote: You migh want to improve readability by splitting the line with a declaration: QListWidget * lw = qobject_cast(bulletpaneSW->widget(current_font_)); lw->setItemSelected(current_item_, false); In this case, I think a C++ static_cast is sufficient. But qobject_cast seem

Re: qt4: bullet support

2006-08-13 Thread Edwin Leuven
Abdelrazak Younes wrote: But do you know if it's OK now with Qt4? I think I have tried both in the past without problems but I am not sure. What kind of trouble was that anyway? Crash, errors or silence? from what i remember the signal and slot just were not connected don't remember whether t

Re: qt4: bullet support

2006-08-13 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: You might want to change "const XXX" into "XXX const" is you don't want Lars to shout at you... i think i did that once with a slot in order to respect qt's convention, don't know whether that is necessary though... I think

Re: qt4: bullet support

2006-08-13 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >>> You might want to change "const XXX" into "XXX const" is you don't >>> want Lars to shout at you... >> i think i did that once with a slot in order to respect qt's convention, >> don't know whether that is necessary though... > I think it's not,

Re: qt4: bullet support

2006-08-13 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: You might want to change "const XXX" into "XXX const" is you don't want Lars to shout at you... i think i did that once with a slot in order to respect qt's convention, don't know whether that is necessary though... I think it's not, both convent

Re: qt4: bullet support

2006-08-13 Thread Edwin Leuven
Abdelrazak Younes wrote: You might want to change "const XXX" into "XXX const" is you don't want Lars to shout at you... i think i did that once with a slot in order to respect qt's convention, don't know whether that is necessary though... void BulletsModule::showLevel(int level) { if

Re: qt4: bullet support

2006-08-13 Thread Abdelrazak Younes
Edwin Leuven wrote: hi guys, attached patch adds qt4 support for bullets. i also add the bulletsmodule.c source file because the patch is rather unreadable (same file but different content) screenshot also attached. Looks nice ;-) will put this in tonight unless somebody shouts. commen