new compiler warning in master

2016-04-09 Thread Uwe Stöhr
Compiling current git master I get InsetSpace.cpp D:\LyXGit\Master\src\insets\InsetSeparator.cpp(213): warning C4244: '+=': conversion from 'double' to 'int', possible loss of data This was introduced by commit http://www.lyx.org/trac/changeset/d4ca8d74041094f623cc891a30b4dc537137431c/lyxgit

Re: new compiler warning in master

2016-03-05 Thread Jean-Marc Lasgouttes
Le 05/03/2016 18:51, Uwe Stöhr a écrit : Am 04.03.2016 um 22:08 schrieb Jean-Marc Lasgouttes: I can test it but what should I do to verify that it works? I think it is safe. Just confirm that the warnings are gone. I can confirmed that the warning is gone. +1 Great. I pushed it. JMarc

Re: new compiler warning in master

2016-03-05 Thread Uwe Stöhr
Am 04.03.2016 um 22:08 schrieb Jean-Marc Lasgouttes: I can test it but what should I do to verify that it works? I think it is safe. Just confirm that the warnings are gone. I can confirmed that the warning is gone. +1 thanks and regards Uwe

Re: new compiler warning in master

2016-03-04 Thread Jean-Marc Lasgouttes
Le 04/03/2016 01:21, Uwe Stöhr a écrit : Am 04.03.2016 um 00:26 schrieb Jean-Marc Lasgouttes: In the meantime I pushed (and then reverted) my patch by mistake. This fixed the warnings I got. What about this one? I can test it but what should I do to verify that it works? I think it is s

Re: new compiler warning in master

2016-03-04 Thread Enrico Forestieri
On Fri, Mar 04, 2016 at 12:26:11AM +0100, Jean-Marc Lasgouttes wrote: > Le 04/03/2016 00:14, Jean-Marc Lasgouttes a écrit : > >>>Nope. > >> > >>The attached patch does the trick for me. > > > >THe warnings you see are not the same as Uwe's warnings. > > In the meantime I pushed (and then reverted

Re: new compiler warning in master

2016-03-03 Thread Uwe Stöhr
Am 04.03.2016 um 00:26 schrieb Jean-Marc Lasgouttes: In the meantime I pushed (and then reverted) my patch by mistake. This fixed the warnings I got. What about this one? I can test it but what should I do to verify that it works? regards Uwe

Re: new compiler warning in master

2016-03-03 Thread Jean-Marc Lasgouttes
Le 04/03/2016 00:14, Jean-Marc Lasgouttes a écrit : Nope. The attached patch does the trick for me. THe warnings you see are not the same as Uwe's warnings. In the meantime I pushed (and then reverted) my patch by mistake. What about this one? JMarc >From 6aad5f2430d8bbeab1a0f5773aadd8

Re: new compiler warning in master

2016-03-03 Thread Jean-Marc Lasgouttes
Le 03/03/2016 23:14, Enrico Forestieri a écrit : On Thu, Mar 03, 2016 at 10:45:59PM +0100, Enrico Forestieri wrote: On Wed, Mar 02, 2016 at 11:50:01PM +0100, Jean-Marc Lasgouttes wrote: Le 28/02/2016 21:32, Uwe Stöhr a écrit : I recompiled LyX completely and get now this warning: ParagraphM

Re: new compiler warning in master

2016-03-03 Thread Enrico Forestieri
On Thu, Mar 03, 2016 at 10:45:59PM +0100, Enrico Forestieri wrote: > On Wed, Mar 02, 2016 at 11:50:01PM +0100, Jean-Marc Lasgouttes wrote: > > > Le 28/02/2016 21:32, Uwe Stöhr a écrit : > > >I recompiled LyX completely and get now this warning: > > > > > >ParagraphMetrics.cpp > > >D:\LyXGit\Maste

Re: new compiler warning in master

2016-03-03 Thread Enrico Forestieri
On Wed, Mar 02, 2016 at 11:50:01PM +0100, Jean-Marc Lasgouttes wrote: > Le 28/02/2016 21:32, Uwe Stöhr a écrit : > >I recompiled LyX completely and get now this warning: > > > >ParagraphMetrics.cpp > >D:\LyXGit\Master\src\ParagraphMetrics.cpp(108): warning C4838: > >conversion from 'const int' to

Re: new compiler warning in master

2016-03-02 Thread Jean-Marc Lasgouttes
Le 28/02/2016 21:32, Uwe Stöhr a écrit : I recompiled LyX completely and get now this warning: ParagraphMetrics.cpp D:\LyXGit\Master\src\ParagraphMetrics.cpp(108): warning C4838: conversion from 'const int' to 'const lyx::char_type' requires a narrowing conversion I think the following patch f

Re: new compiler warning in master

2016-02-29 Thread Jean-Marc Lasgouttes
Le 28/02/16 21:32, Uwe Stöhr a écrit : I recompiled LyX completely and get now this warning: ParagraphMetrics.cpp D:\LyXGit\Master\src\ParagraphMetrics.cpp(108): warning C4838: conversion from 'const int' to 'const lyx::char_type' requires a narrowing conversion I see the problem indeed. I'll

new compiler warning in master

2016-02-28 Thread Uwe Stöhr
I recompiled LyX completely and get now this warning: ParagraphMetrics.cpp D:\LyXGit\Master\src\ParagraphMetrics.cpp(108): warning C4838: conversion from 'const int' to 'const lyx::char_type' requires a narrowing conversion regards Uwe