Re: mvc paragraph dialog

2002-05-21 Thread Edwin Leuven
new patch... greets, Ed. mvcpar2.diff.gz Description: GNU Zip compressed data

Re: mvc paragraph dialog

2002-05-21 Thread Angus Leeming
On Monday 20 May 2002 8:27 pm, Edwin Leuven wrote: > > Ed, why have you given the controller all these set/get methods? Wouldn't > > it have been easier to just provide > > > > ParagraphParameters & ControlParagraph::params() > > { > > lyx::Assert(pp_.get()); > > return *pp_; > > } > > > >

Re: mvc paragraph dialog

2002-05-20 Thread Edwin Leuven
> Ed, why have you given the controller all these set/get methods? Wouldn't > it have been easier to just provide > > ParagraphParameters & ControlParagraph::params() > { > lyx::Assert(pp_.get()); > return *pp_; > } > > Or am I mising something? I actually thought about doing that but

Re: mvc paragraph dialog

2002-05-20 Thread Angus Leeming
On Sunday 19 May 2002 2:43 pm, Edwin Leuven wrote: > I had a go at reworking the paragraph dialog to MVC. I attach what I have > now. It seems to work, but perhaps someone (Angus?) could have a look at it > so that it may go in after 1.2. > > Thanks, Ed. Ed, why have you given the controller all

Re: mvc paragraph dialog

2002-05-20 Thread Angus Leeming
On Sunday 19 May 2002 2:43 pm, Edwin Leuven wrote: > I had a go at reworking the paragraph dialog to MVC. I attach what I have > now. It seems to work, but perhaps someone (Angus?) could have a look at it > so that it may go in after 1.2. > > Thanks, Ed. TOP effort Edwin. I'll most certainly have

mvc paragraph dialog

2002-05-19 Thread Edwin Leuven
I had a go at reworking the paragraph dialog to MVC. I attach what I have now. It seems to work, but perhaps someone (Angus?) could have a look at it so that it may go in after 1.2. Thanks, Ed. mvcpar.dif.gz Description: GNU Zip compressed data