Re: make check fails

2009-01-16 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > ok i changed it to the real number with not problematic binary expansion > after decimal point. Clever. JMarc

Re: make check fails

2009-01-15 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Testing the exact representation of a real number is asking for this > kind of instability. If we were testing a conversion with a given (not > too large) precision, that would be OK. > > I am not sure what to do, besides dropping the test. ok i changed it to the rea

Re: make check fails

2009-01-15 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: >> I think this test is wrong. I am not sure how to make such a thing >> work... > > hmm i thought this test means that there was a day when > convert(1.1) actually returned 1.1 and this test just shows > there was some change underneath... > > i'm not sure whether we handle fo

Re: make check fails

2009-01-14 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Pavel Sanda writes: > > > hi, > > > > make check now fails for lyx-1.6. > > test_convert now returns > > 1.1001 instead of 1.1 for convert(1.1) > > > > what should be the correct return? > > I think this test is wrong. I am not sure how to make such a th

Re: make check fails

2009-01-14 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > hi, > > make check now fails for lyx-1.6. > test_convert now returns > 1.1001 instead of 1.1 for convert(1.1) > > what should be the correct return? I think this test is wrong. I am not sure how to make such a thing work... JMarc

make check fails

2009-01-13 Thread Pavel Sanda
hi, make check now fails for lyx-1.6. test_convert now returns 1.1001 instead of 1.1 for convert(1.1) what should be the correct return? pavel