John Levon wrote:
> On Thu, Apr 03, 2003 at 09:17:10AM +, Angus Leeming wrote:
>
>> src/lfuns.h:LFUN_INSET_DIALOG_UPDATE,
>
> This one, insetcommand.C:localDispatch()
LFUN_INSET : operates on an inset
DIALOG_UPDATE : guess what ;-}
> Actually I was kind of hoping you'd be able to say o
On Thu, Apr 03, 2003 at 09:17:10AM +, Angus Leeming wrote:
> src/lfuns.h:LFUN_INSET_DIALOG_UPDATE,
This one, insetcommand.C:localDispatch()
john
On Wednesday 02 April 2003 10:02 pm, John Levon wrote:
> On Wed, Apr 02, 2003 at 08:36:59AM +, Angus Leeming wrote:
> > > Angus, what about INSET_UPDATE ? Looks like it's needed there too ?
> >
> > Feel free. I am watching and learning.
>
> Actually I was kind of hoping you'd be able to say one
On Wed, Apr 02, 2003 at 08:36:59AM +, Angus Leeming wrote:
> > Angus, what about INSET_UPDATE ? Looks like it's needed there too ?
>
> Feel free. I am watching and learning.
Actually I was kind of hoping you'd be able to say one way or the other.
What does the lfun do, and what are the conse
John Levon wrote:
>> @@ -90,6 +90,7 @@ dispatch_result InsetCommand::localDispa
>>
>> case LFUN_MOUSE_RELEASE:
>> edit(cmd.view(), cmd.x, cmd.y, cmd.button());
>> + result = DISPATCHED;
>> break;
>
> Angus, what about INSET_UPDATE ? Looks lik
On Tue, Apr 01, 2003 at 08:06:08PM +0200, Alfredo Braunstein wrote:
> This IMO is a separate bug on insetcommand's localDispatch (the other one
> was general to all !isHiglyEditables), and can be solved by this:
All works for me now, applied
thanks
john
On Tue, Apr 01, 2003 at 08:06:08PM +0200, Alfredo Braunstein wrote:
> Do you agree? Alfredo
Yes, looks dubious. Testing now.
> --- insetcommand.C 2003/03/19 14:45:19 1.65
> +++ insetcommand.C 2003/04/01 18:02:39
> @@ -90,6 +90,7 @@ dispatch_result InsetCommand::localDispa
>
>
John Levon wrote:
> The patch re-introduces the "click on url in minipage gets both minipage
> and url dialogs" bug...
This IMO is a separate bug on insetcommand's localDispatch (the other one
was general to all !isHiglyEditables), and can be solved by this:
Do you agree? Alfredo
Index: insetco
On Mon, Mar 31, 2003 at 09:20:04AM +0200, Alfredo Braunstein wrote:
> Given that noone commented this patch, let me add that I think it's the
> right way to go, because IMHO:
The patch re-introduces the "click on url in minipage gets both minipage
and url dialogs" bug...
regards
john
On Sun, Mar 30, 2003 at 01:35:18AM +0100, Alfredo Braunstein wrote:
> Can you try this? I've put inside #if 0 the code that make local the
> mouseclick position before calling edit or localDispatch on a
> !isHiglyEditable() child inset, and added a simple localdispatch for
> insetbuttons that call
Alfredo Braunstein wrote:
> John Levon wrote:
>
>> is the cause of the fact that you cannot right-click on a collapsed
>> minipage inside a float and get the dialog any more. Alfredo, could you
>> please have a quick look ?
Given that noone commented this patch, let me add that I think it's the
John Levon wrote:
> is the cause of the fact that you cannot right-click on a collapsed
> minipage inside a float and get the dialog any more. Alfredo, could you
> please have a quick look ?
Can you try this? I've put inside #if 0 the code that make local the
mouseclick position before calling e
Alfredo Braunstein wrote:
>> This inter-inset mouse handling is SOOO horrendous.
>
> I think that this is because some insets don't have a localDispatch() and
> there is special case code to call edit() on them.
Sorry, you are 100% right. This is a mess. Some insets have the coordinates
of the c
John Levon wrote:
> is the cause of the fact that you cannot right-click on a collapsed
> minipage inside a float and get the dialog any more. Alfredo, could you
> please have a quick look ?
Yes, it seems so. As I've added in a comment that time, IMO the right
solution is to re add the call to in
I'm not positive but I suspect that :
2002-12-17 Alfredo Braunstein <[EMAIL PROTECTED]>
* insettext.C (lfunMouseRelease): hackish solution to the
* "double
menu open" bug
is the cause of the fact that you cannot right-click on a collapsed
minipage inside a float and ge
On 03-Jul-2001 Lars Gullik Bjønnes wrote:
> I belive that an
>
> lyx::Assert(pointer);
>
> should be added to all methods that take a pointer as arg and that
> require this pointer to be != 0.
Well yes I just think that in your case the pointer can only be NULL
if we run out of memory, isn't
Juergen Vigna <[EMAIL PROTECTED]> writes:
| On 02-Jul-2001 Lars Gullik Bjønnes wrote:
|
| >| I'l like this patch to go in, Jürgen.
|
| Go for it please all I see seems very resonable!
|
| >| +if (!recursive && (cached_bview == lbv))
| >| return cached_text;
| >
| > should rea
On 02-Jul-2001 Lars Gullik Bjønnes wrote:
>| I'l like this patch to go in, Jürgen.
Go for it please all I see seems very resonable!
>| +if (!recursive && (cached_bview == lbv))
>| return cached_text;
>
> should really not be needed to check cached_bview for != 0, we are
> jus
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| I'l like this patch to go in, Jürgen.
|
| ? build
| Index: src/insets/insettext.C
| ===
| RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insettext.C,v
| retrieving revision 1.
19 matches
Mail list logo
