Re: inset-toggle

2009-06-01 Thread Jean-Marc Lasgouttes
Le 01/06/2009 21:33, Vincent van Ravesteijn a écrit : I don't see this. The only strange thing is that when closing the note inset with inset-toggle, the cursor jumps behind the note inset. Toggling now will indeed toggle the float. This is intended, in the sense that there is explicit co

Re: inset-toggle

2009-06-01 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > I don't see this. huh, now i cant reproduce it either. only calling inset-toggle from minibuffer bring the problem back. maybe i had the cursor behind the inset previously and overlooked... pavel

Re: inset-toggle

2009-06-01 Thread Vincent van Ravesteijn
Pavel Sanda schreef: JMarc, when i do ctrl+i just ahead of the note inside some float the float is toggled and not the note inset. this is intended behaviour or a bug? pavel I don't see this. The only strange thing is that when closing the note inset with inset-toggle, the cursor

inset-toggle

2009-06-01 Thread Pavel Sanda
JMarc, when i do ctrl+i just ahead of the note inside some float the float is toggled and not the note inset. this is intended behaviour or a bug? pavel

Re: Handling of inset-settins and inset-toggle

2009-04-10 Thread Vincent van Ravesteijn
Definitely. You may want to experiment with the new AtPoint LyXAction flag. Done. Some other points: 1. The Inset::edit functions should not be implemented other than for InsetCollapsables (which are editable). 2. LFUN_MOUSE_RELEASE of insets should dispatch an LFUN_INSET_SETTINGS (for

Re: Handling of inset-settins and inset-toggle

2009-04-09 Thread rgheck
Jean-Marc Lasgouttes wrote: 1. If an LFUN_INSET_TOGGLE is send to an InsetCommand, the settings dialog is shown. Wouldn't it make more sense to dispatch an LFUN_INSET_SETTINGS instead ? Actually, I would remove this possibility for inset-toggle to open a dialog, and find a conve

Re: Handling of inset-settins and inset-toggle

2009-04-09 Thread Vincent van Ravesteijn
Jean-Marc Lasgouttes schreef: 1. If an LFUN_INSET_TOGGLE is send to an InsetCommand, the settings dialog is shown. Wouldn't it make more sense to dispatch an LFUN_INSET_SETTINGS instead ? Actually, I would remove this possibility for inset-toggle to open a dialog, and find a conve

Re: Handling of inset-settins and inset-toggle

2009-04-09 Thread Jean-Marc Lasgouttes
1. If an LFUN_INSET_TOGGLE is send to an InsetCommand, the settings dialog is shown. Wouldn't it make more sense to dispatch an LFUN_INSET_SETTINGS instead ? Actually, I would remove this possibility for inset-toggle to open a dialog, and find a convenient shortcut for inset-se

Re: Handling of inset-settins and inset-toggle

2009-04-09 Thread Abdelrazak Younes
On 09/04/2009 19:44, Vincent van Ravesteijn wrote: Hi all, I have some questions on de handling of LFUN_INSET_TOGGLE / SETTINGS. 1. If an LFUN_INSET_TOGGLE is send to an InsetCommand, the settings dialog is shown. Wouldn't it make more sense to dispatch an LFUN_INSET_SETTINGS instead ? yes.

Handling of inset-settins and inset-toggle

2009-04-09 Thread Vincent van Ravesteijn
Hi all, I have some questions on de handling of LFUN_INSET_TOGGLE / SETTINGS. 1. If an LFUN_INSET_TOGGLE is send to an InsetCommand, the settings dialog is shown. Wouldn't it make more sense to dispatch an LFUN_INSET_SETTINGS instead ? 2. the status of LFUN_INSET_SETTINGS is handled by Buff

Re: next-inset-toggle problem

2008-03-24 Thread Jürgen Spitzmüller
rgheck wrote: > In any event, the attached patch fixes the Ctrl-I problem. It also > addresses what looks like it would be a similar problem in the mouse > handling code. Comments, anyone? While I was at fixing the context menu stuff, I fixed this one as well (albeit a bit differently). Jürgen

next-inset-toggle problem

2008-03-24 Thread rgheck
Jürgen Spitzmüller wrote: rgheck wrote: Which behavior do you mean? Opening Editable (not HIGHLY_EDITABLE) inset's dialog with C-i. My puzzlement concerns why Ctrl-I works to collapse (say) ERT that the cursor is inside in 1.5 but not in current trunk. Ah, then we are tal

Re: [patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> The attached patch fixes it for Bennett and me. Martin cannot Jürgen> remeber why he put the removed test there in the first place, Jürgen> but I didn't find any drawbacks. Looks good. JMarc

Re: [patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Martin Vermeer
On Sun, Jun 10, 2007 at 12:05:47PM +0200, Jürgen Spitzmüller wrote: > Martin Vermeer wrote: > > Did you try save/reload to see if only branch insets for > > the selected branch(es) are open? (vague recollection) > > Yes. This still works. Great. Then I suspect I did unthinking cut'n paste from so

Re: [patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Jürgen Spitzmüller
Martin Vermeer wrote: > Did you try save/reload to see if only branch insets for > the selected branch(es) are open? (vague recollection) Yes. This still works. Jürgen

Re: [patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Martin Vermeer
On Sun, Jun 10, 2007 at 09:31:19AM +0200, Jürgen Spitzmüller wrote: > The attached patch fixes it for Bennett and me. Martin cannot remeber why he > put the removed test there in the first place, but I didn't find any > drawbacks. > > OK? > > Jürgen Did you try save/reload to see if only branc

[patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Jürgen Spitzmüller
The attached patch fixes it for Bennett and me. Martin cannot remeber why he put the removed test there in the first place, but I didn't find any drawbacks. OK? Jürgen Index: src/insets/InsetBranch.cpp === --- src/insets/InsetBranc

Re: [patch] bug 2756: LyX crashes on next-inset-toggle in math-mode

2006-08-10 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > OK, try this new version instead. I undid the simplifications to the > code, since they were wrong %-] So now the code for > LFUN_NEXT_INSET_TOGGLE is basically moved as is to BufferView::Pimpl. It seems to work as expected. I don't get the console output anymore, and

Re: [patch] bug 2756: LyX crashes on next-inset-toggle in math-mode

2006-08-09 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> Please test. Juergen> Seems to work. However, LyX crashed two times on me while Juergen> testing this. I'm not sure it is related, and I couldn't Juergen> reproduce it, unfortunately. Juer

Re: [patch] bug 2756: LyX crashes on next-inset-toggle in math-mode

2006-08-09 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > It would be nice to know whether it is related to the patch. Yes. > Juergen> Also I get the debug output: I don't have a cell 1 > > Juergen> When I hit C-i in the outermost math inset. > > I cannot reproduce this. Details? - New document. - C-m - type "123" - move c

Re: [patch] bug 2756: LyX crashes on next-inset-toggle in math-mode

2006-08-09 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> Please test. Juergen> Seems to work. However, LyX crashed two times on me while Juergen> testing this. I'm not sure it is related, and I couldn't Juergen> reproduce it, unfortunately. It w

Re: [patch] bug 2756: LyX crashes on next-inset-toggle in math-mode

2006-08-09 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Please test. Seems to work. However, LyX crashed two times on me while testing this. I'm not sure it is related, and I couldn't reproduce it, unfortunately. Also I get the debug output: I don't have a cell 1 When I hit C-i in the outermost math inset. Jürgen

Re: [patch] bug 2756: LyX crashes on next-inset-toggle in math-mode

2006-08-09 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=2756 I'm not sure Juergen> what LFUN_INSET_TOGGLE in mathed is actually supposed to do, Juergen> but the attached patch (against 1.4) fixes the reported Juergen> assert. It checks w

[patch] bug 2756: LyX crashes on next-inset-toggle in math-mode

2006-08-09 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=2756 I'm not sure what LFUN_INSET_TOGGLE in mathed is actually supposed to do, but the attached patch (against 1.4) fixes the reported assert. It checks whether the cursor has left mathed before trying to get the cell inset. OK for branch and trunk? Jürg

inset-toggle

2001-08-02 Thread John Levon
can this work whilst locked in an inset ? I'd like to unlock the inset and deposit the cursor to the left ... thanks john -- "They didn't know what the symbols and paradoxes meant. Instead of following the finger that points to the moon, they sat down and worshipped the finger itself. Instea