Re: findreplace patch

2001-03-06 Thread Juergen Vigna
On 06-Mar-2001 Lars Gullik Bjønnes wrote: > Ad Jürgen's segfault report, I think there is a mistake in the code > somewhere, but I can't see it offhand. I belive the reason Jürgen sees The segfault wasn't a segfault, but an Assert(false) (I traced this down and could so find the error) and was

Re: findreplace patch

2001-03-06 Thread Jean-Marc Lasgouttes
> "Edwin" == Edwin Leuven <[EMAIL PROTECTED]> writes: Edwin> Should I resubmit the patch with these expression chopped up in Edwin> pieces? The patch is applied already, but you can submit a cleanup patch. JMarc

Re: findreplace patch

2001-03-06 Thread Edwin Leuven
> > No no... that you put parantesis around _obvious_ expressions. btw. > > You got me #:O) (big smile) > > > I'd like to see the above while condition rewritten. It way to large > > and complex. Should I resubmit the patch with these expression chopped up in pieces? gr.ed.

Re: findreplace patch

2001-03-06 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | Hi, | | I attach the patch that moves find/replace to frontends. It also moves some | stuff out ouf LyXText. The files src/lyxfr1.[Ch] and src/lyxfr0.[Ch] can be | removed. Could someone check and/or apply it? + + bool found; + do { + bv->

Re: findreplace patch

2001-03-06 Thread Juergen Vigna
On 06-Mar-2001 Lars Gullik Bjønnes wrote: > No no... that you put parantesis around _obvious_ expressions. btw. You got me #:O) (big smile) > I'd like to see the above while condition rewritten. It way to large > and complex. Well we have to rewrite quite a bit in there to permit f&r also ins

Re: findreplace patch

2001-03-06 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 05-Mar-2001 Edwin Leuven wrote: | | > Which would mean that it happens here: | > | > while (pos + i < par->Last() | >&& string::size_type(i) < size | >&& cs ? str[i] == par->GetChar(pos + i) | >

Re: findreplace patch

2001-03-06 Thread Juergen Vigna
On 05-Mar-2001 Edwin Leuven wrote: > Which would mean that it happens here: > > while (pos + i < par->Last() >&& string::size_type(i) < size >&& cs ? str[i] == par->GetChar(pos + i) >: toupper(str[i]) == toupper(par->GetChar(pos + i))) {

Re: findreplace patch

2001-03-05 Thread Edwin Leuven
> Well I tried the patch here and got a segfault on search. > Here is the backtrace: > > I can reproduce this as often as I want. I just have to press 2 or 3 > times the ">" button with the same searchstring then I'll get this! > That's strange. I don't have this. Apparantly (correct me if I'm w

Re: findreplace patch

2001-03-05 Thread Juergen Vigna
On 05-Mar-2001 Edwin Leuven wrote: > > Whatever you want, I can also add "itive" to make it "casesensitive". You > want a new patch, or is it ok as is for the moment? Ed. Well I tried the patch here and got a segfault on search. Here is the backtrace: (gdb) bt #0 0x401b2a21 in __kill () from

Re: findreplace patch

2001-03-05 Thread Edwin Leuven
> > + bool const & casesens, > > peculiar spelling... wouldn't "caseness" be better? > Whatever you want, I can also add "itive" to make it "casesensitive". You want a new patch, or is it ok as is for the moment? Ed.

Re: findreplace patch

2001-03-05 Thread Angus Leeming
On Monday 05 March 2001 10:44, Lars Gullik Bjønnes wrote: > | One small point. Launching the copyright dialog, I see that the program is > | now called KLyX > > yes, remove that... Done. A

Re: findreplace patch

2001-03-05 Thread John Levon
On Mon, 5 Mar 2001, Angus Leeming wrote: > I see that Lars has beaten me to it and committed this patch. I'd just report > that it compiles on my box, so I think the configure test should be changed > to #if (QT_VERSION < 221) at least. I changed this. Hmm. Ah yes ... I see what's gone on I t

Re: findreplace patch

2001-03-05 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | Hi, | | I attach the patch that moves find/replace to frontends. It also moves some | stuff out ouf LyXText. The files src/lyxfr1.[Ch] and src/lyxfr0.[Ch] can be | removed. Could someone check and/or apply it? | | Thanks for your help. +

Re: findreplace patch

2001-03-05 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Monday 05 March 2001 10:21, Angus Leeming wrote: | > On Monday 05 March 2001 09:36, Edwin Leuven wrote: | > | > > > Hi, | > > | > > ps. could someone apply the qt2 character patch? | > | > Ed, | > | > I thought I'd try and compile it, but config

Re: findreplace patch

2001-03-05 Thread Angus Leeming
On Monday 05 March 2001 10:21, Angus Leeming wrote: > On Monday 05 March 2001 09:36, Edwin Leuven wrote: > > > > Hi, > > > > ps. could someone apply the qt2 character patch? > > Ed, > > I thought I'd try and compile it, but configure fails because I have qt 2.2.1 > here and configure looks

Re: findreplace patch

2001-03-05 Thread Angus Leeming
On Monday 05 March 2001 09:36, Edwin Leuven wrote: > > Hi, > > ps. could someone apply the qt2 character patch? Ed, I thought I'd try and compile it, but configure fails because I have qt 2.2.1 here and configure looks for 2.2.3. Is this really needed or will I still be able to compile. fr

findreplace patch

2001-03-05 Thread Edwin Leuven
Hi, I attach the patch that moves find/replace to frontends. It also moves some stuff out ouf LyXText. The files src/lyxfr1.[Ch] and src/lyxfr0.[Ch] can be removed. Could someone check and/or apply it? Thanks for your help. Greetings, Ed. ps. could someone apply the qt2 character patch? ht

RE: question about findreplace

2001-03-01 Thread Juergen Vigna
On 01-Mar-2001 Edwin Leuven wrote: > Hi, > > I am currently looking at the find/replace code the functional part of which > is located in lyxfr1.[Ch]. It defines a LyXFindReplace class which has as > private members a bufferview and a search form. I do not have the impression > that this is v

question about findreplace

2001-03-01 Thread Edwin Leuven
Hi, I am currently looking at the find/replace code the functional part of which is located in lyxfr1.[Ch]. It defines a LyXFindReplace class which has as private members a bufferview and a search form. I do not have the impression that this is very convenient from the point of view of guii. I

Re: Fwd: Re: findreplace

2001-02-27 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | > Ok, but where is the combox deleted then? | > | > every "new" must have a "delete". | > | > And why have this as a pointer in FormCharacter? It seems that it | > could just be a regular object. | | Sorry guys, I am out of silly `solutions', it is time

Re: Fwd: Re: findreplace

2001-02-27 Thread Edwin Leuven
> Ok, but where is the combox deleted then? > > every "new" must have a "delete". > > And why have this as a pointer in FormCharacter? It seems that it > could just be a regular object. Sorry guys, I am out of silly `solutions', it is time for Combox-man or xform-man to save the world...Ed.

Re: Fwd: Re: findreplace

2001-02-27 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | Hi, | | I think that the problem in the character form is the following: | | I thought that Combox was a native xforms object but it is in fact a class | defined/declared in ./src/combox.[Ch]. This class takes care of the | destruction of the Combox.

Re: Fwd: Re: findreplace

2001-02-27 Thread Angus Leeming
On Tuesday 27 February 2001 08:47, Edwin Leuven wrote: > > Hi, > > I think that the problem in the character form is the following: > > I thought that Combox was a native xforms object but it is in fact a class > defined/declared in ./src/combox.[Ch]. This class takes care of the > destructio

Fwd: Re: findreplace

2001-02-27 Thread Edwin Leuven
Hi, I think that the problem in the character form is the following: I thought that Combox was a native xforms object but it is in fact a class defined/declared in ./src/combox.[Ch]. This class takes care of the destruction of the Combox. The delete Combox in the destructor in FormCharacter s

Re: findreplace

2001-02-26 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | ps. did someone find the time to apply the character patch? I'll do it now. Lgb

Re: findreplace

2001-02-26 Thread Edwin Leuven
> I would say "go for it", your doing a really good job :) Thanks, that's nice to hear. gr.ed. ps. did someone find the time to apply the character patch? http://www.mail-archive.com/lyx-devel%40lists.lyx.org/msg19726.html

RE: findreplace

2001-02-26 Thread Juergen Vigna
On 25-Feb-2001 Edwin Leuven wrote: > Hi, I thought I'd might try moving findreplace to frontends. If this is not > taken and no one objects, could someone mark it pending in the guii matrix? > Any a priori thoughts on this (like: Ed, make sure to do...)? I would say "go fo

findreplace

2001-02-25 Thread Edwin Leuven
Hi, I thought I'd might try moving findreplace to frontends. If this is not taken and no one objects, could someone mark it pending in the guii matrix? Any a priori thoughts on this (like: Ed, make sure to do...)? Thank you, gr.ed.