On Sun, Aug 26, 2007 at 03:46:51PM +0300, Martin Vermeer wrote:
> Rather trivial actually. See attached.
Nice.
Andre'
On Sun, Aug 26, 2007 at 12:17:56PM -0400, Richard Heck wrote:
>
> It just keeps getting better and better
>
> Richard
Yes, and what I like is that the LOC count goes down all the time...
This is code that I worked on earlier so it is familiar (and I see how
clumsy I was a couple years ago)
It just keeps getting better and better
Richard
Martin Vermeer wrote:
Rather trivial actually. See attached.
- Martin
Index: src/TextClass.cpp
===
Rather trivial actually. See attached.
- Martin
Index: src/TextClass.cpp
===
--- src/TextClass.cpp (revision 19790)
+++ src/TextClass.cpp (working copy)
@@ -598,6 +598,7 @@
enum InsetLayoutTags {
IL_FONT = 1,
+ I
Jean-Marc Lasgouttes wrote:
>>>>>> "Juergen" == Juergen Spitzmueller
>>>>>> <[EMAIL PROTECTED]> writes:
>
> Juergen> Alfredo Braunstein wrote:
>>> This is quick implementation of a long-standing feature request:
>>>
>>>>> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Alfredo Braunstein wrote:
>> This is quick implementation of a long-standing feature request:
>> autoopening/closing collapsables.
Juergen> What is the difference to the
Alfredo Braunstein wrote:
> This is quick implementation of a long-standing feature request:
> autoopening/closing collapsables.
What is the difference to the LFUN ALL_INSETS_TOGGLE, which Angus has
implemented?
If it would be that insets would be closed again after f&r or spellcheckin
Lars Gullik BjÃnnes wrote:
> Alfredo Braunstein <[EMAIL PROTECTED]> writes:
>
> | This is quick implementation of a long-standing feature request:
> | autoopening/closing collapsables. This is really easy with the new
> | scheme (most of this patch is a replace of status_ -&
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| This is quick implementation of a long-standing feature request:
| autoopening/closing collapsables. This is really easy with the new scheme
| (most of this patch is a replace of status_ -> status())
No no no :-)
We had that and we r
This is quick implementation of a long-standing feature request:
autoopening/closing collapsables. This is really easy with the new scheme
(most of this patch is a replace of status_ -> status())
On a side note, we should keep the following tree bools of
insetcollapsable.h inside a "metri
On Fri, Mar 26, 2004 at 08:39:11PM +0100, Alfredo Braunstein wrote:
> Andre Poenitz wrote:
>
> >> So: either we add an insetdim_ member in InsetCollapsable and store the
> >> InsetText's dimension there, and we continue to overwrite dim_ (I have a
> >> patch for this),
> >
> > InsetCollapsable's
Andre Poenitz wrote:
>> So: either we add an insetdim_ member in InsetCollapsable and store the
>> InsetText's dimension there, and we continue to overwrite dim_ (I have a
>> patch for this),
>
> InsetCollapsable's dim should be the dimension of the InsetCollapsable.
> It could be created by call
On Thu, Mar 25, 2004 at 05:34:32PM +0100, Alfredo Braunstein wrote:
> Making collapsables derive from InsetText raises some problems, mainly there
> is one cached dimension/position missing. This problem is semi-addressed in
> insettext by not using its cached dim_ but use instead the dim
On Thu, Mar 25, 2004 at 04:53:15PM +, Angus Leeming wrote:
> Alfredo Braunstein wrote:
> > All this raises some doubts about the 'cleaningness' of deriving
> > collapsables from insettext IMHO.
>
> Agreed. Even the statement InsetCollapsable IS-A InsetText is wr
On Fri, Mar 26, 2004 at 10:15:33AM +0100, Alfredo Braunstein wrote:
> Angus Leeming wrote:
>
> > Agreed. Even the statement InsetCollapsable IS-A InsetText is wrong.
>
> I guess we'd have to wait for André to explain his reasons. In the cvs log
> it says it's for getting rid of the 'inset owner'
Andre Poenitz wrote:
> Well, it's a matter of '#if 0' or '#if 1'. I was just indicating that
> DEPM works with the new ParagraphList now.
>
> What do you suggest as replacement for DEPM?
>
> Drop it completely? This changes The LyX Experience a bit...
Now that we have a centralized cursor, som
On Wed, Mar 24, 2004 at 08:56:38AM +0100, Alfredo Braunstein wrote:
> Andre Poenitz wrote:
>
> > On Mon, Mar 22, 2004 at 02:29:10PM +0100, Alfredo Braunstein wrote:
> >> [which reminds me: maybe it's time to talk about DEPM again? *ducking*]
> >
> > What about it? It's back to life after applying
Angus Leeming wrote:
> Agreed. Even the statement InsetCollapsable IS-A InsetText is wrong.
I guess we'd have to wait for Andrà to explain his reasons. In the cvs log
it says it's for getting rid of the 'inset owner' pointer, which I think
was used for disallowing the insertion of certain types o
Alfredo Braunstein wrote:
> All this raises some doubts about the 'cleaningness' of deriving
> collapsables from insettext IMHO.
Agreed. Even the statement InsetCollapsable IS-A InsetText is wrong.
--
Making collapsables derive from InsetText raises some problems, mainly there
is one cached dimension/position missing. This problem is semi-addressed in
insettext by not using its cached dim_ but use instead the dimension of its
LyXText. dim_ is then overwritten in InsetCollapsable.
The problem
Andre Poenitz wrote:
> On Mon, Mar 22, 2004 at 02:00:04PM +0100, Alfredo Braunstein wrote:
>
> + if (!pit->isInset(i) || pit->getInset(i)->isChar()) {
> + // some insets are line separators too
> + if (pit->isLineSeparator(i)) {
> +
Andre Poenitz wrote:
> On Mon, Mar 22, 2004 at 02:29:10PM +0100, Alfredo Braunstein wrote:
>> [which reminds me: maybe it's time to talk about DEPM again? *ducking*]
>
> What about it? It's back to life after applying the 'patch previews'
> which I am probably going to do on Thursday.
A real pit
On Mon, Mar 22, 2004 at 02:29:10PM +0100, Alfredo Braunstein wrote:
> [which reminds me: maybe it's time to talk about DEPM again? *ducking*]
What about it? It's back to life after applying the 'patch previews'
which I am probably going to do on Thursday.
Andre'
On Mon, Mar 22, 2004 at 02:00:04PM +0100, Alfredo Braunstein wrote:
+ if (!pit->isInset(i) || pit->getInset(i)->isChar()) {
+ // some insets are line separators too
+ if (pit->isLineSeparator(i)) {
+ // registe
Alfredo Braunstein wrote:
> [which reminds me: maybe it's time to talk about DEPM again?
> [*ducking*]
I stayed out of the conversation last time(s) so suggest that you
start...
--
Angus
Angus Leeming wrote:
> Alfredo Braunstein wrote:
>
>> This is the patch, for if someone wants to test it and tell me how
>> it feels like.
>
> Do things like math insets in display mode also return true for
> breakAfter?
Right now these two go in parallel.
display = break after + break before
Alfredo Braunstein wrote:
> This is the patch, for if someone wants to test it and tell me how
> it feels like.
Do things like math insets in display mode also return true for
breakAfter?
--
Angus
This is the patch, for if someone wants to test it and tell me how it feels
like.
Alfredo
? ChangeLog-old
? PosIterator.C-save
? PosIterator.h-save
? bfri.C
? safe
? textcursor.C-save
? textcursor.h-save
? insets/insetcollapsable-save.C
? insets/insettext-save.C
Index: cursor.C
===
It was recently removed a 1.3.x feature of collapsables that was considered
useful with spellchecking.
The feature consisted of the following: on an edit event, a bool
first_after_edit was set to true. On any other event it was set to false.
Then on the search code, if nothing (more) was found
29 matches
Mail list logo
