Re: [LyX/master] Cmake build: Start demanding at least version 5.1 if compiling with gcc

2024-11-05 Thread Jean-Marc Lasgouttes
Le 05/11/2024 à 09:50, Pavel Sanda a écrit : Everything compiles fine with gcc 7 and Qt 5.9.5. Are we happy now? I think this was good move. Pavel And we have the possibility to switch to gcc 8 on this platform if the C++17 support is not sufficient. JMarc -- lyx-devel mailing list lyx-de

Re: [LyX/master] Cmake build: Start demanding at least version 5.1 if compiling with gcc

2024-11-05 Thread Pavel Sanda
On Mon, Nov 04, 2024 at 06:29:12PM +0100, Jean-Marc Lasgouttes wrote: > Le 25/10/2024 ?? 08:23, Pavel Sanda a écrit : > > Googling around > > 16.04 has Qt 5.5.1 & Python 3.5 & gcc 5.4 available even if not default. > > 18.04 has Qt 5.9.5 & Python 3.6 & gcc 7.5 available > > > > We did unnecessaril

Re: [LyX/master] Cmake build: Start demanding at least version 5.1 if compiling with gcc

2024-11-04 Thread Kornel Benko
Am Mon, 4 Nov 2024 18:32:27 +0100 schrieb Jean-Marc Lasgouttes : > Le 04/11/2024 à 18:29, Jean-Marc Lasgouttes a écrit : > > Le 25/10/2024 à 08:23, Pavel Sanda a écrit : > >> Googling around > >> 16.04 has Qt 5.5.1 & Python 3.5 & gcc 5.4 available even if not default. > >> 18.04 has Qt 5.9.5 & P

Re: [LyX/master] Cmake build: Start demanding at least version 5.1 if compiling with gcc

2024-11-04 Thread Jean-Marc Lasgouttes
Le 04/11/2024 à 18:29, Jean-Marc Lasgouttes a écrit : Le 25/10/2024 à 08:23, Pavel Sanda a écrit : Googling around 16.04 has Qt 5.5.1 & Python 3.5 & gcc 5.4 available even if not default. 18.04 has Qt 5.9.5 & Python 3.6 & gcc 7.5 available We did unnecessarily drastic cut. We can require gcc 7

Re: [LyX/master] Cmake build: Start demanding at least version 5.1 if compiling with gcc

2024-11-04 Thread Jean-Marc Lasgouttes
Le 25/10/2024 à 08:23, Pavel Sanda a écrit : Googling around 16.04 has Qt 5.5.1 & Python 3.5 & gcc 5.4 available even if not default. 18.04 has Qt 5.9.5 & Python 3.6 & gcc 7.5 available We did unnecessarily drastic cut. We can require gcc 7 only, but I think you just killed support Qt 5.9.5 anyw

Re: [LyX/master] Cmake build: Start demanding at least version 5.1 if compiling with gcc

2024-10-25 Thread Jean-Marc Lasgouttes
Le 24/10/2024 à 15:43, Pavel Sanda a écrit : On Thu, Oct 24, 2024 at 12:43:49PM +, Kornel Benko wrote: commit d6fba3b94e54ac58806d7cb65584edfdbe6d515e Author: Kornel Benko Date: Thu Oct 24 14:52:22 2024 +0200 Cmake build: Start demanding at least version 5.1 if compiling with gcc

Re: [LyX/master] Cmake build: Start demanding at least version 5.1 if compiling with gcc

2024-10-24 Thread Pavel Sanda
On Fri, Oct 25, 2024 at 12:43:26AM +0200, Jean-Marc Lasgouttes wrote: > >I thought that distros which have GCC<8 do not ship qt5, but qt4. > >Am I wrong here? Otherwise how are you going even to test it? > > Ubuntu 15.10 is GCC 5.4 and Qt 5.4. Just what we said except for python. > > I can almost

Re: [LyX/master] Cmake build: Start demanding at least version 5.1 if compiling with gcc

2024-10-24 Thread Pavel Sanda
On Thu, Oct 24, 2024 at 04:05:37PM +0200, Jean-Marc Lasgouttes wrote: > It may be that we still compile with gcc 6, which has bits of C++17. I feel > a bit lazy to check this, but I could in principle. I would say that we > allow ourselves to use every C++17 feature and see afterward what compiler

Re: [LyX/master] Cmake build: Start demanding at least version 5.1 if compiling with gcc

2024-10-24 Thread Pavel Sanda
On Thu, Oct 24, 2024 at 12:43:49PM +, Kornel Benko wrote: > commit d6fba3b94e54ac58806d7cb65584edfdbe6d515e > Author: Kornel Benko > Date: Thu Oct 24 14:52:22 2024 +0200 > > Cmake build: Start demanding at least version 5.1 if compiling with gcc We just agreed on

Re: [LyX/master] Cmake build: Require std >= 17 for compilation of QT6

2024-06-25 Thread Kornel Benko
Am Tue, 25 Jun 2024 14:05:38 +0200 schrieb Jean-Marc Lasgouttes : > Le 25/06/2024 à 13:45, Kornel Benko a écrit : > > commit 5ee53450bbef83b60edde401b075f2e1d51ce5b7 > > Author: Kornel Benko > > Date: Tue Jun 25 13:50:32 2024 +0200 > > > > Cmake build:

Re: cmake build with qt6 (macos) does not include "plugins"

2024-04-05 Thread Kornel Benko
Am Thu, 21 Mar 2024 23:21:18 +0100 schrieb pdv : > On 20/03/2024 11:26, Pavel Sanda wrote: > > On Tue, Mar 19, 2024 at 04:02:34PM +0100, pdv wrote: > >> These steps have been added to my previous patch (new patch included) and I > >> also derived the QT_PLUGINS_DIR and QT_LIBRARY_DIRS variables

Re: cmake build with qt6 (macos) does not include "plugins"

2024-03-23 Thread Kornel Benko
Am Thu, 21 Mar 2024 23:21:18 +0100 schrieb pdv : > On 20/03/2024 11:26, Pavel Sanda wrote: > > On Tue, Mar 19, 2024 at 04:02:34PM +0100, pdv wrote: > >> These steps have been added to my previous patch (new patch included) and I > >> also derived the QT_PLUGINS_DIR and QT_LIBRARY_DIRS variables

Re: cmake build with qt6 (macos) does not include "plugins"

2024-03-21 Thread pdv
On 20/03/2024 11:26, Pavel Sanda wrote: On Tue, Mar 19, 2024 at 04:02:34PM +0100, pdv wrote: These steps have been added to my previous patch (new patch included) and I also derived the QT_PLUGINS_DIR and QT_LIBRARY_DIRS variables from the existing Qt6_DIR/Qt5_DIR variable, so they must not long

Re: cmake build on macos (Sonoma, XCode) fails and remedy

2024-03-20 Thread Kornel Benko
Am Tue, 19 Mar 2024 15:31:00 +0100 schrieb pdv : > Using the latest commit and building lyx with cmake on macos-sonoma with > xcode fails with multiple error messages like this one: > > -- > CMake Error in po/CMakeLists.txt: >The custom command generating > > /po/LyX2.4.cat

Re: cmake build with qt6 (macos) does not include "plugins"

2024-03-20 Thread Kornel Benko
Am Sat, 4 Nov 2023 18:05:42 +0100 schrieb pdv : > On 04/11/2023 17:55, pdv wrote: > > On 21/03/2023 19:27, Kornel Benko wrote: > >> Am Tue, 21 Mar 2023 15:27:41 +0100 > >> schrieb pdv : > >> > >>> On 21/03/2023 11:00, Kornel Benko wrote: > Am Mon, 20 Mar 2023 20:05:32 +0100 > schrieb pdv

Re: cmake build with qt6 (macos) does not include "plugins"

2024-03-20 Thread Pavel Sanda
On Tue, Mar 19, 2024 at 04:02:34PM +0100, pdv wrote: > These steps have been added to my previous patch (new patch included) and I > also derived the QT_PLUGINS_DIR and QT_LIBRARY_DIRS variables from the > existing Qt6_DIR/Qt5_DIR variable, so they must not longer be supplied. I see there is some

Re: cmake build with qt6 (macos) does not include "plugins"

2024-03-19 Thread pdv
On 07/11/2023 17:42, pdv wrote: On 06/11/2023 19:17, pdv wrote: On 04/11/2023 20:35, Kornel Benko wrote: Am Sat, 4 Nov 2023 18:05:42 +0100 schrieb pdv : On 04/11/2023 17:55, pdv wrote: On 21/03/2023 19:27, Kornel Benko wrote: Am Tue, 21 Mar 2023 15:27:41 +0100 schrieb pdv : On 21/03/2023

cmake build on macos (Sonoma, XCode) fails and remedy

2024-03-19 Thread pdv
Using the latest commit and building lyx with cmake on macos-sonoma with xcode fails with multiple error messages like this one: -- CMake Error in po/CMakeLists.txt: The custom command generating /po/LyX2.4.cat.pot is attached to multiple targets: translations

Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-11 Thread Scott Kostyshak
On Sat, Nov 11, 2023 at 06:07:14PM +0100, Kornel Benko wrote: > Am Sat, 11 Nov 2023 11:14:51 -0500 > schrieb Scott Kostyshak : > > > > diff --git a/development/cmake/post_install/CMakeLists.txt > > > b/development/cmake/post_install/CMakeLists.txt index > > > 52a2f782af..f83cdaad0b 100644 > > > -

Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-11 Thread Kornel Benko
Am Sat, 11 Nov 2023 11:14:51 -0500 schrieb Scott Kostyshak : > > diff --git a/development/cmake/post_install/CMakeLists.txt > > b/development/cmake/post_install/CMakeLists.txt index > > 52a2f782af..f83cdaad0b 100644 > > --- a/development/cmake/post_install/CMakeLists.txt > > +++ b/development/cma

Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-11 Thread Scott Kostyshak
On Tue, Nov 07, 2023 at 05:42:27PM +0100, pdv wrote: > On 06/11/2023 19:17, pdv wrote: > > On 04/11/2023 20:35, Kornel Benko wrote: > > > Am Sat, 4 Nov 2023 18:05:42 +0100 > > > schrieb pdv : > > > > > > > On 04/11/2023 17:55, pdv wrote: > > > > > On 21/03/2023 19:27, Kornel Benko wrote: > > > > >

Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-07 Thread pdv
On 06/11/2023 19:17, pdv wrote: On 04/11/2023 20:35, Kornel Benko wrote: Am Sat, 4 Nov 2023 18:05:42 +0100 schrieb pdv : On 04/11/2023 17:55, pdv wrote: On 21/03/2023 19:27, Kornel Benko wrote: Am Tue, 21 Mar 2023 15:27:41 +0100 schrieb pdv : On 21/03/2023 11:00, Kornel Benko wrote: Am Mo

Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-06 Thread pdv
On 04/11/2023 20:35, Kornel Benko wrote: Am Sat, 4 Nov 2023 18:05:42 +0100 schrieb pdv : On 04/11/2023 17:55, pdv wrote: On 21/03/2023 19:27, Kornel Benko wrote: Am Tue, 21 Mar 2023 15:27:41 +0100 schrieb pdv : On 21/03/2023 11:00, Kornel Benko wrote: Am Mon, 20 Mar 2023 20:05:32 +0100 sch

Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-04 Thread Kornel Benko
Am Sat, 4 Nov 2023 18:05:42 +0100 schrieb pdv : > On 04/11/2023 17:55, pdv wrote: > > On 21/03/2023 19:27, Kornel Benko wrote: > >> Am Tue, 21 Mar 2023 15:27:41 +0100 > >> schrieb pdv : > >> > >>> On 21/03/2023 11:00, Kornel Benko wrote: > Am Mon, 20 Mar 2023 20:05:32 +0100 > schrieb pdv

Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-04 Thread pdv
On 04/11/2023 17:55, pdv wrote: On 21/03/2023 19:27, Kornel Benko wrote: Am Tue, 21 Mar 2023 15:27:41 +0100 schrieb pdv : On 21/03/2023 11:00, Kornel Benko wrote: Am Mon, 20 Mar 2023 20:05:32 +0100 schrieb pdv : It's within the first if() else(), that's thus for qt6(see below). I suppose thi

Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-04 Thread pdv
On 21/03/2023 19:27, Kornel Benko wrote: Am Tue, 21 Mar 2023 15:27:41 +0100 schrieb pdv : On 21/03/2023 11:00, Kornel Benko wrote: Am Mon, 20 Mar 2023 20:05:32 +0100 schrieb pdv : It's within the first if() else(), that's thus for qt6(see below). I suppose this should work for all platfor

Re: cmake build with qt6 (macos) does not include "plugins"

2023-03-21 Thread Kornel Benko
Am Tue, 21 Mar 2023 15:27:41 +0100 schrieb pdv : > On 21/03/2023 11:00, Kornel Benko wrote: > > Am Mon, 20 Mar 2023 20:05:32 +0100 > > schrieb pdv : > > > >> It's within the first if() else(), that's thus for qt6(see below). I > >> suppose this should work for all platforms, but I checked it on

Re: cmake build with qt6 (macos) does not include "plugins"

2023-03-21 Thread pdv
On 21/03/2023 11:00, Kornel Benko wrote: Am Mon, 20 Mar 2023 20:05:32 +0100 schrieb pdv : It's within the first if() else(), that's thus for qt6(see below). I suppose this should work for all platforms, but I checked it on macos only. Your patch is limited to APPLE and also works for me; If thi

Re: cmake build with qt6 (macos) does not include "plugins"

2023-03-21 Thread Kornel Benko
Am Mon, 20 Mar 2023 20:05:32 +0100 schrieb pdv : > It's within the first if() else(), that's thus for qt6(see below). I > suppose this should work for all platforms, but I checked it on macos > only. Your patch is limited to APPLE and also works for me; If this > problem doesn't occur for other

Re: cmake build with qt6 (macos) does not include "plugins"

2023-03-20 Thread pdv
On 20/03/2023 10:50, Kornel Benko wrote: Am Sun, 19 Mar 2023 20:45:55 +0100 schrieb pdv : The merge branch killqt4 (commit 9376... on nov 28) broke the cmake install build on macos. The "development/cmake/post_install/CMakeLists.txt' SCRIPT checks for qt5 and copies all plugins if different. T

Re: cmake build with qt6 (macos) does not include "plugins"

2023-03-20 Thread Kornel Benko
Am Sun, 19 Mar 2023 20:45:55 +0100 schrieb pdv : > The merge branch killqt4 (commit 9376... on nov 28) broke the cmake > install build on macos. > > The "development/cmake/post_install/CMakeLists.txt' SCRIPT checks for > qt5 and copies all plugins if different. This did work for qt4 but also >

cmake build with qt6 (macos) does not include "plugins"

2023-03-19 Thread pdv
The merge branch killqt4 (commit 9376... on nov 28) broke the cmake install build on macos. The "development/cmake/post_install/CMakeLists.txt' SCRIPT checks for qt5 and copies all plugins if different. This did work for qt4 but also for qt6. The killqt4 branch removed this else part for qt4

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Kornel Benko
Am Sat, 19 Nov 2022 21:34:41 +0100 schrieb Kornel Benko : > > If that doesn't work, do you want me to try to push the commit you made? > > > > Scott > > Yes please. > Thanks. Kornel pgpTupO85XP9P.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@li

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Scott Kostyshak
On Sat, Nov 19, 2022 at 09:34:41PM +0100, Kornel Benko wrote: > Am Sat, 19 Nov 2022 15:13:41 -0500 > schrieb Scott Kostyshak : > > > On Sat, Nov 19, 2022 at 07:09:51PM +0100, Kornel Benko wrote: > > > Am Sat, 19 Nov 2022 11:50:44 -0500 > > > schrieb Scott Kostyshak : > > > > > > > git branch ki

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Kornel Benko
Am Sat, 19 Nov 2022 15:13:41 -0500 schrieb Scott Kostyshak : > On Sat, Nov 19, 2022 at 07:09:51PM +0100, Kornel Benko wrote: > > Am Sat, 19 Nov 2022 11:50:44 -0500 > > schrieb Scott Kostyshak : > > > > > git branch killqt4 --set-upstream-to features/killqt4 > > > > I get > > fatal: branch 'k

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Scott Kostyshak
On Sat, Nov 19, 2022 at 07:09:51PM +0100, Kornel Benko wrote: > Am Sat, 19 Nov 2022 11:50:44 -0500 > schrieb Scott Kostyshak : > > > git branch killqt4 --set-upstream-to features/killqt4 > > I get > fatal: branch 'killqt4' does not exist > Exit 128 > > > Sorry, I am lost. I cannot even remove t

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Kornel Benko
Am Sat, 19 Nov 2022 11:50:44 -0500 schrieb Scott Kostyshak : > git branch killqt4 --set-upstream-to features/killqt4 I get fatal: branch 'killqt4' does not exist Exit 128 Sorry, I am lost. I cannot even remove the wrong branch. $ git branch -r | grep kill origin/kill-print origin/kill-tex

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Scott Kostyshak
t; > at 1a46a146e45984091ef1b3168a7ba7b940a14b09 (commit) > > > > > > > > > > - Log > > > > > - > > > > > > > > > > commit 1a46a146e45984091ef1b3168a7ba7b940a14b09 > > > > > Author: Kornel Benko &g

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Scott Kostyshak
; > > > > > > > commit 1a46a146e45984091ef1b3168a7ba7b940a14b09 > > > > Author: Kornel Benko > > > > Date: Sat Nov 19 14:45:03 2022 +0100 > > > > > > > > Amend ac248e39, get rid of Qt4 code also in cmake build

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Kornel Benko
> > Date: Sat Nov 19 14:45:03 2022 +0100 > > > > > > Amend ac248e39, get rid of Qt4 code also in cmake build > > > > I seem to be unable to commit to origin/killqt4. > > I think it is on the "features" repository: features/killqt4. >

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Scott Kostyshak
ommit) > > > > - Log - > > > > commit 1a46a146e45984091ef1b3168a7ba7b940a14b09 > > Author: Kornel Benko > > Date: Sat Nov 19 14:45:03 2022 +0100 > > > > Amend ac248e39, get rid of Qt4 code also in cmake bu

Re: [LyX features/remotes/origin/killqt4] Amend ac248e39, get rid of Qt4 code also in cmake build

2022-11-19 Thread Kornel Benko
> > commit 1a46a146e45984091ef1b3168a7ba7b940a14b09 > Author: Kornel Benko > Date: Sat Nov 19 14:45:03 2022 +0100 > > Amend ac248e39, get rid of Qt4 code also in cmake build I seem to be unable to commit to origin/killqt4. Kornel pgpyY9FJgHrk9.pgp Description: Digitale Signatur von

Re: [LyX/master] Cmake build: Fix the invalid test for '-Wno-deprecated-copy' flag

2021-09-29 Thread Kornel Benko
Am Wed, 29 Sep 2021 18:16:44 +0200 schrieb Jean-Marc Lasgouttes : > Le 29/09/2021 à 17:32, Kornel Benko a écrit : > > commit c26db650a1e93573e4c09d4612ad45ae1e219854 > > Author: Kornel Benko > > Date: Wed Sep 29 17:53:50 2021 +0200 > > > > Cmake buil

Re: [LyX/master] Cmake build: Unify use of sanitizer

2021-09-24 Thread Scott Kostyshak
On Tue, Sep 21, 2021 at 11:11:11AM +0200, Kornel Benko wrote: > commit 4f46c22d034b22ca80e906b97a4f0a8021f37611 > Author: Kornel Benko > Date: Tue Sep 21 11:27:13 2021 +0200 > > Cmake build: Unify use of sanitizer > > The configuration variable is LYX_DEBUG

Re: Check for the -Wno-deprecacted-copy compiler option in cmake build

2021-04-05 Thread Kornel Benko
ad "Re: warning: unknown warning option > >> '-Wno-deprecated-copy'" (8/10/2020) in this list. > >> > >> This was solved for the autotools build with commit 4aee447af1 > >> (13/10/2020). > >> > >> I've implemented

Re: Check for the -Wno-deprecacted-copy compiler option in cmake build

2021-04-04 Thread pdv
This was solved for the autotools build with commit 4aee447af1 (13/10/2020). I've implemented a similar check for the cmake build. As is stands the patch unsets the test-variable from the cache and the test is performed for each cmake-run. I don't know what's the preferred policy

Re: Check for the -Wno-deprecacted-copy compiler option in cmake build

2021-04-03 Thread Kornel Benko
for the autotools build with commit 4aee447af1 (13/10/2020). > > I've implemented a similar check for the cmake build. > > As is stands the patch unsets the test-variable from the cache and the > test is performed for each cmake-run. > I don't know what's the p

Check for the -Wno-deprecacted-copy compiler option in cmake build

2021-04-03 Thread pdv
plemented a similar check for the cmake build. As is stands the patch unsets the test-variable from the cache and the test is performed for each cmake-run. I don't know what's the preferred policy and one should remove that line to use the cached result instead. P. De Viss

Re: [LyX/master] Cmake build: Syntax of AC_INIT() in configure.ac changed, adapted macro

2020-12-30 Thread Kornel Benko
Am Tue, 29 Dec 2020 14:41:38 -0500 schrieb Scott Kostyshak : > On Tue, Dec 29, 2020 at 08:28:31PM +0100, Kornel Benko wrote: > > commit c07278a45c1d23d1ff8a2ed67e3cd8603680df12 > > Author: Kornel Benko > > Date: Tue Dec 29 20:27:19 2020 +0100 > > > > Cm

Re: [LyX/master] Cmake build: Syntax of AC_INIT() in configure.ac changed, adapted macro

2020-12-29 Thread Scott Kostyshak
On Tue, Dec 29, 2020 at 08:28:31PM +0100, Kornel Benko wrote: > commit c07278a45c1d23d1ff8a2ed67e3cd8603680df12 > Author: Kornel Benko > Date: Tue Dec 29 20:27:19 2020 +0100 > > Cmake build: Syntax of AC_INIT() in configure.ac changed, adapted macro > --- Thanks, I just

Re: macos-xcode-cmake build fails with --std=c++17 SOLVED

2020-11-14 Thread pdv
On 13/11/2020 17:14, Kornel Benko wrote: Am Fri, 13 Nov 2020 17:04:18 +0100 schrieb Kornel Benko : Am Fri, 13 Nov 2020 15:27:36 +0100 schrieb pdv : I suppose HAVE_DEF_MAKE_UNIQUE should have been set to one but it wasn't. Removing HAVE_DEF_MAKE_UNIQUE from cmake's cache didn't help. The check

Re: macos-xcode-cmake build fails with --std=c++17 SOLVED

2020-11-13 Thread Kornel Benko
Am Fri, 13 Nov 2020 17:04:18 +0100 schrieb Kornel Benko : > Am Fri, 13 Nov 2020 15:27:36 +0100 > schrieb pdv : > > > I suppose HAVE_DEF_MAKE_UNIQUE should have been set to one but it wasn't. > > Removing HAVE_DEF_MAKE_UNIQUE from cmake's cache didn't help. > > The check_cxx_source_compiles() in C

Re: macos-xcode-cmake build fails with --std=c++17 SOLVED

2020-11-13 Thread Kornel Benko
Am Fri, 13 Nov 2020 15:27:36 +0100 schrieb pdv : > I suppose HAVE_DEF_MAKE_UNIQUE should have been set to one but it wasn't. > Removing HAVE_DEF_MAKE_UNIQUE from cmake's cache didn't help. > The check_cxx_source_compiles() in ConfigureChecks.cmake was never > executed and HAVE_DEF_MAKE_UNIQUE was

Re: macos-xcode-cmake build fails with --std=c++17 SOLVED

2020-11-13 Thread pdv
I suppose HAVE_DEF_MAKE_UNIQUE should have been set to one but it wasn't. Removing HAVE_DEF_MAKE_UNIQUE from cmake's cache didn't help. The check_cxx_source_compiles() in ConfigureChecks.cmake was never executed and HAVE_DEF_MAKE_UNIQUE was never set. In the end I started from scratch and then

macos-xcode-cmake build fails with --std=c++17

2020-11-12 Thread pdv
Since commit 2ec243 (28/10) cmake builds defaults apparently to --std=c++17. Building with Xcode (11.3) on macos (10.14.6) then fails with message "call to 'make_unique' is ambiguous" make_unique() is in lyx/.../support/unique_ptr.h and in Xcode.app/.../memory This is the full error message:

Re: [LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

2020-10-23 Thread Kornel Benko
Am Thu, 22 Oct 2020 13:32:49 -0400 schrieb Scott Kostyshak : > On Thu, Oct 22, 2020 at 07:23:46PM +0200, Kornel Benko wrote: > > Am Thu, 22 Oct 2020 19:15:46 +0200 > > schrieb Kornel Benko : > > > > > Am Thu, 22 Oct 2020 13:07:02 -0400 > > > schrieb Scott Kostyshak : > > > > > > > -- CMAKE_C

Re: [LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

2020-10-22 Thread Scott Kostyshak
On Thu, Oct 22, 2020 at 07:23:46PM +0200, Kornel Benko wrote: > Am Thu, 22 Oct 2020 19:15:46 +0200 > schrieb Kornel Benko : > > > Am Thu, 22 Oct 2020 13:07:02 -0400 > > schrieb Scott Kostyshak : > > > > > -- CMAKE_COMPILER_IS_GNUCXX = 1 > > > CMake Error at CMakeLists.txt:702 (if): > > > if giv

Re: [LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

2020-10-22 Thread Kornel Benko
Am Thu, 22 Oct 2020 19:15:46 +0200 schrieb Kornel Benko : > Am Thu, 22 Oct 2020 13:07:02 -0400 > schrieb Scott Kostyshak : > > > -- CMAKE_COMPILER_IS_GNUCXX = 1 > > CMake Error at CMakeLists.txt:702 (if): > > if given arguments: > > > > "stdfeature" "GREATER_EQUAL" "0" > > > > Unknown a

Re: [LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

2020-10-22 Thread Kornel Benko
Am Thu, 22 Oct 2020 13:07:02 -0400 schrieb Scott Kostyshak : > -- CMAKE_COMPILER_IS_GNUCXX = 1 > CMake Error at CMakeLists.txt:702 (if): > if given arguments: > > "stdfeature" "GREATER_EQUAL" "0" > > Unknown arguments specified > > > -- Configuring incomplete, errors occurred! > See al

Re: [LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

2020-10-22 Thread Scott Kostyshak
ak : > > > > > > > On Thu, Oct 22, 2020 at 01:23:51PM +0200, Kornel Benko wrote: > > > > > commit d954a6b09cc9d284a34510f076c16f22b425ead2 > > > > > Author: Kornel Benko > > > > > Date: Thu Oct 22 13:46:29

Re: [LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

2020-10-22 Thread Kornel Benko
Benko wrote: > > > > commit d954a6b09cc9d284a34510f076c16f22b425ead2 > > > > Author: Kornel Benko > > > > Date: Thu Oct 22 13:46:29 2020 +0200 > > > > > > > > Cmake build: Next try to use of '--std=c++17' for gnu compiler"

Re: [LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

2020-10-22 Thread Scott Kostyshak
: Kornel Benko > > > Date: Thu Oct 22 13:46:29 2020 +0200 > > > > > > Cmake build: Next try to use of '--std=c++17' for gnu compiler" > > > > > > Setting CMAKE_CXX_STANDARD explicitly, so that cmake can use > > >

Re: [LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

2020-10-22 Thread Kornel Benko
Am Thu, 22 Oct 2020 10:20:49 -0400 schrieb Scott Kostyshak : > On Thu, Oct 22, 2020 at 01:23:51PM +0200, Kornel Benko wrote: > > commit d954a6b09cc9d284a34510f076c16f22b425ead2 > > Author: Kornel Benko > > Date: Thu Oct 22 13:46:29 2020 +0200 > > > > Cmake

Re: [LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

2020-10-22 Thread Scott Kostyshak
On Thu, Oct 22, 2020 at 01:23:51PM +0200, Kornel Benko wrote: > commit d954a6b09cc9d284a34510f076c16f22b425ead2 > Author: Kornel Benko > Date: Thu Oct 22 13:46:29 2020 +0200 > > Cmake build: Next try to use of '--std=c++17' for gnu compiler" >

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Kornel Benko
Am Sun, 19 Apr 2020 16:02:47 +0200 schrieb Stephan Witt : > >>> On linux this is easy. > >>> Lyx sets the env LYXSOCKET. > >>> Okular calls 'lyxclient -g %f %s'. > >>> lyxclient interprets the env LYXSOCKET and connect to lyx. > > BTW, lyxclient with option -g doesn’t use the pipes we’re talk

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Stephan Witt
Am 19.04.2020 um 14:44 schrieb Kornel Benko : > > Am Sun, 19 Apr 2020 14:25:05 +0200 > schrieb Stephan Witt : > >> Am 19.04.2020 um 14:17 schrieb Kornel Benko : >>> >>> Am Sun, 19 Apr 2020 13:52:01 +0200 >>> schrieb Stephan Witt : >>> > Imagine that you have 2 different version of lyx runni

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Kornel Benko
Am Sun, 19 Apr 2020 14:25:05 +0200 schrieb Stephan Witt : > Am 19.04.2020 um 14:17 schrieb Kornel Benko : > > > > Am Sun, 19 Apr 2020 13:52:01 +0200 > > schrieb Stephan Witt : > > > >>> Imagine that you have 2 different version of lyx running. Each one > >>> previewing > >>> some different pd

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Stephan Witt
Am 19.04.2020 um 14:17 schrieb Kornel Benko : > > Am Sun, 19 Apr 2020 13:52:01 +0200 > schrieb Stephan Witt : > >>> Imagine that you have 2 different version of lyx running. Each one >>> previewing >>> some different pdf. How can you select the correct pipe? >> >> The answer is easy: you cann

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Kornel Benko
Am Sun, 19 Apr 2020 13:52:01 +0200 schrieb Stephan Witt : > > Imagine that you have 2 different version of lyx running. Each one > > previewing > > some different pdf. How can you select the correct pipe? > > The answer is easy: you cannot. > > Did you do that already? > > There is no way to

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Stephan Witt
Am 19.04.2020 um 13:23 schrieb Kornel Benko : > > Am Sun, 19 Apr 2020 13:08:17 +0200 > schrieb Stephan Witt : > >>> But we really need some way to give info about the correct pipe >>> to the relevant programs IMHO. >> >> I’m not sure. These pipes are somewhat portable but nevertheless a strate

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Kornel Benko
Am Sun, 19 Apr 2020 13:08:17 +0200 schrieb Stephan Witt : > > But we really need some way to give info about the correct pipe > > to the relevant programs IMHO. > > I’m not sure. These pipes are somewhat portable but nevertheless a strategy > of inter-process-communication that is not common. I

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Stephan Witt
Am 19.04.2020 um 11:42 schrieb Kornel Benko : > > Am Sun, 19 Apr 2020 11:27:08 +0200 > schrieb Enrico Forestieri : > >> On Sun, Apr 19, 2020 at 10:54:07AM +0200, Kornel Benko wrote: >> >>> Am Sun, 19 Apr 2020 10:16:28 +0200 >>> schrieb Stephan Witt : >>> > The serverpipe entry in saved user

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Kornel Benko
Am Sun, 19 Apr 2020 11:27:08 +0200 schrieb Enrico Forestieri : > On Sun, Apr 19, 2020 at 10:54:07AM +0200, Kornel Benko wrote: > > > Am Sun, 19 Apr 2020 10:16:28 +0200 > > schrieb Stephan Witt : > > > > > > The serverpipe entry in saved users preferences is written only on a > > > > explicit

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Enrico Forestieri
On Sun, Apr 19, 2020 at 10:54:07AM +0200, Kornel Benko wrote: > Am Sun, 19 Apr 2020 10:16:28 +0200 > schrieb Stephan Witt : > > > > The serverpipe entry in saved users preferences is written only on a > > > explicit > > > change of this entry by the user. The location of the pipe is derived from

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Kornel Benko
Am Sun, 19 Apr 2020 10:16:28 +0200 schrieb Stephan Witt : > > The serverpipe entry in saved users preferences is written only on a > > explicit > > change of this entry by the user. The location of the pipe is derived from > > the installed lyxrc.dist then. > > To be more explicit: the lookup

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Stephan Witt
Am 18.04.2020 um 08:50 schrieb Kornel Benko : >>>>> >>>>> commit 0135682fca9bcdbf4f355aa6ef4e6f78b4e8b49b >>>>> Author: Kornel Benko >>>>> Date: Sat Apr 18 09:06:56 2020 +0200 >>>>> >>>>> Amend(1) 689f

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Stephan Witt
it 0135682fca9bcdbf4f355aa6ef4e6f78b4e8b49b >>>> Author: Kornel Benko >>>> Date: Sat Apr 18 09:06:56 2020 +0200 >>>> >>>> Amend(1) 689f26d2: Add default path to server pipe (cmake build) >>>> >>>> Added handling for cygwi

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-19 Thread Stephan Witt
Am 18.04.2020 um 22:49 schrieb Kornel Benko : > > Am Sat, 18 Apr 2020 22:11:36 +0200 > schrieb Stephan Witt : > >> Yes, it’s possible. But not at the same location. /Applications/LyX.app is >> 2.3 or 2.4 >> but not at the same time. And Skim looks there as I said. >> >> One can change Skim’s pr

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Kornel Benko
Am Sat, 18 Apr 2020 22:49:18 +0200 schrieb Kornel Benko : > Am Sat, 18 Apr 2020 22:11:36 +0200 > schrieb Stephan Witt : > > > Yes, it’s possible. But not at the same location. /Applications/LyX.app is > > 2.3 or 2.4 > > but not at the same time. And Skim looks there as I said. > > > > One can c

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Kornel Benko
Am Sat, 18 Apr 2020 22:11:36 +0200 schrieb Stephan Witt : > Yes, it’s possible. But not at the same location. /Applications/LyX.app is > 2.3 or 2.4 > but not at the same time. And Skim looks there as I said. > > One can change Skim’s preference to look at some other place - > but unfortunately t

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Kornel Benko
Am Sat, 18 Apr 2020 22:11:36 +0200 schrieb Stephan Witt : > > If you use versioned lyx, you can install more than one version side by > > side. > > Are you saying, you never done it? > > Yes, it’s possible. But not at the same location. /Applications/LyX.app is > 2.3 or 2.4 > but not at the s

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Stephan Witt
Am 18.04.2020 um 21:44 schrieb Kornel Benko : > > Am Sat, 18 Apr 2020 21:11:28 +0200 > schrieb Stephan Witt : > >> Am 18.04.2020 um 21:00 schrieb Kornel Benko : >>> >>> Am Sat, 18 Apr 2020 20:11:01 +0200 >>> schrieb Stephan Witt : >>> Am 18.04.2020 um 15:58 schrieb Kornel Benko : >

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Kornel Benko
Am Sat, 18 Apr 2020 21:11:28 +0200 schrieb Stephan Witt : > Am 18.04.2020 um 21:00 schrieb Kornel Benko : > > > > Am Sat, 18 Apr 2020 20:11:01 +0200 > > schrieb Stephan Witt : > > > >> Am 18.04.2020 um 15:58 schrieb Kornel Benko : > >>> > >>> Am Sat, 18 Apr 2020 11:47:18 +0200 > >>> schrieb

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Stephan Witt
> >>>> Am 18.04.2020 um 08:50 schrieb Kornel Benko : >>>>> >>>>> commit 0135682fca9bcdbf4f355aa6ef4e6f78b4e8b49b >>>>> Author: Kornel Benko >>>>> Date: Sat Apr 18 09:06:56 2020 +0200 >>>>> >>>>>

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Kornel Benko
>>> commit 0135682fca9bcdbf4f355aa6ef4e6f78b4e8b49b > >>> Author: Kornel Benko > >>> Date: Sat Apr 18 09:06:56 2020 +0200 > >>> > >>> Amend(1) 689f26d2: Add default path to server pipe (cmake build) > >>> > >>

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Stephan Witt
o >>> Date: Sat Apr 18 09:06:56 2020 +0200 >>> >>> Amend(1) 689f26d2: Add default path to server pipe (cmake build) >>> >>> Added handling for cygwin and win32 >>> MacOSX is unchanged, Stephan could you look at it? >> >> Act

Re: [LyX/master] Amend(3) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Kornel Benko
Am Sat, 18 Apr 2020 17:52:02 +0200 schrieb Enrico Forestieri : > On Sat, Apr 18, 2020 at 05:45:58PM +0200, Enrico Forestieri wrote: > > > > Why don't you simply use support::addName? > > Forget it. You are replacing, not adding a path component. > Yes. Kornel pgpIdCkxHKWBe.pgp Des

Re: [LyX/master] Amend(3) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Enrico Forestieri
On Sat, Apr 18, 2020 at 05:45:58PM +0200, Enrico Forestieri wrote: > > Why don't you simply use support::addName? Forget it. You are replacing, not adding a path component. -- Enrico -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] Amend(3) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Enrico Forestieri
On Sat, Apr 18, 2020 at 04:14:00PM +0200, Kornel Benko wrote: > commit 237378477f11026e8bd2cec389632d4ca410aef8 > Author: Kornel Benko > Date: Sat Apr 18 16:32:24 2020 +0200 > > Amend(3) 689f26d2: Add default path to server pipe (cmake build) > > Omit dup

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Kornel Benko
9f26d2: Add default path to server pipe (cmake build) > > > >Added handling for cygwin and win32 > >MacOSX is unchanged, Stephan could you look at it? > > Actually it was working on Mac w/o problem before. What should I look at? > What do you expect to happe

Re: [LyX/master] Amend(1) 689f26d2: Add default path to server pipe (cmake build)

2020-04-18 Thread Stephan Witt
Am 18.04.2020 um 08:50 schrieb Kornel Benko : > > commit 0135682fca9bcdbf4f355aa6ef4e6f78b4e8b49b > Author: Kornel Benko > Date: Sat Apr 18 09:06:56 2020 +0200 > >Amend(1) 689f26d2: Add default path to server pipe (cmake build) > >Added handling for cygwin

Re: [LyX/master] Cmake build: Extend build info in Help>About

2020-03-25 Thread Scott Kostyshak
On Wed, Mar 25, 2020 at 05:56:30PM +0100, Kornel Benko wrote: > Am Wed, 25 Mar 2020 12:17:31 -0400 > schrieb Scott Kostyshak : > > > On Wed, Mar 25, 2020 at 03:09:42PM +0100, Kornel Benko wrote: > > > Am Wed, 25 Mar 2020 14:44:09 +0100 > > > schrieb Kornel Benko : > > > > > > > > Nice! Can we a

Re: [LyX/master] Cmake build: Extend build info in Help>About

2020-03-25 Thread Kornel Benko
Am Wed, 25 Mar 2020 12:17:31 -0400 schrieb Scott Kostyshak : > On Wed, Mar 25, 2020 at 03:09:42PM +0100, Kornel Benko wrote: > > Am Wed, 25 Mar 2020 14:44:09 +0100 > > schrieb Kornel Benko : > > > > > > Nice! Can we add "Qt version" to the CMake output? In case it is > > > > helpful, here are m

Re: [LyX/master] Cmake build: Extend build info in Help>About

2020-03-25 Thread Scott Kostyshak
On Wed, Mar 25, 2020 at 03:09:42PM +0100, Kornel Benko wrote: > Am Wed, 25 Mar 2020 14:44:09 +0100 > schrieb Kornel Benko : > > > > Nice! Can we add "Qt version" to the CMake output? In case it is > > > helpful, here are my current outputs for master with CMake and with > > > autotools: > > > > >

Re: [LyX/master] Cmake build: Extend build info in Help>About

2020-03-25 Thread Kornel Benko
Am Wed, 25 Mar 2020 14:44:09 +0100 schrieb Kornel Benko : > > Nice! Can we add "Qt version" to the CMake output? In case it is > > helpful, here are my current outputs for master with CMake and with > > autotools: > > > > > > The QT-version and 'LyX files dir' is also at Help->About->Version.

Re: [LyX/master] Cmake build: Extend build info in Help>About

2020-03-25 Thread Kornel Benko
Am Wed, 25 Mar 2020 09:35:03 -0400 schrieb Scott Kostyshak : > On Wed, Mar 25, 2020 at 01:33:15PM +0100, Kornel Benko wrote: > > commit 3df9525a13de33b235d41a94cac9d2b1b8546c9b > > Author: Kornel Benko > > Date: Wed Mar 25 13:48:16 2020 +0100 > > > > Cmake

Re: [LyX/master] Cmake build: Extend build info in Help>About

2020-03-25 Thread Scott Kostyshak
On Wed, Mar 25, 2020 at 01:33:15PM +0100, Kornel Benko wrote: > commit 3df9525a13de33b235d41a94cac9d2b1b8546c9b > Author: Kornel Benko > Date: Wed Mar 25 13:48:16 2020 +0100 > > Cmake build: Extend build info in Help>About > > Added list of used cmake opt

Re: [PATCH] CMake build: find enchant 2.x binary and lib

2020-03-13 Thread Scott Kostyshak
On Fri, Mar 13, 2020 at 11:17:57AM +0100, Jean-Marc Lasgouttes wrote: > Le 13/03/2020 à 03:40, Scott Kostyshak a écrit : > > I've tested this patch on Ubuntu 20.04 daily for Enchant 2.x, and on > > Ubuntu 19.10 for Enchant 1.x. > > Do you need something for autoconf too? I think that Jürgen took

Re: [PATCH] CMake build: find enchant 2.x binary and lib

2020-03-13 Thread Jean-Marc Lasgouttes
Le 13/03/2020 à 03:40, Scott Kostyshak a écrit : I've tested this patch on Ubuntu 20.04 daily for Enchant 2.x, and on Ubuntu 19.10 for Enchant 1.x. Do you need something for autoconf too? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [PATCH] CMake build: find enchant 2.x binary and lib

2020-03-13 Thread Kornel Benko
Am Thu, 12 Mar 2020 22:40:21 -0400 schrieb Scott Kostyshak : > I've tested this patch on Ubuntu 20.04 daily for Enchant 2.x, and on > Ubuntu 19.10 for Enchant 1.x. > > Kornel, any thoughts? > > Scott Looks OK. If that works for you, then +1. Kornel pgpe49J6O_YmF.pgp Description: Digi

  1   2   3   >