Re: close tab button...

2007-10-16 Thread Bennett Helm
On Oct 15, 2007, at 12:03 PM, Jürgen Spitzmüller wrote: Bennett Helm wrote: Do you know the filename of the icon? No. I've found one -- actually three, which correspond to the normal button appearance, its appearance when the mouse hovers over it, and its appearance when pressed. I'm no

Re: close tab button...

2007-10-15 Thread Edwin Leuven
Bennett Helm wrote: And that shows that Mac defaults and Windows defaults are different, which was my point. sure. so just put in a this-years-style mac button when you package lyx...

Re: close tab button...

2007-10-15 Thread Bennett Helm
On Oct 15, 2007, at 12:58 PM, Edwin Leuven wrote: Bennett Helm wrote: I did a bit of digging, and I can't find it. I use the default theme, and I checked in the Firefox.app bundle and in Library/ Application Support/Firefox, etc. Do you know the filename of the icon? on windows the icon i

Re: close tab button...

2007-10-15 Thread Edwin Leuven
Bennett Helm wrote: I did a bit of digging, and I can't find it. I use the default theme, and I checked in the Firefox.app bundle and in Library/Application Support/Firefox, etc. Do you know the filename of the icon? on windows the icon is square. see attached... <>

Re: close tab button...

2007-10-15 Thread Jürgen Spitzmüller
Bennett Helm wrote: > Do you know the filename of the icon? No. Jürgen

Re: close tab button...

2007-10-15 Thread Bennett Helm
On Oct 15, 2007, at 4:41 AM, Jürgen Spitzmüller wrote: Bennett Helm wrote: I could, but the relevant issue is what Mac OS standards are, and it's not square buttons but round or oval buttons -- round in this case. Mac also does not use a colorful button in this case but -- in this case -- grey

Re: close tab button...

2007-10-15 Thread Jürgen Spitzmüller
Bennett Helm wrote: > I could, but the relevant issue is what Mac OS standards are, and   > it's not square buttons but round or oval buttons -- round in this   > case. Mac also does not use a colorful button in this case but -- in   > this case -- grey buttons. My firefox looks different. However

Re: close tab button...

2007-10-14 Thread Bennett Helm
ke firefox? Because Firefox follows Mac standards in this instance (but not every instance). I'm attaching another picture of a close-tab button taken from Apple's own Safari. The difference between Safari and Firefox is that Safari uses brushed metal, which is not what I think we

Re: close tab button...

2007-10-14 Thread Edwin Leuven
Bennett Helm wrote: That said, the square button that 1.6 acquired looks wrong on Mac could you send a screenshot? The picture I provided was not a current screenshot but rather a picture of how it *should* look on Mac (taken from Firefox's tab implementation). why should lyx look like fir

Re: close tab button...

2007-10-14 Thread Bennett Helm
On Oct 14, 2007, at 10:25 AM, Jürgen Spitzmüller wrote: Edwin Leuven wrote: the screenshot bennett send showed a round button whereas the pixmap that is now in trunk is square, so i am a bit puzzled by that and suspect something went wrong on his side when copying stuff to the installation dirs

Re: close tab button...

2007-10-14 Thread Jürgen Spitzmüller
Edwin Leuven wrote: > the screenshot bennett send showed a round button whereas the pixmap > that is now in trunk is square, so i am a bit puzzled by that and > suspect something went wrong on his side when copying stuff to the > installation dirs. but i don't own a mac so this is still hanging in

Re: close tab button...

2007-10-14 Thread Edwin Leuven
Jürgen Spitzmüller wrote: Edwin Leuven wrote: no bug, it just renders the close tab button in the corner in a better way I see. I thought Mac users were not very happy with the new design. What is the outcome of this discussion? the screenshot bennett send showed a round button whereas the

Re: close tab button...

2007-10-14 Thread Jürgen Spitzmüller
Edwin Leuven wrote: > no bug, it just renders the close tab button in the corner in a better way I see. I thought Mac users were not very happy with the new design. What is the outcome of this discussion? Jürgen

Re: close tab button...

2007-10-14 Thread Edwin Leuven
Jürgen Spitzmüller wrote: Edwin Leuven wrote: jürgen, you want this for branch? What does it fix? no bug, it just renders the close tab button in the corner in a better way you'll notice that in 1.5 it doesn't fit nicely in the corner (click to see) and overlaps a couple of p

Re: close tab button...

2007-10-14 Thread Jürgen Spitzmüller
Edwin Leuven wrote: > jürgen, you want this for branch? What does it fix? Jürgen

Re: close tab button...

2007-10-14 Thread Edwin Leuven
Edwin Leuven wrote: i'd like to apply attached (icon + patch) things look nicer then jürgen, you want this for branch?

Re: close tab button...

2007-10-11 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: The parent was set to GuiView instead of the QTabWidget. how obvious now you tell me... That was exactly my reaction when I discovered this by luck ;-) Abdel.

Re: close tab button...

2007-10-11 Thread Edwin Leuven
Bennett Helm wrote: Actually, the new icon just looks wrong on a Mac; this is the old icon

Re: close tab button...

2007-10-11 Thread Bennett Helm
On Oct 11, 2007, at 2:58 PM, Edwin Leuven wrote: Abdelrazak Younes wrote: What does that mean? The close button is back since last week I think... only noticed now! what was the problem? i'd like to apply attached (icon + patch) Fine with me. will apply then (this is how the qt people d

Re: close tab button...

2007-10-11 Thread Edwin Leuven
Abdelrazak Younes wrote: The parent was set to GuiView instead of the QTabWidget. how obvious now you tell me...

Re: close tab button...

2007-10-11 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: What does that mean? The close button is back since last week I think... only noticed now! what was the problem? The parent was set to GuiView instead of the QTabWidget. Abdel.

Re: close tab button...

2007-10-11 Thread Edwin Leuven
Abdelrazak Younes wrote: What does that mean? The close button is back since last week I think... only noticed now! what was the problem? i'd like to apply attached (icon + patch) Fine with me. will apply then (this is how the qt people do it...)

Re: close tab button...

2007-10-11 Thread Abdelrazak Younes
Edwin Leuven wrote: ...magically reappeared thanks to a pixie on the list What does that mean? The close button is back since last week I think... i'd like to apply attached (icon + patch) things look nicer then ok? Fine with me. Abdel.

close tab button...

2007-10-11 Thread Edwin Leuven
...magically reappeared thanks to a pixie on the list i'd like to apply attached (icon + patch) things look nicer then ok? Index: src/frontends/qt4/GuiWorkArea.cpp === --- src/frontends/qt4/GuiWorkArea.cpp (revision 20913) +++

Re: Close tab button

2007-06-14 Thread Peter Kümmel
Stefan Schimanski wrote: >> The patch works fine on Windows, and I don't thank that there will be >> problems on Linux. Commit it without the layout->addStretch(1); line, >> addStretch makes the tabs smaller only, they are already at the >> right place. > > Can anybody on linux please confirm? The

Re: Close tab button

2007-06-14 Thread Stefan Schimanski
The patch works fine on Windows, and I don't thank that there will be problems on Linux. Commit it without the layout->addStretch(1); line, addStretch makes the tabs smaller only, they are already at the right place. Can anybody on linux please confirm? Then I commit it. Stefan PGP.sig Descr

Re: Close tab button

2007-06-14 Thread Peter Kümmel
Stefan Schimanski wrote: > Here is a patch which fixes the cosmetic problem on Mac. I have no Linux > or Windows here though and have no idea how it looks there. Especially > the commented addStretch line might be necessary on Windows to move the > tabs to the left. Is this correct? On Mac this wo

Re: Close tab button

2007-06-13 Thread Stefan Schimanski
Here is a patch which fixes the cosmetic problem on Mac. I have no Linux or Windows here though and have no idea how it looks there. Especially the commented addStretch line might be necessary on Windows to move the tabs to the left. Is this correct? On Mac this would look wrong. Stefan

Re: Close tab button

2007-06-13 Thread Stefan Schimanski
Without the addStretch line and with a proper icon it looks even uglier. Bild 6.png Description: application/applefile <> Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: Close tab button

2007-06-13 Thread Stefan Schimanski
Just noticed with a new build: it looks strange on Mac. See here: Bild 5.png Description: application/applefile <> I guess the tabs should still be centered as they were before. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: Close tab button

2007-06-11 Thread Peter Kümmel
Darren Freeman wrote: > On Fri, 2007-06-08 at 21:51 +0200, Peter Kümmel wrote: >> Attached a small patch and a png for a button >> to close the current tab, see screen shot. >> closetab.png have to go into lib/images. >> >> Jose, please tell me when I could put it in. >> >> Peter > > I don't see t

Re: Close tab button

2007-06-11 Thread Darren Freeman
On Fri, 2007-06-08 at 21:51 +0200, Peter Kümmel wrote: > Attached a small patch and a png for a button > to close the current tab, see screen shot. > closetab.png have to go into lib/images. > > Jose, please tell me when I could put it in. > > Peter I don't see the PNG if run as "lyx" after a "m

Re: Close tab button

2007-06-11 Thread Darren Freeman
On Fri, 2007-06-08 at 14:59 -0500, Bo Peng wrote: > On 6/8/07, Peter Kümmel <[EMAIL PROTECTED]> wrote: > > Attached a small patch and a png for a button > > to close the current tab, see screen shot. > > closetab.png have to go into lib/images. > > > > Jose, please tell me when I could put it in. >

Re: Close tab button

2007-06-11 Thread José Matos
On Friday 08 June 2007 20:51:28 Peter Kümmel wrote: > Jose, please tell me when I could put it in. Go on. > Peter -- José Abílio

Re: Close tab button

2007-06-09 Thread Pavel Sanda
> Yes, in the long term this is a solution. But currently we rely on Qt 4.1, > so I hope it could go in for 1.5. i hope so :) pavel

Re: Close tab button

2007-06-09 Thread Peter Kümmel
Pavel Sanda wrote: I agree with Pavel. >>> I not, because I don't like such buttons. >> I like the patch like it is. Single tab buttons take screen space and >> clutter the appearance. > > i suppose it wont be problem to make switch between these two appearances in > preferences when the se

Re: Close tab button

2007-06-09 Thread Pavel Sanda
> >>I agree with Pavel. > > > >I not, because I don't like such buttons. > > I like the patch like it is. Single tab buttons take screen space and > clutter the appearance. i suppose it wont be problem to make switch between these two appearances in preferences when the second is available. p

Re: Close tab button

2007-06-09 Thread Stefan Schimanski
Am 09.06.2007 um 09:52 schrieb Peter Kümmel: Jürgen Spitzmüller wrote: Pavel Sanda wrote: Firefox also had only one button in the 1.5 series. And I don't like the 2.x UI with the button per tab. please dont close the bug for close button on tab. the main advantage of one button per tab is

Re: Close tab button

2007-06-09 Thread Peter Kümmel
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: >>> Firefox also had only one button in the 1.5 series. And I don't like >>> the 2.x UI with the button per tab. >> please dont close the bug for close button on tab. >> the main advantage of one button per tab is the possibility to close >> different

Re: Close tab button

2007-06-09 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > Firefox also had only one button in the 1.5 series. And I don't like > > the 2.x UI with the button per tab. > > please dont close the bug for close button on tab. > the main advantage of one button per tab is the possibility to close > different tabs just by one click withou

Re: Close tab button

2007-06-08 Thread Pavel Sanda
> Firefox also had only one button in the 1.5 series. And I don't like > the 2.x UI with the button per tab. please dont close the bug for close button on tab. the main advantage of one button per tab is the possibility to close different tabs just by one click without choosing the tab to be acti

Re: Close tab button

2007-06-08 Thread Peter Kümmel
Bo Peng wrote: > On 6/8/07, Peter Kümmel <[EMAIL PROTECTED]> wrote: >> Attached a small patch and a png for a button >> to close the current tab, see screen shot. >> closetab.png have to go into lib/images. >> >> Jose, please tell me when I could put it in. > > Good work. This is requested by many

Re: Close tab button

2007-06-08 Thread Bo Peng
On 6/8/07, Peter Kümmel <[EMAIL PROTECTED]> wrote: Attached a small patch and a png for a button to close the current tab, see screen shot. closetab.png have to go into lib/images. Jose, please tell me when I could put it in. Good work. This is requested by many people, although they seem to p

Close tab button

2007-06-08 Thread Peter Kümmel
Attached a small patch and a png for a button to close the current tab, see screen shot. closetab.png have to go into lib/images. Jose, please tell me when I could put it in. Peter Index: src/frontends/qt4/GuiView.h === --- src/fr